cyberpresidentvanellope/Paradise
1
0
Fork 0
mirror of https://github.com/ParadiseSS13/Paradise.git synced 2026-08-25 21:19:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add job_globals sanitization, fix duplicate value (#24795)

Browse Source 
* Add job_globals sanitization, fix duplicate value

* Remove 'support_positions' job category

* Add Supply dept to jobban list
This commit is contained in:
Zantox
2024-03-27 19:31:08 +00:00
committed by GitHub
parent 608889fbcd
commit 06969b4da1
7 changed files with 79 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/_unit_tests.dm
+1
View File
@@ -2,6 +2,7 @@
//Keep this sorted alphabetically
#ifdef UNIT_TESTS
#include "jobs\test_job_globals.dm"
#include "aicard_icons.dm"
#include "announcements.dm"
#include "areas_apcs.dm"
code/modules/unit_tests/jobs/test_job_globals.dm
+26
View File
@@ -0,0 +1,26 @@
/datum/unit_test/job_globals/Run()
return
/datum/unit_test/job_globals/proc/is_list_unique(list/L)
var/list_length = length(L)
var/unique_list = uniqueList(L)
var/unique_list_length = length(unique_list)
return list_length == unique_list_length
/datum/unit_test/job_globals/proc/validate_list(list/L, list_name)
if(!is_list_unique(L))
Fail("job_globals list '[list_name]' contains duplicate values.")
/datum/unit_test/job_globals/no_duplicates/Run()
validate_list(GLOB.station_departments, "station_departments")
validate_list(GLOB.command_positions, "command_positions")
validate_list(GLOB.command_head_positions, "command_head_positions")
validate_list(GLOB.engineering_positions, "engineering_positions")
validate_list(GLOB.medical_positions, "medical_positions")
validate_list(GLOB.science_positions, "science_positions")
validate_list(GLOB.supply_positions, "supply_positions")
validate_list(GLOB.service_positions, "service_positions")
validate_list(GLOB.security_positions, "security_positions")
validate_list(GLOB.active_security_positions, "active_security_positions")
validate_list(GLOB.assistant_positions, "assistant_positions")
validate_list(GLOB.nonhuman_positions, "nonhuman_positions")