cyberpresidentvanellope/Paradise
1
0
Fork 0
mirror of https://github.com/ParadiseSS13/Paradise.git synced 2026-07-21 12:04:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

[FIX] Ventcrawling overlay fixes (#27013)

Browse Source 
* Vent images update while ventcrawling

* Add some comments

* Autodoc for a variable

* Get rid of this useless timer

* Update code/modules/atmospherics/machinery/atmospherics.dm

Co-authored-by: Nathan Winters <100448493+CinnamonSnowball@users.noreply.github.com>
Signed-off-by: Chap <erwin@lombok.demon.nl>

* Move update pipe image to unary base

* We're doing signals now

* Added a comment to the signal

* Trailing newline

---------

Signed-off-by: Chap <erwin@lombok.demon.nl>
Co-authored-by: Adrer <adrermail@gmail.com>
Co-authored-by: Nathan Winters <100448493+CinnamonSnowball@users.noreply.github.com>
This commit is contained in:
Chap
2024-11-04 19:22:22 +01:00
committed by GitHub
parent 66ed8f5026
commit 08b92591ee
8 changed files with 46 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/mob/living/carbon/carbon_procs.dm
+16 -5
View File
@@ -534,10 +534,15 @@ GLOBAL_LIST_INIT(ventcrawl_machinery, list(/obj/machinery/atmospherics/unary/ven
/mob/living/proc/add_ventcrawl(obj/machinery/atmospherics/starting_machine, obj/machinery/atmospherics/target_move)
if(!istype(starting_machine) || !starting_machine.returnPipenet(target_move) || !starting_machine.can_see_pipes())
return
var/datum/pipeline/pipeline = starting_machine.returnPipenet(target_move)
var/datum/pipeline/pipenet = starting_machine.returnPipenet(target_move)
pipenet.add_ventcrawler(src)
add_ventcrawl_images(pipenet)
/mob/living/proc/add_ventcrawl_images(datum/pipeline/pipenet)
var/list/totalMembers = list()
totalMembers |= pipeline.members
totalMembers |= pipeline.other_atmosmch
totalMembers |= pipenet.members
totalMembers |= pipenet.other_atmosmch
for(var/obj/machinery/atmospherics/A in totalMembers)
if(!A.pipe_image)
A.update_pipe_image()
@@ -546,6 +551,10 @@ GLOBAL_LIST_INIT(ventcrawl_machinery, list(/obj/machinery/atmospherics/unary/ven
client.images += A.pipe_image
/mob/living/proc/remove_ventcrawl()
SEND_SIGNAL(src, COMSIG_LIVING_EXIT_VENTCRAWL)
remove_ventcrawl_images()
/mob/living/proc/remove_ventcrawl_images()
if(client)
for(var/image/current_image in pipes_shown)
client.images -= current_image
@@ -567,8 +576,10 @@ GLOBAL_LIST_INIT(ventcrawl_machinery, list(/obj/machinery/atmospherics/unary/ven
else
if(is_ventcrawling(src))
if(target_move)
remove_ventcrawl()
add_ventcrawl(loc, target_move)
remove_ventcrawl_images()
var/obj/machinery/atmospherics/current_pipe = loc
var/datum/pipeline/pipenet = current_pipe.returnPipenet(target_move)
add_ventcrawl_images(pipenet)
//Throwing stuff