From 091b648cd09166e30f16614d54e677c304d14ab5 Mon Sep 17 00:00:00 2001
From: warriorstar-orion <orion@snowfrost.garden>
Date: Sat, 10 May 2025 13:37:16 -0400
Subject: [PATCH] use ~ instead of shellenv HOME for CI cache paths (#29282)

* use ~ instead of shellenv HOME for CI cache paths

* i am going to be insanely pissed if this works

* at least filter cache into stable and beta
---
 .github/workflows/ci.yml  | 18 +++++++++++-------
 tools/ci/install_byond.sh |  2 +-
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index bc31358247d..4bac0ab57c1 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Setup Cache
         uses: actions/cache@v4
         with:
-          path: $HOME/SpacemanDMM
+          path: ~/SpacemanDMM
           key: ${{ runner.os }}-spacemandmm
 
       - name: Install Tools
@@ -79,13 +79,17 @@ jobs:
   compile_all_maps:
     name: Compile All Maps
     runs-on: ubuntu-22.04
+    strategy:
+      fail-fast: false
+      matrix:
+        byondtype: ['STABLE', 'BETA']
     steps:
       - uses: actions/checkout@v4
       - name: Setup Cache
         uses: actions/cache@v4
         with:
-          path: $HOME/BYOND
-          key: ${{ runner.os }}-byond
+          path: ~/BYOND
+          key: ${{ runner.os }}-byond-${{ matrix.byondtype }}
       # We test PARADISE_PRODUCTION_HARDWARE here because we dont in station_mapload_tests
       - name: Compile All Maps
         run: |
@@ -107,8 +111,8 @@ jobs:
       - name: Setup Cache
         uses: actions/cache@v4
         with:
-          path: $HOME/BYOND
-          key: ${{ runner.os }}-byond
+          path: ~/BYOND
+          key: ${{ runner.os }}-byond-${{ matrix.byondtype }}
       - name: Install RUST_G Deps
         run: |
           sudo dpkg --add-architecture i386
@@ -135,8 +139,8 @@ jobs:
       - name: Setup Cache
         uses: actions/cache@v4
         with:
-          path: $HOME/BYOND
-          key: ${{ runner.os }}-byond
+          path: ~/BYOND
+          key: ${{ runner.os }}-byond-${{ matrix.byondtype }}
       - name: Setup & Validate DB
         run: |
           sudo systemctl start mysql
diff --git a/tools/ci/install_byond.sh b/tools/ci/install_byond.sh
index 2a1125112b1..98e5de8a2c1 100755
--- a/tools/ci/install_byond.sh
+++ b/tools/ci/install_byond.sh
@@ -23,7 +23,7 @@ else
   rm -rf "$HOME/BYOND"
   mkdir -p "$HOME/BYOND"
   cd "$HOME/BYOND"
-  curl "http://www.byond.com/download/build/${TARGET_MAJOR}/${TARGET_MAJOR}.${TARGET_MINOR}_byond_linux.zip" -o byond.zip
+  curl "http://www.byond.com/download/build/${TARGET_MAJOR}/${TARGET_MAJOR}.${TARGET_MINOR}_byond_linux.zip" -H "User-Agent: ParadiseSS13/Paradise CI" -o byond.zip
   unzip byond.zip
   rm byond.zip
   cd byond