A lot of perf micro-optimisations (#20188)

* Refactors Investigate Log

* Speedup character loading

* Optimise SSinstancing

* Removes both path images

* Optimises SSdebugview

* CRLF --> LF

* Update config/example/config.toml

code/modules/admin/admin_investigate.dm

@@ -1,61 +1,31 @@
-//By Carnwennan
-
-//This system was made as an alternative to all the in-game lists and variables used to log stuff in-game.
-//lists and variables are great. However, they have several major flaws:
-//Firstly, they use memory. TGstation has one of the highest memory usage of all the ss13 branches.
-//Secondly, they are usually stored in an object. This means that they aren't centralised. It also means that
-//the data is lost when the object is deleted! This is especially annoying for things like the singulo engine!
-#define INVESTIGATE_DIR "data/investigate/"
-
-//SYSTEM
-/proc/investigate_subject2file(subject)
-	return wrap_file("[INVESTIGATE_DIR][subject].html")
-
-/proc/investigate_reset()
-	if(fdel(INVESTIGATE_DIR))	return 1
-	return 0
+// Atom investigate stuff
+// All of this is stored in a global list because its faster than file IO and we arent ram constrained like TG -aa07
+GLOBAL_LIST_EMPTY(investigate_log_wrapper)
+GLOBAL_PROTECT(investigate_log_wrapper)
 
 /atom/proc/investigate_log(message, subject)
-	if(!message)	return
-	var/F = investigate_subject2file(subject)
-	if(!F)	return
-	GLOB.investigate_log_subjects |= subject
-	F << "<small>[time_stamp()] \ref[src] [ADMIN_COORDJMP(src)] </small> || [src] [message]<br>"
+	if(!message || !subject)
+		return
 
-/proc/log_investigate(message, subject)
-	if(!message) return
-	var/F = investigate_subject2file(subject)
-	if(!F) return
-	GLOB.investigate_log_subjects |= subject
-	F << "<small>[time_stamp()] || [message]<br>"
+	if(!(subject in GLOB.investigate_log_wrapper))
+		GLOB.investigate_log_wrapper[subject] = list()
+
+	GLOB.investigate_log_wrapper[subject] += "<small>[time_stamp()] [UID()] [ADMIN_COORDJMP(src)] </small> || [src] [message]"
 
 //ADMINVERBS
-/client/proc/investigate_show( subject in GLOB.investigate_log_subjects )
-	set name = "Investigate"
+/client/proc/investigate_show(subject in GLOB.investigate_log_wrapper)
+	set name = "Investigate Round Objects"
 	set category = "Admin"
+
 	if(!check_rights(R_ADMIN))
 		return
-	switch(subject)
-		if("notes")
-			show_note()
 
-		if("watchlist")
-			watchlist_show()
+	// Should never happen
+	if(!(subject in GLOB.investigate_log_wrapper))
+		return
 
-		if("hrefs")				//persistant logs and stuff
-			if(GLOB.configuration.logging.href_logging)
-				if(GLOB.world_href_log)
-					src << browse(file(GLOB.world_href_log), "window=investigate[subject];size=800x300")
-				else
-					to_chat(src, "<font color='red'>Error: admin_investigate: No href logfile found.</font>")
-					return
-			else
-				to_chat(src, "<font color='red'>Error: admin_investigate: Href Logging is not on.</font>")
-				return
+	var/list/entries = GLOB.investigate_log_wrapper[subject]
 
-		else //general one-round-only stuff
-			var/F = investigate_subject2file(subject)
-			if(!F)
-				to_chat(src, "<font color='red'>Error: admin_investigate: [INVESTIGATE_DIR][subject] is an invalid path or cannot be accessed.</font>")
-				return
-			src << browse(F,"window=investigate[subject];size=800x300")
+	var/datum/browser/B = new(usr, "investigatelog", "Investigate ([subject])", 800, 400)
+	B.set_content(entries.Join("<br>"))
+	B.open()

code/modules/admin/admin_verbs.dm

@@ -69,7 +69,8 @@ GLOBAL_LIST_INIT(admin_verbs_admin, list(
 	/client/proc/ccbdb_lookup_ckey,
 	/client/proc/view_instances,
 	/client/proc/start_vote,
-	/client/proc/ping_all_admins
+	/client/proc/ping_all_admins,
+	/client/proc/show_watchlist
 ))
 GLOBAL_LIST_INIT(admin_verbs_ban, list(
 	/client/proc/ban_panel,
@@ -996,3 +997,12 @@ GLOBAL_LIST_INIT(admin_verbs_maintainer, list(
 
 	log_admin("[key_name(usr)] has [advanced_admin_interaction ? "activated" : "deactivated"] their advanced admin interaction.")
 	message_admins("[key_name_admin(usr)] has [advanced_admin_interaction ? "activated" : "deactivated"] their advanced admin interaction.")
+
+/client/proc/show_watchlist()
+	set name = "Show Watchlist"
+	set category = "Admin"
+
+	if(!check_rights(R_ADMIN))
+		return
+
+	watchlist_show()

code/modules/atmospherics/machinery/components/binary_devices/pump.dm

@@ -35,17 +35,21 @@ Thus, the two variables affect pump operation are set in New():
 /obj/machinery/atmospherics/binary/pump/CtrlClick(mob/living/user)
 	if(can_use_shortcut(user))
 		toggle(user)
+		investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 	return ..()
 
 /obj/machinery/atmospherics/binary/pump/AICtrlClick(mob/living/silicon/user)
 	toggle(user)
+	investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/pump/AltClick(mob/living/user)
 	if(can_use_shortcut(user))
 		set_max(user)
+		investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/pump/AIAltClick(mob/living/silicon/user)
 	set_max(user)
+	investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/pump/on
 	icon_state = "map_on"

code/modules/atmospherics/machinery/components/binary_devices/volume_pump.dm

@@ -32,17 +32,21 @@ Thus, the two variables affect pump operation are set in New():
 /obj/machinery/atmospherics/binary/volume_pump/CtrlClick(mob/living/user)
 	if(can_use_shortcut(user))
 		toggle(user)
+		investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 	return ..()
 
 /obj/machinery/atmospherics/binary/volume_pump/AICtrlClick(mob/living/silicon/user)
 	toggle(user)
+	investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/volume_pump/AltClick(mob/living/user)
 	if(can_use_shortcut(user))
 		set_max(user)
+		investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/volume_pump/AIAltClick(mob/living/silicon/user)
 	set_max(user)
+	investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/volume_pump/on
 	on = TRUE

code/modules/atmospherics/machinery/components/trinary_devices/filter.dm

@@ -38,17 +38,21 @@
 /obj/machinery/atmospherics/trinary/filter/CtrlClick(mob/living/user)
 	if(can_use_shortcut(user))
 		toggle(user)
+		investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 	return ..()
 
 /obj/machinery/atmospherics/trinary/filter/AICtrlClick(mob/living/silicon/user)
 	toggle(user)
+	investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/filter/AltClick(mob/living/user)
 	if(can_use_shortcut(user))
 		set_max(user)
+		investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/filter/AIAltClick(mob/living/silicon/user)
 	set_max(user)
+	investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/filter/flipped
 	icon_state = "mmap"

code/modules/atmospherics/machinery/components/trinary_devices/mixer.dm

@@ -19,17 +19,21 @@
 /obj/machinery/atmospherics/trinary/mixer/CtrlClick(mob/living/user)
 	if(can_use_shortcut(user))
 		toggle(user)
+		investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 	return ..()
 
 /obj/machinery/atmospherics/trinary/mixer/AICtrlClick(mob/living/silicon/user)
 	toggle(user)
+	investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/mixer/AltClick(mob/living/user)
 	if(can_use_shortcut(user))
 		set_max(user)
+		investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/mixer/AIAltClick(mob/living/silicon/user)
 	set_max(user)
+	investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/mixer/flipped
 	icon_state = "mmap"

code/modules/client/preference/character.dm

@@ -103,7 +103,6 @@
 
 // Fuckery to prevent null characters
 /datum/character_save/New()
-	randomise()
 	real_name = random_name(gender, species)
 
 /datum/character_save/proc/save(client/C)

code/modules/mob/living/simple_animal/bot/bot.dm

@@ -47,7 +47,7 @@
 	var/frustration = 0 //Used by some bots for tracking failures to reach their target.
 	var/base_speed = 2 //The speed at which the bot moves, or the number of times it moves per process() tick.
 	var/turf/ai_waypoint //The end point of a bot's path, or the target location.
-	var/list/path = list() //List of turfs through which a bot 'steps' to reach the waypoint, associated with the path image, if there is one.
+	var/list/path = list() //List of turfs through which a bot 'steps' to reach the waypoint
 	var/pathset = FALSE
 	var/list/ignore_list = list() //List of unreachable targets for an ignore-list enabled bot to ignore.
 	var/mode = BOT_IDLE //Standardizes the vars that indicate the bot is busy with its function.
@@ -86,16 +86,12 @@
 	"Responding", "Navigating to Delivery Location", "Navigating to Home", \
 	"Waiting for clear path", "Calculating navigation path", "Pinging beacon network", "Unable to reach destination")
 
-	var/datum/atom_hud/data/bot_path/path_hud = new /datum/atom_hud/data/bot_path()
-	var/path_image_icon = 'icons/obj/aibots.dmi'
-	var/path_image_icon_state = "path_indicator"
-	var/path_image_color = "#FFFFFF"
 	var/reset_access_timer_id
 
 	/// List of access values you can have to access the bot. Consider this as req_one_access
 	var/list/req_access = list()
 
-	hud_possible = list(DIAG_STAT_HUD, DIAG_BOT_HUD, DIAG_HUD, DIAG_PATH_HUD = HUD_LIST_LIST)//Diagnostic HUD views
+	hud_possible = list(DIAG_STAT_HUD, DIAG_BOT_HUD, DIAG_HUD)//Diagnostic HUD views
 
 /obj/item/radio/headset/bot
 	requires_tcomms = FALSE
@@ -170,9 +166,6 @@
 	diag_hud_set_botstat()
 	diag_hud_set_botmode()
 
-	if(path_hud)
-		path_hud.add_to_hud(src)
-
 
 /mob/living/simple_animal/bot/med_hud_set_health()
 	return //we use a different hud
@@ -185,9 +178,6 @@
 	if(paicard)
 		ejectpai()
 	set_path(null)
-	if(path_hud)
-		QDEL_NULL(path_hud)
-		path_hud = null
 
 	var/datum/atom_hud/data_hud = GLOB.huds[data_hud_type]
 	if(data_hud)
@@ -1028,75 +1018,11 @@ Pass a positive integer as an argument to override a bot's default speed.
 
 /mob/living/simple_animal/bot/proc/set_path(list/newpath)
 	path = newpath ? newpath : list()
-	if(!path_hud)
-		return
-	var/list/path_huds_watching_me = list(GLOB.huds[DATA_HUD_DIAGNOSTIC_ADVANCED])
-	if(path_hud)
-		path_huds_watching_me += path_hud
-	for(var/V in path_huds_watching_me)
-		var/datum/atom_hud/H = V
-		H.remove_from_hud(src)
-	clear_path_image()
-
-	var/list/path_images = hud_list[DIAG_PATH_HUD]
-	QDEL_LIST_CONTENTS(path_images)
-	if(newpath)
-		for(var/i in 1 to newpath.len)
-			var/turf/T = newpath[i]
-			if(T == loc) //don't bother putting an image if it's where we already exist.
-				continue
-			var/direction = NORTH
-			if(i > 1)
-				var/turf/prevT = path[i - 1]
-				var/image/prevI = path[prevT]
-				direction = get_dir(prevT, T)
-				if(i > 2)
-					var/turf/prevprevT = path[i - 2]
-					var/prevDir = get_dir(prevprevT, prevT)
-					var/mixDir = direction|prevDir
-					if(mixDir in GLOB.diagonals)
-						prevI.dir = mixDir
-						if(prevDir & (NORTH|SOUTH))
-							var/matrix/ntransform = matrix()
-							ntransform.Turn(90)
-							if((mixDir == NORTHWEST) || (mixDir == SOUTHEAST))
-								ntransform.Scale(-1, 1)
-							else
-								ntransform.Scale(1, -1)
-							prevI.transform = ntransform
-			var/mutable_appearance/MA = new /mutable_appearance()
-			MA.icon = path_image_icon
-			MA.icon_state = path_image_icon_state
-			MA.layer = ABOVE_OPEN_TURF_LAYER
-			MA.plane = FLOOR_PLANE
-			MA.appearance_flags = RESET_COLOR|RESET_TRANSFORM
-			MA.color = path_image_color
-			MA.dir = direction
-			var/image/I = image(loc = T)
-			I.appearance = MA
-			path[T] = I
-			path_images += I
-
-	for(var/V in path_huds_watching_me)
-		var/datum/atom_hud/H = V
-		H.add_to_hud(src)
-
 
 /mob/living/simple_animal/bot/proc/increment_path()
 	if(!path || !length(path))
 		return
-	var/image/I = path[path[1]]
-	if(I)
-		I.icon_state = null
 	path.Cut(1, 2)
 
-/mob/living/simple_animal/bot/proc/clear_path_image()
-	if(!path || !length(path))
-		return
-	for(var/P in path)
-		var/image/I = path[P]
-		if(I?.icon_state)
-			I.icon_state = null
-
 /mob/living/simple_animal/bot/proc/drop_part(obj/item/drop_item, dropzone)
 	new drop_item(dropzone)

code/modules/mob/living/simple_animal/bot/cleanbot.dm

@@ -17,7 +17,6 @@
 	window_id = "autoclean"
 	window_name = "Automatic Station Cleaner v1.1"
 	pass_flags = PASSMOB
-	path_image_color = "#993299"
 
 
 	var/blood = TRUE

code/modules/mob/living/simple_animal/bot/ed209bot.dm

@@ -22,7 +22,6 @@
 	req_access = list(ACCESS_SECURITY)
 	window_id = "autoed209"
 	window_name = "Automatic Security Unit v2.6"
-	path_image_color = "#FF0000"
 	data_hud_type = DATA_HUD_SECURITY_ADVANCED
 
 	allow_pai = FALSE

code/modules/mob/living/simple_animal/bot/floorbot.dm

@@ -17,7 +17,6 @@
 	req_access = list(ACCESS_CONSTRUCTION, ACCESS_ROBOTICS)
 	window_id = "autofloor"
 	window_name = "Automatic Station Floor Repairer v1.1"
-	path_image_color = "#FFA500"
 
 	var/process_type //Determines what to do when process_scan() recieves a target. See process_scan() for details.
 	var/targetdirection

code/modules/mob/living/simple_animal/bot/honkbot.dm

@@ -17,7 +17,6 @@
 	window_id = "autohonk"
 	window_name = "Honkomatic Bike Horn Unit v1.0.7"
 	data_hud_type = DATA_HUD_SECURITY_BASIC // show jobs
-	path_image_color = "#FF69B4"
 
 	var/honksound = 'sound/items/bikehorn.ogg' //customizable sound
 	var/spam_flag = FALSE

code/modules/mob/living/simple_animal/bot/medbot.dm

@@ -19,7 +19,6 @@
 	req_access = list(ACCESS_MEDICAL, ACCESS_ROBOTICS)
 	window_id = "automed"
 	window_name = "Automatic Medical Unit v1.1"
-	path_image_color = "#DDDDFF"
 	data_hud_type = DATA_HUD_MEDICAL_ADVANCED
 
 	var/obj/item/reagent_containers/glass/reagent_glass = null //Can be set to draw from this for reagents.

code/modules/mob/living/simple_animal/bot/mulebot.dm

@@ -26,7 +26,6 @@
 	model = "MULE"
 	bot_purpose = "deliver crates and other packages between departments, as requested"
 	req_access = list(ACCESS_CARGO)
-	path_image_color = "#7F5200"
 
 
 	suffix = ""

code/modules/mob/living/simple_animal/bot/secbot.dm

@@ -20,7 +20,6 @@
 	req_access = list(ACCESS_SECURITY)
 	window_id = "autosec"
 	window_name = "Automatic Security Unit v1.6"
-	path_image_color = "#FF0000"
 	data_hud_type = DATA_HUD_SECURITY_ADVANCED
 
 	var/base_icon = "secbot"