[Ready] Refactors stuns and status effects. (#17579)

* Fixes reviver runtime

* Confusion status effect

* Dizzy status effect

* Drowsiness status effect

* decaying -> transient

* Drunkenness status effect

* why use timer when SSfastprocessing work good

* stuns (mostly)

* weaken and immobalise

* stun/weaken times

* update_flags redundancies.

* Slowed()

* Silence + fixes transient decay

* Jittery

* sleeping

* Paralyze -> weaken

* Cult sluring

* paralyse

* Stammer

* slurring + projectile cleanups

* losebreath

* Hallucination

* forgor this

* eyeblurry

* eye blind

* Druggy

* affected didn't like my spacing

* review pass

* second review pass

* some cleanups

* documentation and signal framework

* confusion fix

* Fixes spec_stun

* rejuv fix

* removes a TODO

* conflicted myself

* fixes

* self review

* review

* removes TODOs

* adminfreeze

* TM fixes

* hallucination fix + others

* tones down alchol and runtime fixes

* confusion overlay suggestion

* more fixes

* runtime fix

* losebreath fix

* clamp => directional bounded sum

* steel review

* oops

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* reduces the dizziness cycle rate

* borg hotfix

* sanctified decursening

Co-authored-by: mochi <1496804+dearmochi@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

code/modules/hallucinations/effects/common.dm

@@ -8,9 +8,9 @@
 	/// Chance to trip when crossing.
 	var/trip_chance = 100
 	/// Stun to add when crossed.
-	var/stun = 4 SECONDS_TO_LIFE_CYCLES
+	var/stun = 4 SECONDS
 	/// Weaken to add when crossed.
-	var/weaken = 4 SECONDS_TO_LIFE_CYCLES
+	var/weaken = 4 SECONDS
 
 /obj/effect/hallucination/tripper/CanPass(atom/movable/mover, turf/T)
 	. = TRUE
@@ -18,7 +18,6 @@
 		var/mob/living/M = mover
 		if(M.lying || !prob(trip_chance))
 			return
-		M.Stun(stun)
 		M.Weaken(weaken)
 		on_crossed()
 

code/modules/hallucinations/effects/major.dm

@@ -73,7 +73,7 @@
 		return
 
 	step_towards(target, get_turf(src))
-	target.Weaken(4 SECONDS_TO_LIFE_CYCLES)
+	target.Weaken(4 SECONDS)
 	target.visible_message("<span class='warning'>[target] flails [target.p_their()] [I.name] as if striking something, only to trip!</span>",
 					  	   "<span class='userdanger'>[src] vanishes as you strike it with [I], causing you to stumble forward!</span>")
 	qdel(src)
@@ -381,7 +381,7 @@
 /obj/effect/hallucination/xeno_pouncer/throw_impact(A)
 	if(A == target)
 		forceMove(get_turf(target))
-		target.Weaken(5)
+		target.Weaken(10 SECONDS)
 		target.visible_message("<span class='danger'>[target] recoils backwards and falls flat!</span>",
 							   "<span class='userdanger'>[name] pounces on you!</span>")
 

code/modules/hallucinations/effects/moderate.dm

@@ -103,7 +103,7 @@
 			to_chat(user, "<span class='warning'>You try to move your [temp.name], but cannot!</span>")
 			return
 
-	user.Weaken(4 SECONDS_TO_LIFE_CYCLES)
+	user.Weaken(4 SECONDS)
 	user.visible_message("<span class='warning'>[user] does a grabbing motion towards [get_turf(src)] but [user.p_they()] stumble[user.p_s()] - nothing is there!</span>",
 						 "<span class='userdanger'>[src] vanishes as you try grabbing it, causing you to stumble!</span>")
 	qdel(src)
@@ -216,8 +216,8 @@
 	hallucination_icon_state = "smooth"
 	hallucination_override = TRUE
 	hallucination_layer = HIGH_TURF_LAYER
-	stun = 8 SECONDS_TO_LIFE_CYCLES
-	weaken = 8 SECONDS_TO_LIFE_CYCLES
+	stun = 8 SECONDS
+	weaken = 8 SECONDS
 
 /obj/effect/hallucination/tripper/chasm/on_crossed()
 	target.visible_message("<span class='warning'>[target] trips over nothing and flails on [get_turf(target)] as if they were falling!</span>",