Removes comparisons to true and false (#24083)

* Removes comparisons to true and false

* Update .github/CONTRIBUTING.md

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

---------

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
This commit is contained in:
GDN
2024-02-14 19:45:37 +00:00
committed by GitHub
co-authored by Luc
parent db17300320
commit 13a2630028
24 changed files with 55 additions and 33 deletions
+1 -1
View File
@@ -869,7 +869,7 @@ Traitors and the like can also be revived with the previous role mostly intact.
if(SSshuttle.emergency.mode >= SHUTTLE_DOCKED)
return
if(SSshuttle.emergency.canRecall == FALSE)
if(!SSshuttle.emergency.canRecall)
if(alert("Shuttle is currently set to be nonrecallable. Recalling may break things. Respect Recall Status?", "Override Recall Status?", "Yes", "No") == "Yes")
return
else
@@ -334,7 +334,7 @@
var/datum/gas_mixture/gas = location.remove_air(0.25 * environment.total_moles())
if(!gas)
return
if(!regulating_temperature && thermostat_state == TRUE)
if(!regulating_temperature && thermostat_state)
regulating_temperature = TRUE
visible_message("\The [src] clicks as it starts [environment.temperature > target_temperature ? "cooling" : "heating"] the room.", "You hear a click and a faint electronic hum.")
@@ -344,7 +344,7 @@
if(target_temperature < MIN_TEMPERATURE)
target_temperature = MIN_TEMPERATURE
if(thermostat_state == TRUE)
if(thermostat_state)
var/heat_capacity = gas.heat_capacity()
var/energy_used = max(abs(heat_capacity * (gas.temperature - target_temperature) ), MAX_ENERGY_CHANGE)
+1 -1
View File
@@ -474,7 +474,7 @@
return FALSE
/obj/machinery/computer/library/proc/select_book(obj/item/book/B)
if(B.carved == TRUE)
if(B.carved)
return
user_data.selected_book.title = B.title ? B.title : "No Title"
user_data.selected_book.author = B.author ? B.author : "No Author"
+1 -1
View File
@@ -78,7 +78,7 @@
if(!isturf(T))
return
if(new_opacity == TRUE)
if(new_opacity)
T.has_opaque_atom = TRUE
T.reconsider_lights()
else
@@ -41,7 +41,7 @@
/obj/item/survivalcapsule/attack_self()
// Can't grab when capsule is New() because templates aren't loaded then
get_template()
if(used == FALSE)
if(!used)
loc.visible_message("<span class='warning'>[src] begins to shake. Stand back!</span>")
used = TRUE
sleep(50)
+1 -1
View File
@@ -41,7 +41,7 @@ GLOBAL_LIST_INIT(boo_phrases, list(
if(target.get_spooked())
var/area/spook_zone = get_area(target)
if(spook_zone.is_haunted == TRUE)
if(spook_zone.is_haunted)
to_chat(usr, "<span class='notice'>The veil is weak in [spook_zone], it took less effort to influence [target].</span>")
cooldown_handler.start_recharge(cooldown_handler.recharge_duration / 2)
return
@@ -486,7 +486,7 @@
return
/datum/species/proc/help(mob/living/carbon/human/user, mob/living/carbon/human/target, datum/martial_art/attacker_style)
if(attacker_style && attacker_style.help_act(user, target) == TRUE)//adminfu only...
if(attacker_style && attacker_style.help_act(user, target))//adminfu only...
return TRUE
if(target.on_fire)
user.pat_out(target)
@@ -500,7 +500,7 @@
if(target.check_block())
target.visible_message("<span class='warning'>[target] blocks [user]'s grab attempt!</span>")
return FALSE
if(attacker_style && attacker_style.grab_act(user, target) == TRUE)
if(attacker_style && attacker_style.grab_act(user, target))
return TRUE
else
target.grabbedby(user)
@@ -532,7 +532,7 @@
return FALSE
if(SEND_SIGNAL(target, COMSIG_HUMAN_ATTACKED, user) & COMPONENT_CANCEL_ATTACK_CHAIN)
return FALSE
if(attacker_style && attacker_style.harm_act(user, target) == TRUE)
if(attacker_style && attacker_style.harm_act(user, target))
return TRUE
else
var/datum/unarmed_attack/attack = user.dna.species.unarmed
@@ -587,7 +587,7 @@
user.do_attack_animation(target, ATTACK_EFFECT_DISARM)
playsound(target.loc, 'sound/weapons/punchmiss.ogg', 25, 1, -1)
return FALSE
if(attacker_style && attacker_style.disarm_act(user, target) == TRUE)
if(attacker_style && attacker_style.disarm_act(user, target))
return TRUE
user.do_attack_animation(target, ATTACK_EFFECT_DISARM)
if(target.move_resist > user.pull_force)
@@ -134,7 +134,7 @@
if(!G.check_ahud_rejoin_eligibility())
to_chat(usr, "<span class='warning'>Upon using the antagHUD you forfeited the ability to join the round.</span>")
return
if(G.started_as_observer == TRUE)
if(G.started_as_observer)
joinedasobserver = TRUE
var/deathtimeminutes = round(deathtime / 600)
@@ -1212,7 +1212,7 @@
next_event_time = fake_time + world.time
/obj/machinery/atmospherics/supermatter_crystal/proc/try_events()
if(has_been_powered == FALSE)
if(!has_been_powered)
return
if(!next_event_time) // for when the SM starts
make_next_event_time()
+2 -2
View File
@@ -288,7 +288,7 @@ GLOBAL_LIST_EMPTY(gravity_generators)
change_power_mode(on ? ACTIVE_POWER_USE : IDLE_POWER_USE)
if(gravity) // If we turned on
if(generators_in_level() == FALSE) // And there's no gravity
if(generators_in_level() == 0) // And there's no other gravity generators on this z level
alert = TRUE
investigate_log("was brought online and is now producing gravity for this level.", "gravity")
message_admins("The gravity generator was brought online. (<A HREF='?_src_=holder;adminplayerobservecoodjump=1;X=[x];Y=[y];Z=[z]'>[src_area.name]</a>)")
@@ -297,7 +297,7 @@ GLOBAL_LIST_EMPTY(gravity_generators)
continue
A.gravitychange(TRUE, A)
else if(generators_in_level() == TRUE) // Turned off, and there is gravity
else if(generators_in_level() == 1) // Turned off, and there is only one gravity generator on the Z level
alert = TRUE
investigate_log("was brought offline and there is now no gravity for this level.", "gravity")
message_admins("The gravity generator was brought offline with no backup generator. (<A HREF='?_src_=holder;adminplayerobservecoodjump=1;X=[x];Y=[y];Z=[z]'>[src_area.name]</a>)")
@@ -1485,7 +1485,7 @@
M.reagents.remove_reagent(R.id, 0.5) //We will be generous (for nukies really) and purge out the chemicals during this phase, so they don't fucking die during the next phase. Of course, if they try to use adrenals in the next phase, well...
if(20 to 43)
//If they have stimulants or stimulant drugs then just apply toxin damage instead.
if(has_stimulant == TRUE)
if(has_stimulant)
update_flags |= M.adjustToxLoss(10, FALSE)
else //apply debilitating effects
if(prob(75))
@@ -1496,7 +1496,7 @@
to_chat(M, "<span class='warning'>Your body goes rigid, you cannot move at all!</span>")
M.AdjustWeakened(15 SECONDS)
if(45 to INFINITY) // Start fixing bones | If they have stimulants or stimulant drugs in their system then the nanites won't work.
if(has_stimulant == TRUE)
if(has_stimulant)
return ..()
else
for(var/obj/item/organ/external/E in M.bodyparts)
@@ -165,7 +165,7 @@
if(!is_open_container())
. += "lid_[initial(icon_state)]"
if(blocks_emissive == FALSE)
if(!blocks_emissive)
. += emissive_blocker(icon, "lid_[initial(icon_state)]")
if(assembly)
. += "assembly"
+2 -2
View File
@@ -1446,9 +1446,9 @@
/obj/structure/disposaloutlet/screwdriver_act(mob/living/user, obj/item/I)
add_fingerprint(user)
if(mode == FALSE)
if(!mode)
to_chat(user, "<span class='notice'>You remove the screws around the power connection.</span>")
else if(mode == TRUE)
else if(mode)
to_chat(user, "<span class='notice'>You attach the screws around the power connection.</span>")
I.play_tool_sound(src)
mode = !mode
@@ -189,7 +189,7 @@
..()
if(crit_fail)
return
if(owner.stat == UNCONSCIOUS && cooldown == FALSE)
if(owner.stat == UNCONSCIOUS && !cooldown)
owner.AdjustSleeping(-200 SECONDS)
owner.AdjustParalysis(-200 SECONDS)
to_chat(owner, "<span class='notice'>You feel a rush of energy course through your body!</span>")
+2 -2
View File
@@ -59,7 +59,7 @@
for(var/mob/dead/observer/G in GLOB.player_list)
if(G.mind == brainmob.mind)
foundghost = TRUE
if(G.can_reenter_corpse == FALSE)
if(!G.can_reenter_corpse)
foundghost = FALSE
break
if(foundghost)
@@ -129,7 +129,7 @@
owner.setBrainLoss(120)
/obj/item/organ/internal/brain/on_life()
if(decoy_brain || damage < 10)
if(decoy_brain || damage < 10)
return
switch(damage)
if(10 to 30)