massive burndown (#29894)

code/datums/status_effects/buffs.dm

@@ -2,7 +2,6 @@
 
 /datum/status_effect/his_grace
 	id = "his_grace"
-	duration = -1
 	tick_interval = 4
 	alert_type = /atom/movable/screen/alert/status_effect/his_grace
 	var/bloodlust = 0
@@ -240,7 +239,6 @@
 /datum/status_effect/vampire_gladiator
 	id = "vampire_gladiator"
 	duration = 30 SECONDS
-	tick_interval = 1 SECONDS
 	alert_type = /atom/movable/screen/alert/status_effect/vampire_gladiator
 
 /atom/movable/screen/alert/status_effect/vampire_gladiator
@@ -326,8 +324,6 @@
 //Hippocratic Oath: Applied when the Rod of Asclepius is activated.
 /datum/status_effect/hippocratic_oath
 	id = "Hippocratic Oath"
-	status_type = STATUS_EFFECT_UNIQUE
-	duration = -1
 	tick_interval = 25
 	examine_text = "<span class='notice'>They seem to have an aura of healing and helpfulness about them.</span>"
 	alert_type = null
@@ -497,9 +493,7 @@
 
 /datum/status_effect/fleshmend
 	id = "fleshmend"
-	duration = -1
 	status_type = STATUS_EFFECT_REFRESH
-	tick_interval = 1 SECONDS
 	alert_type = null
 	/// This diminishes the healing of fleshmend the higher it is.
 	var/tolerance = 1
@@ -546,8 +540,6 @@
 
 /datum/status_effect/speedlegs
 	id = "speedlegs"
-	duration = -1
-	status_type = STATUS_EFFECT_UNIQUE
 	tick_interval = 4 SECONDS
 	alert_type = null
 	var/stacks = 0
@@ -640,8 +632,6 @@
 
 /datum/status_effect/breaching_and_cleaving
 	id = "breaching_and_cleaving"
-	duration = -1
-	status_type = STATUS_EFFECT_UNIQUE
 	alert_type = /atom/movable/screen/alert/status_effect/breaching_and_cleaving
 	var/datum/armor/cleaving_armor_boost = new /datum/armor(0, 30, 30, 30, 0, 0, 50, 0, 0)
 
@@ -667,9 +657,7 @@
 
 /datum/status_effect/hope
 	id = "hope"
-	duration = -1
 	tick_interval = 2 SECONDS
-	status_type = STATUS_EFFECT_UNIQUE
 	alert_type = /atom/movable/screen/alert/status_effect/hope
 
 /atom/movable/screen/alert/status_effect/hope
@@ -723,8 +711,6 @@
 
 /datum/status_effect/drill_payback
 	id = "drill_payback"
-	duration = -1
-	status_type = STATUS_EFFECT_UNIQUE
 	alert_type = null
 	var/drilled_successfully = FALSE
 	var/times_warned = 0
@@ -763,7 +749,6 @@
 /datum/status_effect/thrall_net
 	id = "thrall_net"
 	tick_interval = 2 SECONDS
-	duration = -1
 	alert_type = null
 	var/blood_cost_per_tick = 5
 	var/list/target_UIDs = list()
@@ -945,7 +930,6 @@
 /datum/status_effect/flayer_rejuv
 	id = "rejuvination"
 	duration = 5 SECONDS
-	tick_interval = 1 SECONDS
 	alert_type = /atom/movable/screen/alert/status_effect/flayer_rejuv
 	var/heal_amount = 5 // 25 total healing of both brute and burn at base
 
@@ -1034,7 +1018,6 @@
 /datum/status_effect/terminator_form
 	id = "terminator_form"
 	duration = 1 MINUTES
-	tick_interval = 1 SECONDS
 	status_type = STATUS_EFFECT_REFRESH
 	alert_type = /atom/movable/screen/alert/status_effect/terminator_form
 	var/mutable_appearance/eye
@@ -1060,9 +1043,6 @@
 #define COMBUSTION_TEMPERATURE 500
 /datum/status_effect/overclock
 	id = "overclock"
-	duration = -1
-	tick_interval = 1 SECONDS
-	status_type = STATUS_EFFECT_UNIQUE
 	alert_type = /atom/movable/screen/alert/status_effect/overclock
 	/// How much do we heat up per tick?
 	var/heat_per_tick = 5

code/datums/status_effects/debuffs.dm

@@ -3,7 +3,6 @@
 /// does minor damage over time unless holding His Grace
 /datum/status_effect/his_wrath
 	id = "his_wrath"
-	duration = -1
 	tick_interval = 4
 	alert_type = /atom/movable/screen/alert/status_effect/his_wrath
 
@@ -27,7 +26,6 @@
 /// is a cult ghost and can't use manifest runes, can see ghosts and dies if too far from summoner
 /datum/status_effect/cultghost
 	id = "cult_ghost"
-	duration = -1
 	alert_type = null
 	var/damage = 7.5
 	var/source_UID
@@ -80,7 +78,6 @@
 
 /datum/status_effect/saw_bleed
 	id = "saw_bleed"
-	duration = -1 //removed under specific conditions
 	tick_interval = 6
 	alert_type = null
 	var/mutable_appearance/bleed_overlay
@@ -1004,7 +1001,6 @@
 /datum/status_effect/cryo_beam
 	id = "cryo beam"
 	alert_type = null
-	duration = -1 //Kill it, get out of sight, or be killed. Jump boots are *required*
 	tick_interval = 0.5 SECONDS
 	var/damage = 0.75
 	var/source_UID
@@ -1030,8 +1026,6 @@
 /datum/status_effect/bubblegum_curse
 	id = "bubblegum curse"
 	alert_type = /atom/movable/screen/alert/status_effect/bubblegum_curse
-	duration = -1 //Kill it. There is no other option.
-	tick_interval = 1 SECONDS
 	/// The damage the status effect does per tick.
 	var/damage = 0.75
 	var/source_UID
@@ -1474,7 +1468,6 @@
 
 /datum/status_effect/temporal_slash_finisher
 	id = "temporal_slash_finisher"
-	status_type = STATUS_EFFECT_UNIQUE
 	alert_type = null
 	tick_interval = 0.25 SECONDS
 	/// How many times the user has been cut. Each cut adds a damage value below

code/datums/status_effects/gas.dm

@@ -1,7 +1,6 @@
 /datum/status_effect/freon
 	id = "frozen"
 	duration = 100
-	status_type = STATUS_EFFECT_UNIQUE
 	alert_type = /atom/movable/screen/alert/status_effect/freon
 	var/icon/cube
 	var/can_melt = TRUE

code/datums/status_effects/magic_disguise.dm

@@ -1,6 +1,5 @@
 /datum/status_effect/magic_disguise
 	id = "magic_disguise"
-	duration = -1
 	tick_interval = -1
 	alert_type = /atom/movable/screen/alert/status_effect/magic_disguise
 	status_type = STATUS_EFFECT_REPLACE

code/datums/status_effects/neutral.dm

@@ -3,8 +3,6 @@
 /// tracks the damage dealt to this mob by kinetic crushers
 /datum/status_effect/crusher_damage
 	id = "crusher_damage"
-	duration = -1
-	status_type = STATUS_EFFECT_UNIQUE
 	alert_type = null
 	var/total_damage = 0
 
@@ -294,7 +292,6 @@
 /datum/status_effect/limited_bonus/revivable
 	id = "revivable"
 	alert_type = null
-	status_type = STATUS_EFFECT_UNIQUE
 	duration = BASE_DEFIB_TIME_LIMIT
 
 /datum/status_effect/limited_bonus/revivable/on_apply()
@@ -340,7 +337,6 @@
 /datum/status_effect/lwap_scope
 	id = "lwap_scope"
 	alert_type = null
-	duration = -1
 	tick_interval = 4
 	/// The number of people the gun has locked on to. Caps at 10 for sanity.
 	var/locks = 0

code/datums/status_effects/status_effect.dm

@@ -182,11 +182,9 @@
 
 /datum/status_effect/stacking
 	id = "stacking_base"
-	duration = -1 //removed under specific conditions
 	alert_type = null
 	var/stacks = 0 //how many stacks are accumulated, also is # of stacks that target will have when first applied
 	var/delay_before_decay //deciseconds until ticks start occuring, which removes stacks (first stack will be removed at this time plus tick_interval)
-	tick_interval = 10 //deciseconds between decays once decay starts
 	var/stack_decay = 1 //how many stacks are lost per tick (decay trigger)
 	var/stack_threshold //special effects trigger when stacks reach this amount
 	var/max_stacks //stacks cannot exceed this amount