From 19644cdd88feb6c9f12c6afcacbc258f8f61a53d Mon Sep 17 00:00:00 2001 From: Kyep <16434066+Kyep@users.noreply.github.com> Date: Mon, 28 Dec 2020 18:29:38 +0000 Subject: [PATCH] Make "undeleted query" & byond acc creation logs for admins respect "see debug logs" setting (#15189) * Only send undeleted query notices to admins with debug logs on * does the same thing to byond account creation stuff Co-authored-by: Kyep --- code/controllers/subsystem/dbcore.dm | 2 +- code/modules/client/client_procs.dm | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/code/controllers/subsystem/dbcore.dm b/code/controllers/subsystem/dbcore.dm index 9812dcf6a80..262abcda4db 100644 --- a/code/controllers/subsystem/dbcore.dm +++ b/code/controllers/subsystem/dbcore.dm @@ -38,7 +38,7 @@ SUBSYSTEM_DEF(dbcore) for(var/I in active_queries) var/datum/db_query/Q = I if(world.time - Q.last_activity_time > 5 MINUTES) - message_admins("Found undeleted query, please check the server logs and notify coders.") + log_debug("Found undeleted query, please check the server logs and notify coders.") log_sql("Undeleted query: \"[Q.sql]\" LA: [Q.last_activity] LAT: [Q.last_activity_time]") qdel(Q) if(MC_TICK_CHECK) diff --git a/code/modules/client/client_procs.dm b/code/modules/client/client_procs.dm index 7053d3b2f40..e7fe0710a05 100644 --- a/code/modules/client/client_procs.dm +++ b/code/modules/client/client_procs.dm @@ -1026,13 +1026,13 @@ // Main return is here return parsed_data catch - message_admins("Error parsing byond.com data for [ckey]. Please inform maintainers.") + log_debug("Error parsing byond.com data for [ckey]. Please inform maintainers.") return null else - message_admins("Error retrieving data from byond.com for [ckey]. Invalid status code (Expected: 200 | Got: [status]).") + log_debug("Error retrieving data from byond.com for [ckey]. Invalid status code (Expected: 200 | Got: [status]).") return null else - message_admins("Failed to retrieve data from byond.com for [ckey]. Connection failed.") + log_debug("Failed to retrieve data from byond.com for [ckey]. Connection failed.") return null @@ -1067,7 +1067,7 @@ // They dont have a date, lets grab one var/list/byond_data = retrieve_byondacc_data() if(isnull(byond_data) || !(byond_data["general"]["joined"])) - message_admins("Failed to retrieve an account creation date for [ckey].") + log_debug("Failed to retrieve an account creation date for [ckey].") return byondacc_date = byond_data["general"]["joined"]