Makes all global variables handled by the GLOB controller (#13152)

* Handlers converted, now to fix 3532 compile errors

* 3532 compile fixes later, got runtimes on startup

* Well the server loads now atleast

* Take 2

* Oops

code/modules/pda/PDA.dm

@@ -1,7 +1,7 @@
 
 //The advanced pea-green monochrome lcd of tomorrow.
 
-var/global/list/obj/item/pda/PDAs = list()
+GLOBAL_LIST_EMPTY(PDAs)
 
 
 /obj/item/pda
@@ -66,8 +66,8 @@ var/global/list/obj/item/pda/PDAs = list()
  */
 /obj/item/pda/Initialize(mapload)
 	. = ..()
-	PDAs += src
-	PDAs = sortAtom(PDAs)
+	GLOB.PDAs += src
+	GLOB.PDAs = sortAtom(GLOB.PDAs)
 	update_programs()
 	if(default_cartridge)
 		cartridge = new default_cartridge(src)
@@ -101,7 +101,7 @@ var/global/list/obj/item/pda/PDAs = list()
 	if((!istype(over_object, /obj/screen)) && can_use())
 		return attack_self(M)
 
-/obj/item/pda/ui_interact(mob/user, ui_key = "main", var/datum/nanoui/ui = null, var/force_open = 1, var/datum/topic_state/state = inventory_state)
+/obj/item/pda/ui_interact(mob/user, ui_key = "main", var/datum/nanoui/ui = null, var/force_open = 1, var/datum/topic_state/state = GLOB.inventory_state)
 	ui_tick++
 	var/datum/nanoui/old_ui = SSnanoui.get_open_ui(user, src, "main")
 	var/auto_update = 1
@@ -131,7 +131,7 @@ var/global/list/obj/item/pda/PDAs = list()
 	// auto update every Master Controller tick
 	ui.set_auto_update(auto_update)
 
-/obj/item/pda/ui_data(mob/user, ui_key = "main", datum/topic_state/state = inventory_state)
+/obj/item/pda/ui_data(mob/user, ui_key = "main", datum/topic_state/state = GLOB.inventory_state)
 	var/data[0]
 
 	data["owner"] = owner					// Who is your daddy...
@@ -467,7 +467,7 @@ var/global/list/obj/item/pda/PDAs = list()
 	return
 
 /obj/item/pda/Destroy()
-	PDAs -= src
+	GLOB.PDAs -= src
 	var/T = get_turf(loc)
 	if(id)
 		id.forceMove(T)

code/modules/pda/cart_apps.dm

@@ -103,12 +103,12 @@
 			"poweravail" = powmonitor.powernet.avail,
 			"powerload" = num2text(powmonitor.powernet.viewload, 10),
 			"powerdemand" = powmonitor.powernet.load,
-			"apcs" = apc_repository.apc_data(powmonitor.powernet))
+			"apcs" = GLOB.apc_repository.apc_data(powmonitor.powernet))
 		has_back = 1
 	else
 		data["records"] = list(
 			"powerconnected" = 0,
-			"powermonitors" = powermonitor_repository.powermonitor_data())
+			"powermonitors" = GLOB.powermonitor_repository.powermonitor_data())
 		has_back = 0
 
 /datum/data/pda/app/power/Topic(href, list/href_list)
@@ -127,12 +127,12 @@
 /datum/data/pda/app/crew_records/update_ui(mob/user as mob, list/data)
 	var/list/records[0]
 
-	if(general_records && (general_records in data_core.general))
+	if(general_records && (general_records in GLOB.data_core.general))
 		data["records"] = records
 		records["general"] = general_records.fields
 		return records
 	else
-		for(var/A in sortRecord(data_core.general))
+		for(var/A in sortRecord(GLOB.data_core.general))
 			var/datum/data/record/R = A
 			if(R)
 				records += list(list(Name = R.fields["name"], "ref" = "\ref[R]"))
@@ -143,7 +143,7 @@
 	switch(href_list["choice"])
 		if("Records")
 			var/datum/data/record/R = locate(href_list["target"])
-			if(R && (R in data_core.general))
+			if(R && (R in GLOB.data_core.general))
 				load_records(R)
 		if("Back")
 			general_records = null
@@ -166,14 +166,14 @@
 	if(!records)
 		return
 
-	if(medical_records && (medical_records in data_core.medical))
+	if(medical_records && (medical_records in GLOB.data_core.medical))
 		records["medical"] = medical_records.fields
 
 	return records
 
 /datum/data/pda/app/crew_records/medical/load_records(datum/data/record/R)
 	..(R)
-	for(var/A in data_core.medical)
+	for(var/A in GLOB.data_core.medical)
 		var/datum/data/record/E = A
 		if(E && (E.fields["name"] == R.fields["name"] || E.fields["id"] == R.fields["id"]))
 			medical_records = E
@@ -192,14 +192,14 @@
 	if(!records)
 		return
 
-	if(security_records && (security_records in data_core.security))
+	if(security_records && (security_records in GLOB.data_core.security))
 		records["security"] = security_records.fields
 
 	return records
 
 /datum/data/pda/app/crew_records/security/load_records(datum/data/record/R)
 	..(R)
-	for(var/A in data_core.security)
+	for(var/A in GLOB.data_core.security)
 		var/datum/data/record/E = A
 		if(E && (E.fields["name"] == R.fields["name"] || E.fields["id"] == R.fields["id"]))
 			security_records = E

code/modules/pda/core_apps.dm

@@ -71,8 +71,8 @@
 	update = PDA_APP_UPDATE_SLOW
 
 /datum/data/pda/app/manifest/update_ui(mob/user as mob, list/data)
-	data_core.get_manifest_json()
-	data["manifest"] = PDA_Manifest
+	GLOB.data_core.get_manifest_json()
+	data["manifest"] = GLOB.PDA_Manifest
 
 /datum/data/pda/app/manifest/Topic(href, list/href_list)
 

code/modules/pda/messenger.dm

@@ -39,7 +39,7 @@
 	else
 		var/convopdas[0]
 		var/pdas[0]
-		for(var/A in PDAs)
+		for(var/A in GLOB.PDAs)
 			var/obj/item/pda/P = A
 			var/datum/data/pda/app/messenger/PM = P.find_program(/datum/data/pda/app/messenger)
 
@@ -143,8 +143,8 @@
 	// check if telecomms I/O route 1459 is stable
 	//var/telecomms_intact = telecomms_process(P.owner, owner, t)
 	var/obj/machinery/message_server/useMS = null
-	if(message_servers)
-		for(var/A in message_servers)
+	if(GLOB.message_servers)
+		for(var/A in GLOB.message_servers)
 			var/obj/machinery/message_server/MS = A
 		//PDAs are now dependent on the Message Server.
 			if(MS.active)
@@ -201,7 +201,7 @@
 		to_chat(usr, "Turn on your receiver in order to send messages.")
 		return
 
-	for(var/A in PDAs)
+	for(var/A in GLOB.PDAs)
 		var/obj/item/pda/P = A
 		var/datum/data/pda/app/messenger/PM = P.find_program(/datum/data/pda/app/messenger)
 

code/modules/pda/radio.dm

@@ -197,7 +197,7 @@
 
 	var/time = time2text(world.realtime,"hh:mm:ss")
 	var/turf/T = get_turf(src)
-	lastsignalers.Add("[time] <B>:</B> [usr.key] used [src] @ location ([T.x],[T.y],[T.z]) <B>:</B> [format_frequency(frequency)]/[code]")
+	GLOB.lastsignalers.Add("[time] <B>:</B> [usr.key] used [src] @ location ([T.x],[T.y],[T.z]) <B>:</B> [format_frequency(frequency)]/[code]")
 
 	var/datum/signal/signal = new
 	signal.source = src