From 973affbe44a59ac643f27e3c79cc183f6c89895b Mon Sep 17 00:00:00 2001 From: variableundefined <40092670+variableundefined@users.noreply.github.com> Date: Tue, 24 Jul 2018 20:43:44 +0800 Subject: [PATCH 1/2] Fixes runtime error from medical kit change --- code/game/objects/items/stacks/medical.dm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/code/game/objects/items/stacks/medical.dm b/code/game/objects/items/stacks/medical.dm index 38a21f86b2c..8429059d03d 100644 --- a/code/game/objects/items/stacks/medical.dm +++ b/code/game/objects/items/stacks/medical.dm @@ -89,11 +89,13 @@ var/nrembrute = rembrute var/nremburn = remburn affecting.heal_damage(heal_brute, heal_burn) - var/list/achildlist = affecting.children.Copy() + var/list/achildlist + if(!isnull(affecting.children)) + achildlist = affecting.children.Copy() var/parenthealed = FALSE while(rembrute + remburn > 0) // Don't bother if there's not enough leftover heal var/obj/item/organ/external/E - if(achildlist.len) + if(!isnull(achildlist) && achildlist.len) E = pick_n_take(achildlist) // Pick a random children and then remove it from the list else if(affecting.parent && !parenthealed) // If there's a parent and no healing attempt was made on it E = affecting.parent From c9d05c6bb17117d2ca4180855f1d4058bc1807d7 Mon Sep 17 00:00:00 2001 From: variableundefined <40092670+variableundefined@users.noreply.github.com> Date: Wed, 25 Jul 2018 07:21:48 +0800 Subject: [PATCH 2/2] Lazylen! --- code/game/objects/items/stacks/medical.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/game/objects/items/stacks/medical.dm b/code/game/objects/items/stacks/medical.dm index 8429059d03d..622b0b230c9 100644 --- a/code/game/objects/items/stacks/medical.dm +++ b/code/game/objects/items/stacks/medical.dm @@ -95,7 +95,7 @@ var/parenthealed = FALSE while(rembrute + remburn > 0) // Don't bother if there's not enough leftover heal var/obj/item/organ/external/E - if(!isnull(achildlist) && achildlist.len) + if(LAZYLEN(achildlist)) E = pick_n_take(achildlist) // Pick a random children and then remove it from the list else if(affecting.parent && !parenthealed) // If there's a parent and no healing attempt was made on it E = affecting.parent