From 267e3d2967d4e51e222a533332dae8d9c2e9a34e Mon Sep 17 00:00:00 2001
From: S34N <12197162+S34NW@users.noreply.github.com>
Date: Mon, 30 Aug 2021 13:20:12 +0100
Subject: [PATCH] Apply suggestions from code review
Co-authored-by: dearmochi <1496804+dearmochi@users.noreply.github.com>
---
code/game/objects/structures/window.dm | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/code/game/objects/structures/window.dm b/code/game/objects/structures/window.dm
index c9c594e3dcc..e8d38a64d3d 100644
--- a/code/game/objects/structures/window.dm
+++ b/code/game/objects/structures/window.dm
@@ -71,11 +71,11 @@
/obj/structure/window/proc/toggle_polarization()
if(opacity)
- animate(src, color="#FFFFFF", time=5)
- set_opacity(0)
+ animate(src, color = "#FFFFFF", time = 0.5 SECONDS)
+ set_opacity(FALSE)
else
- animate(src, color="#222222", time=5)
- set_opacity(1)
+ animate(src, color = "#222222", time = 0.5 SECONDS)
+ set_opacity(TRUE)
/obj/structure/window/narsie_act()
color = NARSIE_WINDOW_COLOUR
@@ -514,7 +514,7 @@
var/id = 0
var/active = 0
-/obj/machinery/button/windowtint/Initialize(mapload, w_dir=null)
+/obj/machinery/button/windowtint/Initialize(mapload, w_dir = null)
. = ..()
switch(w_dir)
if(NORTH)
@@ -537,7 +537,6 @@
if(!I.tool_use_check(user, 0))
return
user.visible_message("[user] starts unwrenching [src] from the wall...", "You are unwrenching [src] from the wall...", "You hear ratcheting.")
- . = TRUE
if(!I.use_tool(src, user, 50, volume = I.tool_volume))
return
WRENCH_UNANCHOR_WALL_MESSAGE
@@ -554,7 +553,7 @@
if(W.id == src.id || !W.id)
W.toggle_polarization()
- for(var/obj/structure/window/full/reinforced/polarized/W in range(src,range))
+ for(var/obj/structure/window/full/reinforced/polarized/W in range(src, range))
if(W.id == src.id || !W.id)
W.toggle_polarization()