From 29fe67e4c54b712971e5c67b0ad8a2312f2b3a83 Mon Sep 17 00:00:00 2001 From: Alfalfa Scout Date: Tue, 16 Jun 2026 17:21:51 -0400 Subject: [PATCH] Apply suggestion from review. --- code/game/objects/items/robot/robot_parts.dm | 9 +++++---- code/modules/surgery/robotics.dm | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/code/game/objects/items/robot/robot_parts.dm b/code/game/objects/items/robot/robot_parts.dm index 277612f22c0..d51ababe7f5 100644 --- a/code/game/objects/items/robot/robot_parts.dm +++ b/code/game/objects/items/robot/robot_parts.dm @@ -25,11 +25,12 @@ /obj/item/robot_parts/attack_self__legacy__attackchain(mob/user) var/list/possible_robolimbs = list() - for(var/robolimb in GLOB.all_robolimbs) - var/datum/robolimb/robopart = GLOB.all_robolimbs[robolimb] + var/limb_name + var/datum/robolimb/limb_datum + for(limb_name, limb_datum in GLOB.all_robolimbs) for(var/body_part in part) - if(body_part in robopart.parts) - possible_robolimbs += robolimb + if(body_part in limb_datum.parts) + possible_robolimbs += limb_name break var/choice = tgui_input_list(user, "Select the company appearance for this limb", "Limb Company Selection", possible_robolimbs) if(!choice) diff --git a/code/modules/surgery/robotics.dm b/code/modules/surgery/robotics.dm index 88ce8dd3a9a..f6b14d68977 100644 --- a/code/modules/surgery/robotics.dm +++ b/code/modules/surgery/robotics.dm @@ -717,10 +717,11 @@ /datum/surgery_step/robotics/external/customize_appearance/end_step(mob/living/user, mob/living/carbon/human/target, target_zone, obj/item/tool, datum/surgery/surgery) var/possible_robolimbs = list() - for(var/robolimb in GLOB.all_robolimbs) - var/datum/robolimb/robopart = GLOB.all_robolimbs[robolimb] - if(target_zone in robopart.parts) - possible_robolimbs += robolimb + var/limb_name + var/datum/robolimb/limb_datum + for(limb_name, limb_datum in GLOB.all_robolimbs) + if(target_zone in limb_datum.parts) + possible_robolimbs += limb_name var/chosen_appearance = tgui_input_list(user, "Select the company appearance for this limb.", "Limb Company Selection", possible_robolimbs) if(!chosen_appearance) return SURGERY_STEP_INCOMPLETE