Make DB admin ranks more useful (#29906)

* Make DB admin ranks more useful

* Avoid error message when cancelling permission toggle, allow adding localhost admins as real admins.

* Lint.

* Don't SQL error when a previously-unseen player connects.

* Use ckey of permission editor, not mob name.

* Strikethrough

* Order in the list.

* Deadmin, readmin, and 2fa.

* Correct merge error

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
This commit is contained in:
Charlie Nolan
2025-08-10 12:05:19 +01:00
committed by GitHub
co-authored by Burzah
parent f67dd166cb
commit 2b98749d32
20 changed files with 1037 additions and 469 deletions
@@ -32,7 +32,7 @@
if(islist(data["admin_assignments"]))
ckey_rank_map.Cut()
for(var/list/kvset in data["admin_assignments"])
ckey_rank_map[kvset["ckey"]] = kvset["rank"]
ckey_rank_map[ckey(kvset["ckey"])] = kvset["rank"]
// Load admin colours
if(islist(data["admin_rank_colour_map"]))
@@ -585,7 +585,7 @@ UI STUFF
for(var/client/X in GLOB.admins)
if(ckey(X.ckey) == ckey(T.client_ckey))
continue
if(!check_rights_for(X, rights_needed))
if(!check_rights_client(rights_needed, FALSE, X))
continue
for(var/key in X.pm_tracker.pms)
if(ckey(key) != ckey(T.client_ckey))