From 371003d0d3a9e9006ff140b839c18b759b05cb0a Mon Sep 17 00:00:00 2001 From: Qwertytoforty <52090703+Qwertytoforty@users.noreply.github.com> Date: Tue, 4 Jan 2022 16:39:51 -0500 Subject: [PATCH] Removes crit_fail from being an object level variable (#17300) --- code/game/mecha/equipment/mecha_equipment.dm | 6 ------ .../mecha/equipment/tools/medical_tools.dm | 5 ----- .../game/mecha/equipment/tools/other_tools.dm | 20 ------------------- code/game/objects/objs.dm | 1 - code/modules/surgery/organs/augments_arms.dm | 2 +- .../surgery/organs/augments_internal.dm | 1 + 6 files changed, 2 insertions(+), 33 deletions(-) diff --git a/code/game/mecha/equipment/mecha_equipment.dm b/code/game/mecha/equipment/mecha_equipment.dm index d40e9302541..987a210c711 100644 --- a/code/game/mecha/equipment/mecha_equipment.dm +++ b/code/game/mecha/equipment/mecha_equipment.dm @@ -42,10 +42,6 @@ detach(chassis) return ..() -/obj/item/mecha_parts/mecha_equipment/proc/critfail() - if(chassis) - log_message("Critical failure", 1) - return /obj/item/mecha_parts/mecha_equipment/proc/get_equip_info() if(!chassis) @@ -73,8 +69,6 @@ return 0 if(!equip_ready) return 0 - if(crit_fail) - return 0 if(energy_drain && !chassis.has_charge(energy_drain)) return 0 return 1 diff --git a/code/game/mecha/equipment/tools/medical_tools.dm b/code/game/mecha/equipment/tools/medical_tools.dm index 98d3a2a2f13..e3c87bb783a 100644 --- a/code/game/mecha/equipment/tools/medical_tools.dm +++ b/code/game/mecha/equipment/tools/medical_tools.dm @@ -270,11 +270,6 @@ STOP_PROCESSING(SSobj, src) return ..() -/obj/item/mecha_parts/mecha_equipment/medical/syringe_gun/critfail() - ..() - if(reagents) - reagents.set_reacting(TRUE) - /obj/item/mecha_parts/mecha_equipment/medical/syringe_gun/can_attach(obj/mecha/medical/M) if(..()) if(istype(M)) diff --git a/code/game/mecha/equipment/tools/other_tools.dm b/code/game/mecha/equipment/tools/other_tools.dm index 517698b14ca..ffb9b1ee155 100644 --- a/code/game/mecha/equipment/tools/other_tools.dm +++ b/code/game/mecha/equipment/tools/other_tools.dm @@ -390,23 +390,6 @@ /obj/item/mecha_parts/mecha_equipment/generator/attackby(weapon,mob/user, params) load_fuel(weapon) -/obj/item/mecha_parts/mecha_equipment/generator/critfail() - ..() - var/turf/simulated/T = get_turf(src) - if(!istype(T)) - return - var/datum/gas_mixture/GM = new - if(prob(10)) - GM.toxins += 100 - GM.temperature = 1500+T0C //should be enough to start a fire - T.visible_message("[src] suddenly disgorges a cloud of heated plasma.") - qdel(src) - else - GM.toxins += 5 - GM.temperature = istype(T) ? T.air.return_temperature() : T20C - T.visible_message("[src] suddenly disgorges a cloud of plasma.") - T.assume_air(GM) - /obj/item/mecha_parts/mecha_equipment/generator/process() if(!chassis) STOP_PROCESSING(SSobj, src) @@ -446,9 +429,6 @@ power_per_cycle = 50 var/rad_per_cycle = 30 -/obj/item/mecha_parts/mecha_equipment/generator/nuclear/critfail() - return - /obj/item/mecha_parts/mecha_equipment/generator/nuclear/process() if(..()) radiation_pulse(get_turf(src), rad_per_cycle) diff --git a/code/game/objects/objs.dm b/code/game/objects/objs.dm index 1ca64c8de37..b65a08bbfbb 100644 --- a/code/game/objects/objs.dm +++ b/code/game/objects/objs.dm @@ -1,7 +1,6 @@ /obj //var/datum/module/mod //not used var/origin_tech = null //Used by R&D to determine what research bonuses it grants. - var/crit_fail = FALSE animate_movement = 2 var/list/species_exception = null // list() of species types, if a species cannot put items in a certain slot, but species type is in list, it will be able to wear that item var/sharp = FALSE // whether this object cuts diff --git a/code/modules/surgery/organs/augments_arms.dm b/code/modules/surgery/organs/augments_arms.dm index 035cb1b31b2..e9182fd0cb3 100644 --- a/code/modules/surgery/organs/augments_arms.dm +++ b/code/modules/surgery/organs/augments_arms.dm @@ -171,7 +171,7 @@ owner.adjust_fire_stacks(20) owner.IgniteMob() owner.adjustFireLoss(25) - crit_fail = 1 + crit_fail = TRUE else // The gun will still discharge anyway. ..() diff --git a/code/modules/surgery/organs/augments_internal.dm b/code/modules/surgery/organs/augments_internal.dm index b3d8529d5b3..ec9dea07a9a 100644 --- a/code/modules/surgery/organs/augments_internal.dm +++ b/code/modules/surgery/organs/augments_internal.dm @@ -4,6 +4,7 @@ status = ORGAN_ROBOT var/implant_color = "#FFFFFF" var/implant_overlay + var/crit_fail = FALSE //Used by certain implants to disable them. tough = TRUE // Immune to damage /obj/item/organ/internal/cyberimp/New(mob/M = null)