cyberpresidentvanellope/Paradise
1
0
Fork 0
mirror of https://github.com/ParadiseSS13/Paradise.git synced 2026-08-23 03:57:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

CI lint for UID() misuse (#28465)

Browse Source 
* Adds CI check for UID() being passed parameters.

* Fixes cases of UID() being passed parameters.
This commit is contained in:
chuga-git
2025-02-21 19:35:02 +00:00
committed by GitHub
parent 746cf7eb5c
commit 38642d5888
12 changed files with 27 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/mod/mod_actions.dm
+1 -1
View File
@@ -116,7 +116,7 @@
return ..()
/datum/action/item_action/mod/pinned_module/Grant(mob/user)
var/user_uid = UID(user)
var/user_uid = user.UID()
if(!pinner_uid)
pinner_uid = user_uid
module.pinned_to[pinner_uid] = src
code/modules/mod/mod_types.dm
+2 -2
View File
@@ -28,9 +28,9 @@
for(var/obj/item/mod/module/module as anything in modules)
if(!default_pins[module.type]) //this module isnt meant to be pinned by default
continue
if(UID(wearer) in default_pins[module.type]) //if we already had pinned once to this user, don care anymore
if(wearer.UID() in default_pins[module.type]) //if we already had pinned once to this user, don care anymore
continue
default_pins[module.type] += UID(wearer)
default_pins[module.type] += wearer.UID()
module.pin(wearer)
/obj/item/mod/control/pre_equipped/uninstall(obj/item/mod/module/old_module, deleting)
code/modules/mod/mod_ui.dm
+1 -1
View File
@@ -27,7 +27,7 @@
"description" = module.desc,
"module_type" = module.module_type,
"module_active" = module.active,
"pinned" = module.pinned_to[UID(user)], //might just want user here
"pinned" = module.pinned_to[user.UID()], //might just want user here
"idle_power" = module.idle_power_cost,
"active_power" = module.active_power_cost,
"use_power" = module.use_power_cost,
code/modules/mod/modules/_modules.dm
+1 -1
View File
@@ -59,7 +59,7 @@
/obj/item/mod/module/Initialize(mapload)
. = ..()
module_UID = UID(src)
module_UID = UID()
if(module_type != MODULE_ACTIVE)
return
if(ispath(device))
code/modules/mod/modules/modules_antag.dm
+2 -2
View File
@@ -540,10 +540,10 @@
incompatible_modules = list(/obj/item/mod/module/anti_magic)
/obj/item/mod/module/anti_magic/on_suit_activation()
ADD_TRAIT(mod.wearer, TRAIT_ANTIMAGIC, "[UID(src)]")
ADD_TRAIT(mod.wearer, TRAIT_ANTIMAGIC, "[UID()]")
/obj/item/mod/module/anti_magic/on_suit_deactivation(deleting = FALSE)
REMOVE_TRAIT(mod.wearer, TRAIT_ANTIMAGIC, "[UID(src)]")
REMOVE_TRAIT(mod.wearer, TRAIT_ANTIMAGIC, "[UID()]")
/obj/item/mod/module/anomaly_locked/teslawall
name = "MOD arc-shield module" // temp