From 3aa6154a3dad330b079dba1bdee252cc900a681c Mon Sep 17 00:00:00 2001
From: PhantornRU <41479614+PhantornRU@users.noreply.github.com>
Date: Thu, 14 Dec 2023 21:21:11 +1000
Subject: [PATCH] FIX: correct custom rank manifest modify (#23491)

* custom_rank_manifest_modify

* Update code/datums/datacore.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/datums/datacore.dm

* Update code/datums/datacore.dm

---------

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
---
 code/datums/datacore.dm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/code/datums/datacore.dm b/code/datums/datacore.dm
index 7baab0c11f8..34f3a9e450e 100644
--- a/code/datums/datacore.dm
+++ b/code/datums/datacore.dm
@@ -117,14 +117,20 @@ GLOBAL_LIST_EMPTY(PDA_Manifest)
 				break
 
 	var/list/all_jobs = get_job_datums()
+	var/is_custom_job = TRUE
 
 	for(var/datum/job/J in all_jobs)
 		var/list/alttitles = get_alternate_titles(J.title)
-		if(!J)	continue
+		if(J.title == real_title)
+			is_custom_job = FALSE
 		if(assignment in alttitles)
 			real_title = J.title
+			is_custom_job = FALSE
 			break
 
+	if(is_custom_job)
+		real_title = foundrecord.fields["real_rank"]
+
 	if(foundrecord)
 		foundrecord.fields["rank"] = assignment
 		foundrecord.fields["real_rank"] = real_title