- Changed all "male" and "female" assignments to use the constants MALE and FEMALE.

- Added a message_admins() message which is sent if a character setup mismatch is detected to help diagnose the problem.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4496 316c924e-a436-60f5-8080-3fe189b3f50e

code/modules/mob/living/carbon/human/human_attackhand.dm

@@ -103,9 +103,9 @@
 
 			if(ELECTRICHANDS in M.augmentations)
 				var/gendertxt = "their"
-				if(M.gender == "male")
+				if(M.gender == MALE)
 					gendertxt = "his"
-				if(M.gender == "female")
+				if(M.gender == FEMALE)
 					gendertxt = "her"
 
 				visible_message("\red <B>[M] has shocked [src] with [gendertxt] bare hands!</B>")

code/modules/mob/living/carbon/metroid/metroid.dm

@@ -468,9 +468,9 @@
 		else
 			if(ELECTRICHANDS in M.augmentations)
 				var/gendertxt = "their"
-				if(M.gender == "male")
+				if(M.gender == MALE)
 					gendertxt = "his"
-				if(M.gender == "female")
+				if(M.gender == FEMALE)
 					gendertxt = "her"
 
 				visible_message("\red <B>[M] has shocked [src] with [gendertxt] bare hands!</B>")

code/modules/mob/living/carbon/monkey/monkey.dm

@@ -16,7 +16,7 @@
 		dna.unique_enzymes = md5(name)
 				//////////blah
 		var/gendervar
-		if (gender == "male")
+		if (gender == MALE)
 			gendervar = add_zero2(num2hex((rand(1,2049)),1), 3)
 		else
 			gendervar = add_zero2(num2hex((rand(2051,4094)),1), 3)

code/modules/mob/living/simple_animal/corgi.dm

@@ -254,7 +254,7 @@
 /mob/living/simple_animal/corgi/Ian
 	name = "Ian"
 	real_name = "Ian"	//Intended to hold the name without altering it.
-	gender = "male"
+	gender = MALE
 	desc = "It's a corgi."
 	var/turns_since_scan = 0
 	var/obj/movement_target

code/modules/mob/new_player/preferences.dm

@@ -729,6 +729,12 @@ datum/preferences
 				if(character&&character.client)
 					setup_client(character.client)
 
+		//Debugging report to track down a bug, which randomly assigned the plural gender to people.
+		if(character.gender in list(PLURAL, NEUTER))
+			if(isliving(src)) //Ghosts get neuter by default
+				message_admins("[character] ([character.ckey]) has spawned with their gender as plural or neuter. Please notify coders.")
+				character.gender = MALE
+
 	proc/copy_to_observer(mob/dead/observer/character)
 		spawn(10)
 			if(character && character.client)