diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 45b7dc5a642..526be3bcaf0 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -15,7 +15,6 @@
add: Added new things
del: Removed old things
tweak: tweaked a few things
-balance: rebalanced something
fix: fixed a few things
wip: added a few works in progress
soundadd: added a new sound thingy
diff --git a/_maps/map_files/cyberiad/cyberiad.dmm b/_maps/map_files/cyberiad/cyberiad.dmm
index 8de75d7aaf1..d046e4fb402 100644
--- a/_maps/map_files/cyberiad/cyberiad.dmm
+++ b/_maps/map_files/cyberiad/cyberiad.dmm
@@ -35447,7 +35447,6 @@
/area/library)
"bmF" = (
/obj/structure/cult/archives,
-/obj/item/videocam,
/obj/machinery/light_switch{
pixel_y = -25
},
@@ -72015,7 +72014,7 @@
dir = 8;
layer = 2.9
},
-/obj/item/circuitboard/rdconsole/public{
+/obj/item/circuitboard/rdconsole{
pixel_x = -4
},
/obj/item/circuitboard/rdserver{
diff --git a/code/LINDA/LINDA_turf_tile.dm b/code/LINDA/LINDA_turf_tile.dm
index a0a0b6b8784..b86ad2299ff 100644
--- a/code/LINDA/LINDA_turf_tile.dm
+++ b/code/LINDA/LINDA_turf_tile.dm
@@ -486,7 +486,7 @@ turf/simulated/proc/consider_superconductivity(starting)
turf/simulated/proc/radiate_to_spess() //Radiate excess tile heat to space
if(temperature > T0C) //Considering 0 degC as te break even point for radiation in and out
- var/delta_temperature = (temperature_archived - 2.7) //hardcoded space temperature
+ var/delta_temperature = (temperature_archived - TCMB) //hardcoded space temperature
if((heat_capacity > 0) && (abs(delta_temperature) > MINIMUM_TEMPERATURE_DELTA_TO_CONSIDER))
var/heat = thermal_conductivity*delta_temperature* \
diff --git a/code/__DEFINES/components.dm b/code/__DEFINES/components.dm
index df957eaa11e..c94dff5ca6c 100644
--- a/code/__DEFINES/components.dm
+++ b/code/__DEFINES/components.dm
@@ -107,6 +107,7 @@
#define COMSIG_MOVABLE_MOVED "movable_moved" //from base of atom/movable/Moved(): (/atom, dir)
#define COMSIG_MOVABLE_CROSS "movable_cross" //from base of atom/movable/Cross(): (/atom/movable)
#define COMSIG_MOVABLE_CROSSED "movable_crossed" //from base of atom/movable/Crossed(): (/atom/movable)
+#define COMSIG_CROSSED_MOVABLE "crossed_movable" //when we cross over something (calling Crossed() on that atom)
#define COMSIG_MOVABLE_UNCROSSED "movable_uncrossed" //from base of atom/movable/Uncrossed(): (/atom/movable)
#define COMSIG_MOVABLE_UNCROSS "movable_uncross" //from base of atom/movable/Uncross(): (/atom/movable)
#define COMPONENT_MOVABLE_BLOCK_UNCROSS 1
diff --git a/code/_onclick/hud/screen_objects.dm b/code/_onclick/hud/screen_objects.dm
index c3c9b6f7e65..c0f5cfd5f3b 100644
--- a/code/_onclick/hud/screen_objects.dm
+++ b/code/_onclick/hud/screen_objects.dm
@@ -362,7 +362,7 @@
object_overlays += item_overlay
add_overlay(object_overlays)
-/obj/screen/inventory/Click()
+/obj/screen/inventory/Click(location, control, params)
// At this point in client Click() code we have passed the 1/10 sec check and little else
// We don't even know if it's a middle click
if(world.time <= usr.next_move)
@@ -371,6 +371,12 @@
return 1
if(istype(usr.loc,/obj/mecha)) // stops inventory actions in a mech
return 1
+
+ if(hud?.mymob && slot_id)
+ var/obj/item/inv_item = hud.mymob.get_item_by_slot(slot_id)
+ if(inv_item)
+ return inv_item.Click(location, control, params)
+
if(usr.attack_ui(slot_id))
usr.update_inv_l_hand(0)
usr.update_inv_r_hand(0)
diff --git a/code/controllers/subsystem/chat.dm b/code/controllers/subsystem/chat.dm
index a90e14d0ab4..d2f87c93e06 100644
--- a/code/controllers/subsystem/chat.dm
+++ b/code/controllers/subsystem/chat.dm
@@ -11,7 +11,8 @@ SUBSYSTEM_DEF(chat)
/datum/controller/subsystem/chat/fire()
for(var/i in payload)
var/client/C = i
- C << output(payload[C], "browseroutput:output")
+ if(C)
+ C << output(payload[C], "browseroutput:output")
payload -= C
if(MC_TICK_CHECK)
diff --git a/code/controllers/subsystem/jobs.dm b/code/controllers/subsystem/jobs.dm
index 504a2d74a2c..d7e7a3cc33e 100644
--- a/code/controllers/subsystem/jobs.dm
+++ b/code/controllers/subsystem/jobs.dm
@@ -439,7 +439,7 @@ SUBSYSTEM_DEF(jobs)
if(job.is_security)
to_chat(H, "As a member of Security, you are to know Space Law, Legal Standard Operating Procedure, as well as your Department SOP")
if(job.req_admin_notify)
- to_chat(H, "You are playing a job that is important for the game progression. If you have to disconnect, please notify the admins via adminhelp.")
+ to_chat(H, "You are playing a job that is important for the game progression. If you have to disconnect, please go to cryo and inform command. If you are unable to do so, please notify the admins via adminhelp.")
return H
/datum/controller/subsystem/jobs/proc/EquipRank(mob/living/carbon/human/H, rank, joined_late = 0) // Equip and put them in an area
@@ -690,4 +690,4 @@ SUBSYSTEM_DEF(jobs)
.++
new_id_change_records["[id_change_counter]"] = thisrecord
id_change_counter++
- id_change_records = new_id_change_records
\ No newline at end of file
+ id_change_records = new_id_change_records
diff --git a/code/game/atoms_movable.dm b/code/game/atoms_movable.dm
index cf7f931ff32..2fb8796dc10 100644
--- a/code/game/atoms_movable.dm
+++ b/code/game/atoms_movable.dm
@@ -220,6 +220,7 @@
// This is automatically called when something enters your square
/atom/movable/Crossed(atom/movable/AM, oldloc)
SEND_SIGNAL(src, COMSIG_MOVABLE_CROSSED, AM)
+ SEND_SIGNAL(AM, COMSIG_CROSSED_MOVABLE, src)
/atom/movable/Bump(atom/A, yes) //the "yes" arg is to differentiate our Bump proc from byond's, without it every Bump() call would become a double Bump().
if(A && yes)
diff --git a/code/game/gamemodes/cult/cult_structures.dm b/code/game/gamemodes/cult/cult_structures.dm
index 3489a087ec0..de8846d292e 100644
--- a/code/game/gamemodes/cult/cult_structures.dm
+++ b/code/game/gamemodes/cult/cult_structures.dm
@@ -226,7 +226,7 @@ var/list/blacklisted_pylon_turfs = typecacheof(list(
if(istype(T, /turf/simulated/floor))
T.ChangeTurf(/turf/simulated/floor/engine/cult)
if(istype(T, /turf/simulated/wall))
- T.ChangeTurf(/turf/simulated/wall/cult)
+ T.ChangeTurf(/turf/simulated/wall/cult/artificer)
else
var/turf/simulated/floor/engine/cult/F = safepick(cultturfs)
if(F)
diff --git a/code/game/gamemodes/miniantags/abduction/abduction.dm b/code/game/gamemodes/miniantags/abduction/abduction.dm
index 9fce3cc6e24..bcbc86d991b 100644
--- a/code/game/gamemodes/miniantags/abduction/abduction.dm
+++ b/code/game/gamemodes/miniantags/abduction/abduction.dm
@@ -208,12 +208,14 @@
text += "
The abductors were:
"
for(var/datum/mind/abductor_mind in abductors)
text += printplayer(abductor_mind)
+ text += "
"
text += printobjectives(abductor_mind)
text += "
"
if(abductees.len)
text += "
The abductees were:
"
for(var/datum/mind/abductee_mind in abductees)
text += printplayer(abductee_mind)
+ text += "
"
text += printobjectives(abductee_mind)
text += "
"
to_chat(world, text)
diff --git a/code/game/jobs/job/central.dm b/code/game/jobs/job/central.dm
index 1d6ae0162a2..a20476155d7 100644
--- a/code/game/jobs/job/central.dm
+++ b/code/game/jobs/job/central.dm
@@ -66,9 +66,9 @@
/datum/outfit/job/ntspecops
name = "Special Operations Officer"
jobtype = /datum/job/ntspecops
- uniform = /obj/item/clothing/under/rank/centcom_commander
+ uniform = /obj/item/clothing/under/rank/centcom/captain
suit = /obj/item/clothing/suit/space/deathsquad/officer
- back = /obj/item/storage/backpack/security
+ back = /obj/item/storage/backpack/ert/security
belt = /obj/item/storage/belt/military/assault
gloves = /obj/item/clothing/gloves/combat
shoes = /obj/item/clothing/shoes/combat
diff --git a/code/game/jobs/job/supervisor.dm b/code/game/jobs/job/supervisor.dm
index feaf1c7972d..6a22935f7be 100644
--- a/code/game/jobs/job/supervisor.dm
+++ b/code/game/jobs/job/supervisor.dm
@@ -182,9 +182,9 @@ var/datum/announcement/minor/captain_announcement = new(do_newscast = 0)
/obj/item/gun/energy/gun/blueshield = 1
)
implants = list(/obj/item/implant/mindshield)
- backpack = /obj/item/storage/backpack/security
- satchel = /obj/item/storage/backpack/satchel_sec
- dufflebag = /obj/item/storage/backpack/duffel/security
+ backpack = /obj/item/storage/backpack/blueshield
+ satchel = /obj/item/storage/backpack/satchel_blueshield
+ dufflebag = /obj/item/storage/backpack/duffel/blueshield
/datum/job/judge
diff --git a/code/game/jobs/job/support.dm b/code/game/jobs/job/support.dm
index e4bb22b28af..9a70beaae31 100644
--- a/code/game/jobs/job/support.dm
+++ b/code/game/jobs/job/support.dm
@@ -294,6 +294,7 @@
genemutcheck(H, COMICBLOCK, null, MUTCHK_FORCED)
H.dna.default_blocks.Add(COMICBLOCK)
H.check_mutations = TRUE
+ H.add_language("Clownish")
//action given to antag clowns
/datum/action/innate/toggle_clumsy
@@ -420,6 +421,8 @@
r_pocket = /obj/item/barcodescanner
l_hand = /obj/item/storage/bag/books
pda = /obj/item/pda/librarian
+ backpack_contents = list(
+ /obj/item/videocam = 1)
/datum/job/barber
title = "Barber"
diff --git a/code/game/machinery/Freezer.dm b/code/game/machinery/Freezer.dm
index 8f2625b8854..b6c6121cfd6 100644
--- a/code/game/machinery/Freezer.dm
+++ b/code/game/machinery/Freezer.dm
@@ -8,6 +8,7 @@
use_power = IDLE_POWER_USE
current_heat_capacity = 1000
layer = 3
+ plane = GAME_PLANE
max_integrity = 300
armor = list("melee" = 0, "bullet" = 0, "laser" = 0, "energy" = 100, "bomb" = 0, "bio" = 100, "rad" = 100, "fire" = 80, "acid" = 30)
diff --git a/code/game/machinery/doors/airlock.dm b/code/game/machinery/doors/airlock.dm
index 26f0e2a2400..444c319334b 100644
--- a/code/game/machinery/doors/airlock.dm
+++ b/code/game/machinery/doors/airlock.dm
@@ -1034,6 +1034,17 @@ About the new airlock wires panel:
/obj/machinery/door/airlock/try_to_crowbar(mob/living/user, obj/item/I) //*scream
if(operating)
return
+ if(istype(I, /obj/item/twohanded/fireaxe)) //let's make this more specific //FUCK YOU
+ var/obj/item/twohanded/fireaxe/F = I
+ if(F.wielded)
+ spawn(0)
+ if(density)
+ open(1)
+ else
+ close(1)
+ else
+ to_chat(user, "You need to be wielding the fire axe to do that!")
+ return
var/beingcrowbarred = FALSE
if(I.tool_behaviour == TOOL_CROWBAR && I.tool_use_check(user, 0))
beingcrowbarred = TRUE
@@ -1049,17 +1060,6 @@ About the new airlock wires panel:
if(locked)
to_chat(user, "The airlock's bolts prevent it from being forced!")
return
- if(istype(I, /obj/item/twohanded/fireaxe)) //let's make this more specific //FUCK YOU
- var/obj/item/twohanded/fireaxe/F = I
- if(F.wielded)
- spawn(0)
- if(density)
- open(1)
- else
- close(1)
- else
- to_chat(user, "You need to be wielding the fire axe to do that!")
- return
else if(!arePowerSystemsOn())
spawn(0)
if(density)
diff --git a/code/game/machinery/doors/door.dm b/code/game/machinery/doors/door.dm
index 83ce512ebd9..14d1de97327 100644
--- a/code/game/machinery/doors/door.dm
+++ b/code/game/machinery/doors/door.dm
@@ -185,12 +185,12 @@
/obj/machinery/door/proc/unrestricted_side(mob/M) //Allows for specific side of airlocks to be unrestrected (IE, can exit maint freely, but need access to enter)
return get_dir(src, M) & unres_sides
-/obj/machinery/door/proc/try_to_crowbar(obj/item/I, mob/user)
+/obj/machinery/door/proc/try_to_crowbar(mob/user, obj/item/I)
return
/obj/machinery/door/attackby(obj/item/I, mob/user, params)
if(user.a_intent != INTENT_HARM && istype(I, /obj/item/twohanded/fireaxe))
- try_to_crowbar(I, user)
+ try_to_crowbar(user, I)
return 1
else if(!(I.flags & NOBLUDGEON) && user.a_intent != INTENT_HARM)
try_to_activate_door(user)
@@ -206,7 +206,7 @@
return
if(!I.use_tool(src, user, 0, volume = I.tool_volume))
return
- try_to_crowbar(I, user)
+ try_to_crowbar(user, I)
/obj/machinery/door/take_damage(damage_amount, damage_type = BRUTE, damage_flag = 0, sound_effect = 1, attack_dir)
. = ..()
diff --git a/code/game/machinery/doors/windowdoor.dm b/code/game/machinery/doors/windowdoor.dm
index a69535e9fc9..ae87480e929 100644
--- a/code/game/machinery/doors/windowdoor.dm
+++ b/code/game/machinery/doors/windowdoor.dm
@@ -302,9 +302,9 @@
qdel(src)
else
- try_to_crowbar(I, user)
+ try_to_crowbar(user, I)
-/obj/machinery/door/window/try_to_crowbar(obj/item/I, mob/user)
+/obj/machinery/door/window/try_to_crowbar(mob/user, obj/item/I)
if(!hasPower())
if(density)
open(2)
diff --git a/code/game/mecha/equipment/tools/medical_tools.dm b/code/game/mecha/equipment/tools/medical_tools.dm
index aacd605b730..0bfbef39289 100644
--- a/code/game/mecha/equipment/tools/medical_tools.dm
+++ b/code/game/mecha/equipment/tools/medical_tools.dm
@@ -535,7 +535,7 @@
if(!istype(target, /obj/machinery/door))//early return if we're not trying to open a door
return
var/obj/machinery/door/D = target //the door we want to open
- D.try_to_crowbar(src, chassis.occupant)//use the door's crowbar function
+ D.try_to_crowbar(chassis.occupant, src)//use the door's crowbar function
if(isliving(target)) //interact with living beings
var/mob/living/M = target
if(chassis.occupant.a_intent == INTENT_HARM)//the patented, medical rescue claw is incapable of doing harm. Worry not.
diff --git a/code/game/objects/items/flag.dm b/code/game/objects/items/flag.dm
index 1b2eae4db8d..aed33fc2819 100644
--- a/code/game/objects/items/flag.dm
+++ b/code/game/objects/items/flag.dm
@@ -197,7 +197,7 @@
name = "Chameleon flag"
desc = "A poor recreation of the official NT flag. It seems to shimmer a little."
icon_state = "ntflag"
- origin_tech = "syndicate=4;magnets=4"
+ origin_tech = "syndicate=1;magnets=4"
var/updated_icon_state = null
var/used = FALSE
var/obj/item/grenade/boobytrap = null
diff --git a/code/game/objects/items/weapons/cigs.dm b/code/game/objects/items/weapons/cigs.dm
index c27ad41b66e..a2b193fc608 100644
--- a/code/game/objects/items/weapons/cigs.dm
+++ b/code/game/objects/items/weapons/cigs.dm
@@ -227,7 +227,7 @@ LIGHTERS ARE IN LIGHTERS.DM
list_reagents = list("nicotine" = 40, "omnizine" = 20)
/obj/item/clothing/mask/cigarette/medical_marijuana
- list_reagents = list("thc" = 40)
+ list_reagents = list("thc" = 40, "cbd" = 20)
/obj/item/clothing/mask/cigarette/robustgold
list_reagents = list("nicotine" = 40, "gold" = 1)
diff --git a/code/game/objects/items/weapons/scissors.dm b/code/game/objects/items/weapons/scissors.dm
index 3340542ea15..f2d750aafa2 100644
--- a/code/game/objects/items/weapons/scissors.dm
+++ b/code/game/objects/items/weapons/scissors.dm
@@ -27,57 +27,11 @@
return
if(ishuman(M))
var/mob/living/carbon/human/H = M
- //see code/modules/mob/new_player/preferences.dm at approx line 545 for comments!
- //this is largely copypasted from there.
- //handle facial hair (if necessary)
- var/list/species_facial_hair = list()
var/obj/item/organ/external/head/C = H.get_organ("head")
- var/datum/robolimb/robohead = all_robolimbs[C.model]
- if(H.gender == MALE || isvulpkanin(H))
- if(C.dna.species)
- for(var/i in GLOB.facial_hair_styles_list)
- var/datum/sprite_accessory/facial_hair/tmp_facial = GLOB.facial_hair_styles_list[i]
- if(C.dna.species.name in tmp_facial.species_allowed) //If the species is allowed to have the style, add the style to the list. Or, if the character has a prosthetic head, give them the human hair styles.
- if(C.dna.species.bodyflags & ALL_RPARTS) //If the character is of a species that can have full body prosthetics and their head doesn't suport human hair 'wigs', don't add the style to the list.
- if(robohead.is_monitor)
- to_chat(user, "You are unable to find anything on [H]'s face worth cutting. How disappointing.")
- return
- continue //If the head DOES support human hair wigs, make sure they don't get monitor-oriented styles.
- species_facial_hair += i
- else
- if(C.dna.species.bodyflags & ALL_RPARTS) //If the target is of a species that can have prosthetic heads, and the head supports human hair 'wigs' AND the hair-style is human-suitable, add it to the list.
- if(!robohead.is_monitor)
- if("Human" in tmp_facial.species_allowed)
- species_facial_hair += i
- else //Otherwise, they won't be getting any hairstyles.
- to_chat(user, "You are unable to find anything on [H]'s face worth cutting. How disappointing.")
- return
- else
- species_facial_hair = GLOB.facial_hair_styles_list
- var/f_new_style = input(user, "Select a facial hair style", "Grooming") as null|anything in species_facial_hair
+ //facial hair
+ var/f_new_style = input(user, "Select a facial hair style", "Grooming") as null|anything in H.generate_valid_facial_hairstyles()
//handle normal hair
- var/list/species_hair = list()
- if(C.dna.species)
- for(var/i in GLOB.hair_styles_public_list)
- var/datum/sprite_accessory/hair/tmp_hair = GLOB.hair_styles_public_list[i]
- if(C.dna.species.name in tmp_hair.species_allowed) //If the species is allowed to have the style, add the style to the list. Or, if the character has a prosthetic head, give them the human facial hair styles.
- if(C.dna.species.bodyflags & ALL_RPARTS) //If the character is of a species that can have full body prosthetics and their head doesn't suport human hair 'wigs', don't add the style to the list.
- if(robohead.is_monitor)
- to_chat(user, "You are unable to find anything on [H]'s head worth cutting. How disappointing.")
- return
- continue //If the head DOES support human hair wigs, make sure they don't get monitor-oriented styles.
- species_hair += i
- else
- if(C.dna.species.bodyflags & ALL_RPARTS) //If the target is of a species that can have prosthetic heads, and the head supports human hair 'wigs' AND the hair-style is human-suitable, add it to the list.
- if(!robohead.is_monitor)
- if("Human" in tmp_hair.species_allowed)
- species_hair += i
- else //Otherwise, they won't be getting any hairstyles.
- to_chat(user, "You are unable to find anything on [H]'s head worth cutting. How disappointing.")
- return
- else
- species_hair = GLOB.hair_styles_public_list
- var/h_new_style = input(user, "Select a hair style", "Grooming") as null|anything in species_hair
+ var/h_new_style = input(user, "Select a hair style", "Grooming") as null|anything in H.generate_valid_hairstyles()
user.visible_message("[user] starts cutting [M]'s hair!", "You start cutting [M]'s hair!") //arguments for this are: 1. what others see 2. what the user sees. --Fixed grammar, (TGameCo)
playsound(loc, 'sound/goonstation/misc/scissor.ogg', 100, 1)
if(do_after(user, 50 * toolspeed, target = H)) //this is the part that adds a delay. delay is in deciseconds. --Made it 5 seconds, because hair isn't cut in one second in real life, and I want at least a little bit longer time, (TGameCo)
diff --git a/code/game/objects/items/weapons/storage/backpack.dm b/code/game/objects/items/weapons/storage/backpack.dm
index 96806bb827a..af5e9540b02 100644
--- a/code/game/objects/items/weapons/storage/backpack.dm
+++ b/code/game/objects/items/weapons/storage/backpack.dm
@@ -193,6 +193,12 @@
icon_state = "viropack"
item_state = "viropack"
+/obj/item/storage/backpack/blueshield
+ name = "blueshield backpack"
+ desc = "A robust backpack issued to Nanotrasen's finest."
+ icon_state = "blueshieldpack"
+ item_state = "blueshieldpack"
+
/*
* Satchel Types
*/
@@ -287,6 +293,11 @@
icon_state = "satchel-cap"
resistance_flags = FIRE_PROOF
+/obj/item/storage/backpack/satchel_blueshield
+ name = "blueshield satchel"
+ desc = "A robust satchel issued to Nanotrasen's finest."
+ icon_state = "satchel-blueshield"
+
/obj/item/storage/backpack/satchel_flat
name = "smuggler's satchel"
desc = "A very slim satchel that can easily fit into tight spaces."
@@ -531,12 +542,19 @@
icon_state = "duffel-clown"
item_state = "duffel-clown"
+obj/item/storage/backpack/duffel/blueshield
+ name = "blueshield duffelbag"
+ desc = "A robust duffelbag issued to Nanotrasen's finest."
+ icon_state = "duffel-blueshield"
+ item_state = "duffel-blueshield"
+
//ERT backpacks.
/obj/item/storage/backpack/ert
name = "emergency response team backpack"
desc = "A spacious backpack with lots of pockets, used by members of the Nanotrasen Emergency Response Team."
icon_state = "ert_commander"
item_state = "backpack"
+ max_combined_w_class = 30
resistance_flags = FIRE_PROOF
//Commander
diff --git a/code/game/objects/items/weapons/storage/fancy.dm b/code/game/objects/items/weapons/storage/fancy.dm
index 4d2b1bd9c44..a61d1ecda53 100644
--- a/code/game/objects/items/weapons/storage/fancy.dm
+++ b/code/game/objects/items/weapons/storage/fancy.dm
@@ -247,6 +247,7 @@
item_state = "cigpacket"
cigarette_type = /obj/item/clothing/mask/cigarette/medical_marijuana
+
/obj/item/storage/fancy/cigarettes/cigpack_uplift
name = "\improper Uplift Smooth packet"
desc = "Your favorite brand, now menthol flavored."
diff --git a/code/game/objects/structures/noticeboard.dm b/code/game/objects/structures/noticeboard.dm
index aa6528ee118..5938a52c1d5 100644
--- a/code/game/objects/structures/noticeboard.dm
+++ b/code/game/objects/structures/noticeboard.dm
@@ -78,10 +78,5 @@
if(href_list["read"])
var/obj/item/paper/P = locate(href_list["read"])
if((P && P.loc == src))
- if(!( istype(usr, /mob/living/carbon/human) ))
- usr << browse("
[P.name][stars(P.info)]", "window=[P.name]")
- onclose(usr, "[P.name]")
- else
- usr << browse("[P.name][P.info]", "window=[P.name]")
- onclose(usr, "[P.name]")
+ P.show_content(usr)
return
diff --git a/code/game/turfs/simulated/minerals.dm b/code/game/turfs/simulated/minerals.dm
index c4f0e93dbd6..118132765a1 100644
--- a/code/game/turfs/simulated/minerals.dm
+++ b/code/game/turfs/simulated/minerals.dm
@@ -8,7 +8,6 @@
smooth = SMOOTH_MORE | SMOOTH_BORDER
canSmoothWith = null
baseturf = /turf/simulated/floor/plating/asteroid/airless
- temperature = 2.7
opacity = 1
density = TRUE
blocks_air = TRUE
diff --git a/code/game/turfs/simulated/walls.dm b/code/game/turfs/simulated/walls.dm
index 8672c65ea69..7dd41815a4c 100644
--- a/code/game/turfs/simulated/walls.dm
+++ b/code/game/turfs/simulated/walls.dm
@@ -250,7 +250,7 @@
var/turf/simulated/floor/F = src
F.burn_tile()
- F.icon_state = "wall_thermite"
+ F.icon_state = "plating"
if(user)
to_chat(user, "The thermite starts melting through the wall.")
@@ -329,6 +329,9 @@
/turf/simulated/wall/welder_act(mob/user, obj/item/I)
. = TRUE
+ if(thermite && I.use_tool(src, user, volume = I.tool_volume))
+ thermitemelt(user)
+ return
if(rotting)
if(I.use_tool(src, user, volume = I.tool_volume))
for(var/obj/effect/overlay/wall_rot/WR in src)
diff --git a/code/game/turfs/simulated/walls_reinforced.dm b/code/game/turfs/simulated/walls_reinforced.dm
index 7988f9cccf1..4c211291ae0 100644
--- a/code/game/turfs/simulated/walls_reinforced.dm
+++ b/code/game/turfs/simulated/walls_reinforced.dm
@@ -93,6 +93,9 @@
return ..()
/turf/simulated/wall/r_wall/welder_act(mob/user, obj/item/I)
+ if(thermite && I.use_tool(src, user, volume = I.tool_volume))
+ thermitemelt(user)
+ return TRUE
if(!(d_state in list(RWALL_COVER, RWALL_SUPPORT_RODS, RWALL_CUT_COVER)))
return ..()
. = TRUE
diff --git a/code/game/world.dm b/code/game/world.dm
index 4488cb2d218..cccf5eb497a 100644
--- a/code/game/world.dm
+++ b/code/game/world.dm
@@ -4,6 +4,7 @@ var/global/list/map_transition_config = MAP_TRANSITION_CONFIG
/world/New()
SetupLogs()
+ enable_debugger() // Enable the extools debugger
log_world("World loaded at [time_stamp()]")
log_world("[GLOB.vars.len - GLOB.gvars_datum_in_built_vars.len] global variables")
@@ -468,3 +469,10 @@ proc/establish_db_connection()
return 1
#undef FAILED_DB_CONNECTION_CUTOFF
+
+// Proc to enable the extools debugger, which allows breakpoints, live var checking, and many other useful tools
+// The DLL is injected into the env by visual studio code. If not running VSCode, the proc will not call the initialization
+/world/proc/enable_debugger()
+ var/dll = world.GetConfig("env", "EXTOOLS_DLL")
+ if (dll)
+ call(dll, "debug_initialize")()
\ No newline at end of file
diff --git a/code/modules/admin/topic.dm b/code/modules/admin/topic.dm
index f5735548077..2d98626a1c3 100644
--- a/code/modules/admin/topic.dm
+++ b/code/modules/admin/topic.dm
@@ -2164,7 +2164,7 @@
var/obj/pageobj = B.contents[page]
data += "Page [page] - [pageobj.name]
"
- usr << browse(data, "window=[B.name]")
+ usr << browse(data, "window=PaperBundle[B.UID()]")
else
to_chat(usr, "The faxed item is not viewable. This is probably a bug, and should be reported on the tracker: [fax.type]")
diff --git a/code/modules/admin/verbs/randomverbs.dm b/code/modules/admin/verbs/randomverbs.dm
index 2384c24b6ff..a347f65590b 100644
--- a/code/modules/admin/verbs/randomverbs.dm
+++ b/code/modules/admin/verbs/randomverbs.dm
@@ -116,7 +116,7 @@
if(!msg)
return
- msg = pencode_to_html(msg)
+ msg = admin_pencode_to_html(msg)
to_chat(world, "[msg]")
log_admin("GlobalNarrate: [key_name(usr)] : [msg]")
message_admins("GlobalNarrate: [key_name_admin(usr)]: [msg]
", 1)
diff --git a/code/modules/busy_space/organizations.dm b/code/modules/busy_space/organizations.dm
index 41b3a80cbab..f80e82938ec 100644
--- a/code/modules/busy_space/organizations.dm
+++ b/code/modules/busy_space/organizations.dm
@@ -439,7 +439,7 @@
/datum/lore/organization/gov/synth
name = "Synthetic Union"
- short_name = "Synthtica"
+ short_name = "Synthetica"
acronym = "SYN"
desc = "A defensive coalition of synthetics based out of New Canaan,\
the Synthetic Union is an organization which aims to establish and consolidate synthetic rights across the galaxy.\
diff --git a/code/modules/client/preference/preferences.dm b/code/modules/client/preference/preferences.dm
index 56cb55b6b80..eb1587ff28c 100644
--- a/code/modules/client/preference/preferences.dm
+++ b/code/modules/client/preference/preferences.dm
@@ -1308,7 +1308,7 @@ var/global/list/special_role_times = list( //minimum age (in days) for accounts
else //Not using the whitelist? Aliens for everyone!
new_species += GLOB.whitelisted_species
- species = input("Please select a species", "Character Generation", null) in new_species
+ species = input("Please select a species", "Character Generation", null) in sortTim(new_species, /proc/cmp_text_asc)
var/datum/species/NS = GLOB.all_species[species]
if(!istype(NS)) //The species was invalid. Notify the user and fail out.
species = prev_species
@@ -1406,7 +1406,7 @@ var/global/list/special_role_times = list( //minimum age (in days) for accounts
if(!(lang.flags & RESTRICTED))
new_languages += lang.name
- language = input("Please select a secondary language", "Character Generation", null) in new_languages
+ language = input("Please select a secondary language", "Character Generation", null) in sortTim(new_languages, /proc/cmp_text_asc)
if("autohiss_mode")
if(S.autohiss_basic_map)
diff --git a/code/modules/clothing/under/miscellaneous.dm b/code/modules/clothing/under/miscellaneous.dm
index 9e009014deb..5203aafdcf6 100644
--- a/code/modules/clothing/under/miscellaneous.dm
+++ b/code/modules/clothing/under/miscellaneous.dm
@@ -96,38 +96,35 @@
item_color = "centcom"
/obj/item/clothing/under/rank/centcom/officer
- desc = "Gold trim on space-black cloth, this uniform displays the rank of \"Lieutenant-Commander\" and bears \"N.C.V. Fearless CV-286\" on the left shoulder."
- name = "\improper Nanotrasen Officers Uniform"
- icon_state = "officer"
- item_state = "g_suit"
- item_color = "officer"
+ desc = "Gold trim on space-black cloth, this uniform displays the rank of \"Lieutenant-Commander\" and bears \"N.A.S. Trurl \" on the left shoulder. Worn exclusively by officers of the Nanotrasen Navy. It's got exotic materials for protection."
+ name = "\improper Nanotrasen Naval Officer Uniform"
+ icon_state = "navy_gold"
+ item_state = "navy_gold"
+ item_color = "navy_gold"
displays_id = 0
flags_size = ONESIZEFITSALL
/obj/item/clothing/under/rank/centcom/captain
- desc = "Gold trim on space-black cloth, this uniform displays the rank of \"Captain\" and bears \"N.C.V. Fearless CV-286\" on the left shoulder."
- name = "\improper Nanotrasen Captains Uniform"
- icon_state = "centcom"
- item_state = "dg_suit"
- item_color = "centcom"
+ desc = "Gold trim on space-black cloth, this uniform displays the rank of \"Captain\" and bears \"N.A.S. Trurl \" on the left shoulder. Worn exclusively by officers of the Nanotrasen Navy. It's got exotic materials for protection."
+ name = "\improper Nanotrasen Naval Captain Uniform"
+ icon_state = "navy_gold"
+ item_state = "navy_gold"
+ item_color = "navy_gold"
displays_id = 0
+ flags_size = ONESIZEFITSALL
/obj/item/clothing/under/rank/centcom/blueshield
- desc = "Gold trim on space-black cloth, this uniform displays the rank of \"Lieutenant\" and bears \"N.S.S. Cyberiad\" on the left shoulder."
- name = "\improper Nanotrasen Navy Uniform"
+ desc = "Gold trim on space-black cloth, this uniform bears \"Close Protection\" on the left shoulder."
+ name = "\improper Formal Nanotrasen Uniform"
icon_state = "officer"
item_state = "g_suit"
item_color = "officer"
displays_id = 0
flags_size = ONESIZEFITSALL
-/obj/item/clothing/under/rank/centcom/blueshield/New()
- ..()
- desc = "Gold trim on space-black cloth, this uniform displays the rank of \"Lieutenant\" and bears [station_name()] on the left shoulder."
-
/obj/item/clothing/under/rank/centcom/representative
- desc = "Gold trim on space-black cloth, this uniform displays the rank of \"Ensign\" and bears \"N.S.S. Cyberiad\" on the left shoulder."
- name = "\improper Nanotrasen Navy Uniform"
+ desc = "Gold trim on space-black cloth, this uniform bears \"N.S.S. Cyberiad\" on the left shoulder."
+ name = "\improper Formal Nanotrasen Uniform"
icon_state = "officer"
item_state = "g_suit"
item_color = "officer"
@@ -136,11 +133,11 @@
/obj/item/clothing/under/rank/centcom/representative/New()
..()
- desc = "Gold trim on space-black cloth, this uniform displays the rank of \"Ensign\" and bears [station_name()] on the left shoulder."
+ desc = "Gold trim on space-black cloth, this uniform bears [station_name()] on the left shoulder."
/obj/item/clothing/under/rank/centcom/magistrate
desc = "Gold trim on space-black cloth, this uniform displays the rank of \"Magistrate\" and bears \"N.S.S. Cyberiad\" on the left shoulder."
- name = "\improper Nanotrasen Navy Uniform"
+ name = "\improper Formal Nanotrasen Uniform"
icon_state = "officer"
item_state = "g_suit"
item_color = "officer"
@@ -161,7 +158,7 @@
/obj/item/clothing/under/rank/blueshield
name = "blueshield uniform"
- desc = "A short-sleeved black uniform, paired with grey digital-camo cargo pants. Standard issue to Blueshield officers."
+ desc = "A short-sleeved black uniform, paired with grey digital-camo cargo pants. Standard issue to Blueshields."
icon_state = "ert_uniform"
item_state = "bl_suit"
item_color = "ert_uniform"
@@ -169,7 +166,7 @@
/obj/item/clothing/under/rank/blueshield/skirt
name = "blueshield skirt"
- desc = "A short, black and grey with blue markings skirted uniform. For the feminine Blueshield officers."
+ desc = "A short, black and grey with blue markings skirted uniform. For the feminine Blueshield."
icon_state = "blueshieldf"
item_state = "blueshieldf"
item_color = "blueshieldf"
diff --git a/code/modules/crafting/craft.dm b/code/modules/crafting/craft.dm
index 2e5c7d99082..36f0da802cc 100644
--- a/code/modules/crafting/craft.dm
+++ b/code/modules/crafting/craft.dm
@@ -89,7 +89,8 @@
/datum/personal_crafting/proc/get_surroundings(mob/user)
. = list()
- .["other"] = list()
+ .["other"] = list() //paths go in here
+ .["toolsother"] = list() // items go in here
for(var/obj/item/I in get_environment(user))
if(I.flags_2 & HOLOGRAM_2)
continue
@@ -102,22 +103,24 @@
if(RC.is_drainable())
for(var/datum/reagent/A in RC.reagents.reagent_list)
.["other"][A.type] += A.volume
- .["other"][I.type] += 1
+ .["other"][I.type] += 1
+ .["toolsother"][I] += 1
/datum/personal_crafting/proc/check_tools(mob/user, datum/crafting_recipe/R, list/contents)
- if(!R.tools.len)
+ if(!R.tools.len) //does not run if no tools are needed
return TRUE
var/list/possible_tools = list()
var/list/tools_used = list()
- for(var/obj/item/I in user.contents)
+ for(var/obj/item/I in user.contents) //searchs the inventory of the mob
if(istype(I, /obj/item/storage))
for(var/obj/item/SI in I.contents)
- if(SI.tool_behaviour) //Only add things that we could actually use as a tool
+ if(SI.tool_behaviour) //filters for tool behaviours
possible_tools += SI
if(I.tool_behaviour)
possible_tools += I
- possible_tools |= contents["other"]
- main_loop:
+
+ possible_tools |= contents["toolsother"] // this add contents to possible_tools
+ main_loop: // checks if all tools found are usable with the recipe
for(var/A in R.tools)
for(var/obj/item/I in possible_tools)
if(A == I.tool_behaviour)
@@ -129,26 +132,49 @@
return FALSE
return TRUE
-/datum/personal_crafting/proc/construct_item(mob/user, datum/crafting_recipe/R)
+/datum/personal_crafting/proc/check_pathtools(mob/user, datum/crafting_recipe/R, list/contents)
+ if(!R.pathtools.len) //does not run if no tools are needed
+ return TRUE
+ var/list/other_possible_tools = list()
+ for(var/obj/item/I in user.contents) // searchs the inventory of the mob
+ if(istype(I, /obj/item/storage))
+ for(var/obj/item/SI in I.contents)
+ other_possible_tools += SI.type // filters type paths
+ other_possible_tools += I.type
+
+ other_possible_tools |= contents["other"] // this adds contents to the other_possible_tools
+ main_loop: // checks if all tools found are usable with the recipe
+ for(var/A in R.pathtools)
+ for(var/I in other_possible_tools)
+ if(ispath(I,A))
+ continue main_loop
+ return FALSE
+ return TRUE
+
+/datum/personal_crafting/proc/construct_item(mob/user, datum/crafting_recipe/R)
var/list/contents = get_surroundings(user)
var/send_feedback = 1
if(check_contents(R, contents))
if(check_tools(user, R, contents))
- if(do_after(user, R.time, target = user))
- contents = get_surroundings(user)
- if(!check_contents(R, contents))
- return ", missing component."
- if(!check_tools(user, R, contents))
- return ", missing tool."
- var/list/parts = del_reqs(R, user)
- var/atom/movable/I = new R.result (get_turf(user.loc))
- I.CheckParts(parts, R)
- if(isitem(I))
- user.put_in_hands(I)
- if(send_feedback)
- feedback_add_details("object_crafted","[I.type]")
- return 0
- return "."
+ if(check_pathtools(user, R, contents))
+ if(do_after(user, R.time, target = user))
+ contents = get_surroundings(user)
+ if(!check_contents(R, contents))
+ return ", missing component."
+ if(!check_tools(user, R, contents))
+ return ", missing tool."
+ if(!check_pathtools(user, R, contents))
+ return ", missing tool."
+ var/list/parts = del_reqs(R, user)
+ var/atom/movable/I = new R.result (get_turf(user.loc))
+ I.CheckParts(parts, R)
+ if(isitem(I))
+ user.put_in_hands(I)
+ if(send_feedback)
+ feedback_add_details("object_crafted","[I.type]")
+ return 0
+ return "."
+ return ", missing tool."
return ", missing tool."
return ", missing component."
@@ -413,12 +439,15 @@
catalyst_text = replacetext(catalyst_text, ",", "", -1)
data["catalyst_text"] = catalyst_text
- for(var/a in R.tools)
+ for(var/a in R.pathtools)
if(ispath(a, /obj/item))
var/obj/item/b = a
tool_text += " [initial(b.name)],"
else
tool_text += " [a],"
+ for(var/a in R.tools)
+ var/b = a
+ tool_text += " [b],"
tool_text = replacetext(tool_text, ",", "", -1)
data["tool_text"] = tool_text
diff --git a/code/modules/crafting/recipes.dm b/code/modules/crafting/recipes.dm
index 63a3b953864..ec334979cd2 100644
--- a/code/modules/crafting/recipes.dm
+++ b/code/modules/crafting/recipes.dm
@@ -3,7 +3,8 @@
var/reqs[] = list() //type paths of items consumed associated with how many are needed
var/blacklist[] = list() //type paths of items explicitly not allowed as an ingredient
var/result //type path of item resulting from this craft
- var/tools[] = list() //type paths of items needed but not consumed
+ var/tools[] = list() //tool behaviours of items needed but not consumed
+ var/pathtools[] = list() //type paths of items needed but not consumed
var/time = 30 //time in deciseconds
var/parts[] = list() //type paths of items that will be placed in the result
var/chem_catalysts[] = list() //like tools but for reagents
@@ -307,7 +308,7 @@
time = 15
reqs = list(/obj/item/stack/sheet/wood = 1,
/obj/item/stack/cable_coil = 5)
- tools = list(/obj/item/kitchen/knife) // Gotta carve the wood into handles
+ pathtools = list(/obj/item/kitchen/knife) // Gotta carve the wood into handles
category = CAT_WEAPONRY
subcategory = CAT_WEAPON
@@ -328,8 +329,7 @@
/obj/item/stack/cable_coil = 10,
/obj/item/stack/sheet/plastic = 3,
/obj/item/stack/sheet/wood = 5)
- tools = list(TOOL_WELDER,
- TOOL_SCREWDRIVER)
+ tools = list(TOOL_WELDER, TOOL_SCREWDRIVER)
category = CAT_WEAPONRY
subcategory = CAT_WEAPON
@@ -354,7 +354,7 @@
result = /obj/item/stack/tile/carpet/black
time = 20
reqs = list(/obj/item/stack/tile/carpet = 1)
- tools = list(/obj/item/toy/crayon)
+ pathtools = list(/obj/item/toy/crayon)
category = CAT_MISC
/datum/crafting_recipe/showercurtain
@@ -559,7 +559,7 @@
reqs = list(/datum/reagent/paint/red = 10,
/datum/reagent/paint/black = 30,
/obj/item/storage/toolbox = 1) //Paint in reagents so it doesnt take the container up, yet still take it from the beaker
- tools = list(/obj/item/reagent_containers/glass/rag = 1) //need something to paint with it
+ pathtools = list(/obj/item/reagent_containers/glass/rag = 1) //need something to paint with it
category = CAT_MISC
/datum/crafting_recipe/snowman
@@ -578,152 +578,153 @@
result = /obj/item/decorations/sticky_decorations/flammable/heart
reqs = list(/obj/item/paper = 1,
/obj/item/stack/tape_roll = 1)
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/red)//cutters act as makeshift scissors. I doubt the barber wants to have their scissors stolen when somone wants to decorate
+ tools = list(TOOL_WIRECUTTER) //cutters act as makeshift scissors. I doubt the barber wants to have their scissors stolen when somone wants to decorate
+ pathtools = list(/obj/item/toy/crayon/red)
category = CAT_DECORATIONS
subcategory = CAT_DECORATION
/datum/crafting_recipe/paper_craft/single_eye
name = "Paper Eye"
result = /obj/item/decorations/sticky_decorations/flammable/singleeye
- tools = list(/obj/item/wirecutters,
- /obj/item/pen,
- /obj/item/toy/crayon/blue)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen, /obj/item/toy/crayon/blue)
category = CAT_DECORATIONS
subcategory = CAT_DECORATION
/datum/crafting_recipe/paper_craft/googlyeyes
name = "Paper Googly Eye"
result = /obj/item/decorations/sticky_decorations/flammable/googlyeyes
- tools = list(/obj/item/wirecutters,
- /obj/item/pen)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen)
category = CAT_DECORATIONS
subcategory = CAT_DECORATION
/datum/crafting_recipe/paper_craft/clock
name = "Paper Clock"
result = /obj/item/decorations/sticky_decorations/flammable/paperclock
- tools = list(/obj/item/wirecutters,
- /obj/item/pen)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen)
category = CAT_DECORATIONS
subcategory = CAT_DECORATION
/datum/crafting_recipe/paper_craft/jack_o_lantern
name = "Paper Jack o'Lantern"
result = /obj/item/decorations/sticky_decorations/flammable/jack_o_lantern
- tools = list(/obj/item/wirecutters,
- /obj/item/pen,
- /obj/item/toy/crayon/orange,
- /obj/item/toy/crayon/green)//pen ink is black
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen,
+ /obj/item/toy/crayon/orange,
+ /obj/item/toy/crayon/green)//pen ink is black
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/ghost
name = "Paper Ghost"
result = /obj/item/decorations/sticky_decorations/flammable/ghost
- tools = list(/obj/item/wirecutters,
- /obj/item/pen)//it's white paper why need a white crayon?
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen)//it's white paper why need a white crayon?
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/spider
name = "Paper Spider"
result = /obj/item/decorations/sticky_decorations/flammable/spider
- tools = list(/obj/item/wirecutters,
- /obj/item/pen,
- /obj/item/toy/crayon/red)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen,
+ /obj/item/toy/crayon/red)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/spiderweb
name = "Paper Spiderweb"
result = /obj/item/decorations/sticky_decorations/flammable/spiderweb
- tools = list(/obj/item/wirecutters)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list()
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/skull
name = "Paper Skull"
result = /obj/item/decorations/sticky_decorations/flammable/skull
- tools = list(/obj/item/wirecutters,
- /obj/item/pen)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/skeleton
name = "Paper Skeleton"
result = /obj/item/decorations/sticky_decorations/flammable/skeleton
- tools = list(/obj/item/wirecutters,
- /obj/item/pen)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/cauldron
name = "Paper Cauldron"
result = /obj/item/decorations/sticky_decorations/flammable/cauldron
- tools = list(/obj/item/wirecutters,
- /obj/item/pen)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/snowman
name = "Paper Snowman"
result = /obj/item/decorations/sticky_decorations/flammable/snowman
- tools = list(/obj/item/wirecutters,
- /obj/item/pen,
- /obj/item/toy/crayon/orange)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen,
+ /obj/item/toy/crayon/orange)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/christmas_stocking
name = "Paper Christmas Stocking"
result = /obj/item/decorations/sticky_decorations/flammable/christmas_stocking
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/red)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/red)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/christmas_tree
name = "Paper Christmas Tree"
result = /obj/item/decorations/sticky_decorations/flammable/christmas_tree
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/red,
- /obj/item/toy/crayon/yellow,
- /obj/item/toy/crayon/blue,
- /obj/item/toy/crayon/green)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/red,
+ /obj/item/toy/crayon/yellow,
+ /obj/item/toy/crayon/blue,
+ /obj/item/toy/crayon/green)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/snowflake
name = "Paper Snowflake"
result = /obj/item/decorations/sticky_decorations/flammable/snowflake
- tools = list(/obj/item/wirecutters)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list()
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/candy_cane
name = "Paper Candy Cane"
result = /obj/item/decorations/sticky_decorations/flammable/candy_cane
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/red)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/red)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/mistletoe
name = "Paper Mistletoe"
result = /obj/item/decorations/sticky_decorations/flammable/mistletoe
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/red,
- /obj/item/toy/crayon/green)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/red,
+ /obj/item/toy/crayon/green)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/holly
name = "Paper Holly"
result = /obj/item/decorations/sticky_decorations/flammable/holly
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/red,
- /obj/item/toy/crayon/green)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/red,
+ /obj/item/toy/crayon/green)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
@@ -733,7 +734,8 @@
result = /obj/item/decorations/sticky_decorations/flammable/tinsel
reqs = list(/obj/item/paper = 1,
/obj/item/stack/tape_roll = 2)
- tools = list(/obj/item/wirecutters)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list()
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
@@ -743,8 +745,8 @@
result = /obj/item/decorations/sticky_decorations/flammable/tinsel/red
reqs = list(/obj/item/paper = 1,
/obj/item/stack/tape_roll = 2)
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/red)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/red)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
@@ -754,8 +756,8 @@
result = /obj/item/decorations/sticky_decorations/flammable/tinsel/blue
reqs = list(/obj/item/paper = 1,
/obj/item/stack/tape_roll = 2)
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/blue)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/blue)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
@@ -765,8 +767,8 @@
result = /obj/item/decorations/sticky_decorations/flammable/tinsel/yellow
reqs = list(/obj/item/paper = 1,
/obj/item/stack/tape_roll = 2)
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/yellow)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/yellow)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
@@ -776,8 +778,8 @@
result = /obj/item/decorations/sticky_decorations/flammable/tinsel/purple
reqs = list(/obj/item/paper = 1,
/obj/item/stack/tape_roll = 2)
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/purple)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/purple)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
@@ -787,8 +789,8 @@
result = /obj/item/decorations/sticky_decorations/flammable/tinsel/green
reqs = list(/obj/item/paper = 1,
/obj/item/stack/tape_roll = 2)
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/green)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/green)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
@@ -798,8 +800,8 @@
result = /obj/item/decorations/sticky_decorations/flammable/tinsel/orange
reqs = list(/obj/item/paper = 1,
/obj/item/stack/tape_roll = 2)
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/orange)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/orange)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
@@ -809,8 +811,8 @@
result = /obj/item/decorations/sticky_decorations/flammable/tinsel/black
reqs = list(/obj/item/paper = 1,
/obj/item/stack/tape_roll = 2)
- tools = list(/obj/item/wirecutters,
- /obj/item/pen)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
@@ -820,17 +822,17 @@
result = /obj/item/decorations/sticky_decorations/flammable/tinsel/halloween
reqs = list(/obj/item/paper = 1,
/obj/item/stack/tape_roll = 2)
- tools = list(/obj/item/wirecutters,
- /obj/item/pen,
- /obj/item/toy/crayon/orange)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen,
+ /obj/item/toy/crayon/orange)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/arrowed_heart
name = "Paper Arrowed Heart"
result = /obj/item/decorations/sticky_decorations/flammable/arrowed_heart
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/red)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/red)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
@@ -840,24 +842,24 @@
reqs = list(/obj/item/paper = 1,
/obj/item/stack/tape_roll = 2,
/obj/item/stack/cable_coil = 2)
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/red)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/red)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/four_leaf_clover
name = "Paper Four Leaf Clover"
result = /obj/item/decorations/sticky_decorations/flammable/four_leaf_clover
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/green)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/green)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/pot_of_gold
name = "Paper Pot of Gold"
result = /obj/item/decorations/sticky_decorations/flammable/pot_of_gold
- tools = list(/obj/item/wirecutters,
- /obj/item/pen,
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen,
/obj/item/toy/crayon/red,
/obj/item/toy/crayon/yellow,
/obj/item/toy/crayon/orange,
@@ -871,8 +873,8 @@
name = "Paper Leprechaun Hat"
time = 10
result = /obj/item/decorations/sticky_decorations/flammable/leprechaun_hat
- tools = list(/obj/item/wirecutters,
- /obj/item/pen,
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen,
/obj/item/toy/crayon/yellow,
/obj/item/toy/crayon/green)
category = CAT_DECORATIONS
@@ -881,8 +883,8 @@
/datum/crafting_recipe/paper_craft/easter_bunny
name = "Paper Easter Bunny"
result = /obj/item/decorations/sticky_decorations/flammable/easter_bunny
- tools = list(/obj/item/wirecutters,
- /obj/item/pen,
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/pen,
/obj/item/toy/crayon/blue,
/obj/item/toy/crayon/purple)
category = CAT_DECORATIONS
@@ -891,40 +893,40 @@
/datum/crafting_recipe/paper_craft/easter_egg_blue
name = "Blue Paper Easter Egg"
result = /obj/item/decorations/sticky_decorations/flammable/easter_egg
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/blue)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/blue)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/easter_egg_yellow
name = "Yellow Paper Easter Egg"
result = /obj/item/decorations/sticky_decorations/flammable/easter_egg/yellow
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/yellow)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/yellow)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/easter_egg_red
name = "Red Paper Easter Egg"
result = /obj/item/decorations/sticky_decorations/flammable/easter_egg/red
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/red)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/red)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/easter_egg_purple
name = "Purple Paper Easter Egg"
result = /obj/item/decorations/sticky_decorations/flammable/easter_egg/purple
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/purple)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/purple)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
/datum/crafting_recipe/paper_craft/easter_egg_orange
name = "Orange Paper Easter Egg"
result = /obj/item/decorations/sticky_decorations/flammable/easter_egg/orange
- tools = list(/obj/item/wirecutters,
- /obj/item/toy/crayon/orange)
+ tools = list(TOOL_WIRECUTTER)
+ pathtools = list(/obj/item/toy/crayon/orange)
category = CAT_DECORATIONS
subcategory = CAT_HOLIDAY
@@ -934,7 +936,7 @@
result = /obj/structure/decorative_structures/metal/statue/metal_angel
reqs = list(/obj/item/stack/sheet/metal = 10,
/obj/item/stack/sheet/mineral/gold = 6)
- tools = list(/obj/item/weldingtool)
+ tools = list(TOOL_WELDER)
category = CAT_DECORATIONS
subcategory = CAT_LARGE_DECORATIONS
@@ -945,7 +947,7 @@
reqs = list(/obj/item/stack/sheet/metal = 10,
/obj/item/stack/sheet/mineral/plasma = 3,
/obj/item/stack/sheet/mineral/gold = 8)
- tools = list(/obj/item/weldingtool)
+ tools = list(TOOL_WELDER)
category = CAT_DECORATIONS
subcategory = CAT_LARGE_DECORATIONS
@@ -955,7 +957,7 @@
result = /obj/structure/decorative_structures/metal/statue/sun
reqs = list(/obj/item/stack/sheet/metal = 6,
/obj/item/stack/sheet/mineral/gold = 4)
- tools = list(/obj/item/weldingtool)
+ tools = list(TOOL_WELDER)
category = CAT_DECORATIONS
subcategory = CAT_LARGE_DECORATIONS
@@ -966,7 +968,7 @@
reqs = list(/obj/item/stack/sheet/metal = 6,
/obj/item/stack/sheet/mineral/silver = 6,
/obj/item/stack/sheet/mineral/gold = 4)
- tools = list(/obj/item/weldingtool)
+ tools = list(TOOL_WELDER)
category = CAT_DECORATIONS
subcategory = CAT_LARGE_DECORATIONS
@@ -976,7 +978,7 @@
result = /obj/structure/decorative_structures/metal/statue/tesla
reqs = list(/obj/item/stack/sheet/metal = 4,
/obj/item/stack/sheet/glass = 8)
- tools = list(/obj/item/weldingtool)
+ tools = list(TOOL_WELDER)
category = CAT_DECORATIONS
subcategory = CAT_LARGE_DECORATIONS
@@ -987,7 +989,7 @@
reqs = list(/obj/item/stack/sheet/metal = 8,
/obj/item/stock_parts/cell = 3,
/obj/item/stack/cable_coil = 4)
- tools = list(/obj/item/weldingtool)
+ tools = list(TOOL_WELDER)
category = CAT_DECORATIONS
subcategory = CAT_LARGE_DECORATIONS
@@ -1010,9 +1012,9 @@
/obj/item/stack/rods = 4,
/obj/item/stock_parts/cell = 1,
/obj/item/stack/cable_coil = 4)//thing is a wireframe construct with an electro magnetic hover field
- tools = list(/obj/item/wirecutters,
- /obj/item/pen,
- /obj/item/weldingtool,
+ tools = list(TOOL_WIRECUTTER,
+ TOOL_WELDER)
+ pathtools = list(/obj/item/pen,
/obj/item/toy/crayon/red)
category = CAT_DECORATIONS
subcategory = CAT_LARGE_DECORATIONS
diff --git a/code/modules/events/spider_terror.dm b/code/modules/events/spider_terror.dm
index 1ecf5aa22ca..925051cff11 100644
--- a/code/modules/events/spider_terror.dm
+++ b/code/modules/events/spider_terror.dm
@@ -15,6 +15,10 @@
var/list/vents = list()
for(var/obj/machinery/atmospherics/unary/vent_pump/temp_vent in GLOB.all_vent_pumps)
if(is_station_level(temp_vent.loc.z) && !temp_vent.welded)
+ if(!temp_vent.parent)
+ // Issue happening more often with vents. Log and continue. Delete once solved
+ log_debug("spider_terror/start(), vent has no parent: [temp_vent], qdeled: [QDELETED(temp_vent)], loc: [temp_vent.loc]")
+ continue
if(temp_vent.parent.other_atmosmch.len > 50)
vents += temp_vent
var/spider_type
diff --git a/code/modules/events/traders.dm b/code/modules/events/traders.dm
index 04663f93152..b481bca88eb 100644
--- a/code/modules/events/traders.dm
+++ b/code/modules/events/traders.dm
@@ -18,6 +18,9 @@ var/global/list/unused_trade_stations = list("sol")
return
if(seclevel2num(get_security_level()) >= SEC_LEVEL_RED)
event_announcement.Announce("A trading shuttle from Jupiter Station has been denied docking permission due to the heightened security alert aboard [station_name()].", "Trader Shuttle Docking Request Refused")
+ // if the docking request was refused, fire another major event in 60 seconds
+ var/list/datum/event_container/EC = SSevents.event_containers[EVENT_LEVEL_MAJOR]
+ EC.next_event_time = world.time + (60 * 10)
return
var/list/spawnlocs = list()
diff --git a/code/modules/food_and_drinks/recipes/tablecraft/recipes_table.dm b/code/modules/food_and_drinks/recipes/tablecraft/recipes_table.dm
index a0988951855..2a2ee410522 100644
--- a/code/modules/food_and_drinks/recipes/tablecraft/recipes_table.dm
+++ b/code/modules/food_and_drinks/recipes/tablecraft/recipes_table.dm
@@ -95,7 +95,7 @@
/obj/item/reagent_containers/food/snacks/boiledrice = 1,
/obj/item/reagent_containers/food/snacks/boiled_shrimp = 4,
)
- tools = list(/obj/item/kitchen/sushimat)
+ pathtools = list(/obj/item/kitchen/sushimat)
result = /obj/item/reagent_containers/food/snacks/sliceable/Ebi_maki
category = CAT_FOOD
subcategory = CAT_SUSHI
@@ -116,7 +116,7 @@
/obj/item/reagent_containers/food/snacks/boiledrice = 1,
/obj/item/fish_eggs/salmon = 4,
)
- tools = list(/obj/item/kitchen/sushimat)
+ pathtools = list(/obj/item/kitchen/sushimat)
result = /obj/item/reagent_containers/food/snacks/sliceable/Ikura_maki
category = CAT_FOOD
subcategory = CAT_SUSHI
@@ -137,7 +137,7 @@
/obj/item/reagent_containers/food/snacks/boiledrice = 1,
/obj/item/reagent_containers/food/snacks/fried_tofu = 4,
)
- tools = list(/obj/item/kitchen/sushimat)
+ pathtools = list(/obj/item/kitchen/sushimat)
result = /obj/item/reagent_containers/food/snacks/sliceable/Inari_maki
category = CAT_FOOD
subcategory = CAT_SUSHI
@@ -158,7 +158,7 @@
/obj/item/reagent_containers/food/snacks/boiledrice = 1,
/obj/item/reagent_containers/food/snacks/salmonmeat = 4,
)
- tools = list(/obj/item/kitchen/sushimat)
+ pathtools = list(/obj/item/kitchen/sushimat)
result = /obj/item/reagent_containers/food/snacks/sliceable/Sake_maki
category = CAT_FOOD
subcategory = CAT_SUSHI
@@ -179,7 +179,7 @@
/obj/item/reagent_containers/food/snacks/boiledrice = 1,
/obj/item/reagent_containers/food/snacks/salmonsteak = 4,
)
- tools = list(/obj/item/kitchen/sushimat)
+ pathtools = list(/obj/item/kitchen/sushimat)
result = /obj/item/reagent_containers/food/snacks/sliceable/SmokedSalmon_maki
category = CAT_FOOD
subcategory = CAT_SUSHI
@@ -200,7 +200,7 @@
/obj/item/reagent_containers/food/snacks/boiledrice = 1,
/obj/item/fish_eggs/goldfish = 4,
)
- tools = list(/obj/item/kitchen/sushimat)
+ pathtools = list(/obj/item/kitchen/sushimat)
result = /obj/item/reagent_containers/food/snacks/sliceable/Masago_maki
category = CAT_FOOD
subcategory = CAT_SUSHI
@@ -221,7 +221,7 @@
/obj/item/reagent_containers/food/snacks/boiledrice = 1,
/obj/item/fish_eggs/shark = 4,
)
- tools = list(/obj/item/kitchen/sushimat)
+ pathtools = list(/obj/item/kitchen/sushimat)
result = /obj/item/reagent_containers/food/snacks/sliceable/Tobiko_maki
category = CAT_FOOD
subcategory = CAT_SUSHI
@@ -242,7 +242,7 @@
/obj/item/reagent_containers/food/snacks/sushi_Tobiko = 4,
/obj/item/reagent_containers/food/snacks/egg = 4,
)
- tools = list(/obj/item/kitchen/sushimat)
+ pathtools = list(/obj/item/kitchen/sushimat)
result = /obj/item/reagent_containers/food/snacks/sliceable/TobikoEgg_maki
category = CAT_FOOD
subcategory = CAT_SUSHI
@@ -253,7 +253,7 @@
/obj/item/reagent_containers/food/snacks/sushi_Tobiko = 4,
/obj/item/reagent_containers/food/snacks/egg = 4,
)
- tools = list(/obj/item/kitchen/sushimat)
+ pathtools = list(/obj/item/kitchen/sushimat)
result = /obj/item/reagent_containers/food/snacks/sliceable/TobikoEgg_maki
category = CAT_FOOD
subcategory = CAT_SUSHI
@@ -274,7 +274,7 @@
/obj/item/reagent_containers/food/snacks/boiledrice = 1,
/obj/item/reagent_containers/food/snacks/catfishmeat = 4,
)
- tools = list(/obj/item/kitchen/sushimat)
+ pathtools = list(/obj/item/kitchen/sushimat)
result = /obj/item/reagent_containers/food/snacks/sliceable/Tai_maki
category = CAT_FOOD
subcategory = CAT_SUSHI
diff --git a/code/modules/hydroponics/grown/cannabis.dm b/code/modules/hydroponics/grown/cannabis.dm
index 274a1f1e084..06ba1fc7a66 100644
--- a/code/modules/hydroponics/grown/cannabis.dm
+++ b/code/modules/hydroponics/grown/cannabis.dm
@@ -17,7 +17,7 @@
/obj/item/seeds/cannabis/death,
/obj/item/seeds/cannabis/white,
/obj/item/seeds/cannabis/ultimate)
- reagents_add = list("thc" = 0.15)
+ reagents_add = list("thc" = 0.15, "cbd" = 0.15)
/obj/item/seeds/cannabis/rainbow
@@ -28,7 +28,7 @@
plantname = "Rainbow Weed"
product = /obj/item/reagent_containers/food/snacks/grown/cannabis/rainbow
mutatelist = list()
- reagents_add = list("lsd" = 0.15, "thc" = 0.15)
+ reagents_add = list("lsd" = 0.15, "thc" = 0.15, "cbd" = 0.15)
rarity = 40
/obj/item/seeds/cannabis/death
@@ -39,7 +39,7 @@
plantname = "Deathweed"
product = /obj/item/reagent_containers/food/snacks/grown/cannabis/death
mutatelist = list()
- reagents_add = list("cyanide" = 0.35, "thc" = 0.15)
+ reagents_add = list("cyanide" = 0.35, "thc" = 0.15, "cbd" = 0.15)
rarity = 40
/obj/item/seeds/cannabis/white
@@ -50,7 +50,7 @@
plantname = "Lifeweed"
product = /obj/item/reagent_containers/food/snacks/grown/cannabis/white
mutatelist = list()
- reagents_add = list("omnizine" = 0.35, "thc" = 0.15)
+ reagents_add = list("omnizine" = 0.35, "thc" = 0.15, "cbd" = 0.15)
rarity = 40
@@ -72,6 +72,7 @@
"haloperidol" = 0.15,
"methamphetamine" = 0.15,
"thc" = 0.15,
+ "cbd" = 0.15,
"psilocybin" = 0.15,
"hairgrownium" = 0.15,
"ectoplasm" = 0.15,
diff --git a/code/modules/hydroponics/grown/misc.dm b/code/modules/hydroponics/grown/misc.dm
index 7d494803495..d13b7a11e5b 100644
--- a/code/modules/hydroponics/grown/misc.dm
+++ b/code/modules/hydroponics/grown/misc.dm
@@ -145,6 +145,9 @@
message_admins("[user] ([user.key ? user.key : "no key"]) primed a cherry bomb for detonation at [A] ([user.x], [user.y], [user.z]) (JMP)")
log_game("[user] ([user.key ? user.key : "no key"]) primed a cherry bomb for detonation at [A] ([user.x],[user.y],[user.z]).")
prime()
+ if(iscarbon(user))
+ var/mob/living/carbon/C = user
+ C.throw_mode_on()
/obj/item/reagent_containers/food/snacks/grown/cherry_bomb/deconstruct(disassembled = TRUE)
if(!disassembled)
diff --git a/code/modules/hydroponics/grown/tomato.dm b/code/modules/hydroponics/grown/tomato.dm
index 873b08f151e..6cf56d619d6 100644
--- a/code/modules/hydroponics/grown/tomato.dm
+++ b/code/modules/hydroponics/grown/tomato.dm
@@ -141,7 +141,8 @@
spawn(30)
if(!QDELETED(src))
- var/mob/living/simple_animal/hostile/killertomato/K = new /mob/living/simple_animal/hostile/killertomato(get_turf(loc))
+ var/turf/T = get_turf(user)
+ var/mob/living/simple_animal/hostile/killertomato/K = new /mob/living/simple_animal/hostile/killertomato(T)
K.maxHealth += round(seed.endurance / 3)
K.melee_damage_lower += round(seed.potency / 10)
K.melee_damage_upper += round(seed.potency / 10)
@@ -150,4 +151,6 @@
K.visible_message("The Killer Tomato growls as it suddenly awakens.")
if(user)
user.unEquip(src)
+ message_admins("[key_name_admin(user)] released a killer tomato at [ADMIN_COORDJMP(T)]")
+ log_game("[key_name(user)] released a killer tomato at [COORD(T)]")
qdel(src)
diff --git a/code/modules/mob/emote.dm b/code/modules/mob/emote.dm
index 304bdc419a2..57232d74f44 100644
--- a/code/modules/mob/emote.dm
+++ b/code/modules/mob/emote.dm
@@ -30,12 +30,10 @@
// All mobs should have custom emote, really..
/mob/proc/custom_emote(var/m_type=EMOTE_VISUAL,var/message = null)
-
if(stat || !use_me && usr == src)
if(usr)
to_chat(usr, "You are unable to emote.")
return
-
var/muzzled = is_muzzled()
if(muzzled)
var/obj/item/clothing/mask/muzzle/M = wear_mask
@@ -57,7 +55,10 @@
if(message)
log_emote(message, src)
-
+ if(isliving(src)) //isliving because these are defined on the mob/living level not mob
+ var/mob/living/L = src
+ L.say_log += "EMOTE: [input]" //say log too so it is easier on admins instead of having to merge the two with timestamps etc
+ L.emote_log += input //emote only log if an admin wants to search just for emotes they don't have to sift through the say
// Hearing gasp and such every five seconds is not good emotes were not global for a reason.
// Maybe some people are okay with that.
for(var/mob/M in GLOB.player_list)
diff --git a/code/modules/mob/living/carbon/alien/alien_defense.dm b/code/modules/mob/living/carbon/alien/alien_defense.dm
index f4832e20384..04924d4b310 100644
--- a/code/modules/mob/living/carbon/alien/alien_defense.dm
+++ b/code/modules/mob/living/carbon/alien/alien_defense.dm
@@ -79,5 +79,5 @@ In all, this is a lot like the monkey code. /N
if(M.is_adult)
damage = rand(10, 40)
adjustBruteLoss(damage)
- add_attack_logs(src, M, "Slime'd for [damage] damage")
+ add_attack_logs(M, src, "Slime'd for [damage] damage")
updatehealth("slime attack")
\ No newline at end of file
diff --git a/code/modules/mob/living/carbon/human/appearance.dm b/code/modules/mob/living/carbon/human/appearance.dm
index 146d107daba..a0fd10e0610 100644
--- a/code/modules/mob/living/carbon/human/appearance.dm
+++ b/code/modules/mob/living/carbon/human/appearance.dm
@@ -323,7 +323,7 @@
valid_species += current_species_name
- return valid_species
+ return sortTim(valid_species, /proc/cmp_text_asc)
/mob/living/carbon/human/proc/generate_valid_hairstyles()
var/list/valid_hairstyles = new()
@@ -351,7 +351,7 @@
if(H.dna.species.name in S.species_allowed) //If the user's head is of a species the hairstyle allows, add it to the list.
valid_hairstyles += hairstyle
- return valid_hairstyles
+ return sortTim(valid_hairstyles, /proc/cmp_text_asc)
/mob/living/carbon/human/proc/generate_valid_facial_hairstyles()
var/list/valid_facial_hairstyles = new()
@@ -380,7 +380,7 @@
if(H.dna.species.name in S.species_allowed) //If the user's head is of a species the facial hair style allows, add it to the list.
valid_facial_hairstyles += facialhairstyle
- return valid_facial_hairstyles
+ return sortTim(valid_facial_hairstyles, /proc/cmp_text_asc)
/mob/living/carbon/human/proc/generate_valid_head_accessories()
var/list/valid_head_accessories = new()
@@ -395,7 +395,7 @@
continue
valid_head_accessories += head_accessory
- return valid_head_accessories
+ return sortTim(valid_head_accessories, /proc/cmp_text_asc)
/mob/living/carbon/human/proc/generate_valid_markings(var/location = "body")
var/list/valid_markings = new()
@@ -433,7 +433,7 @@
continue
valid_markings += marking
- return valid_markings
+ return sortTim(valid_markings, /proc/cmp_text_asc)
/mob/living/carbon/human/proc/generate_valid_body_accessories()
var/list/valid_body_accessories = new()
@@ -448,7 +448,7 @@
if(dna.species.name in A.allowed_species) //If the user is not of a species the body accessory style allows, skip it. Otherwise, add it to the list.
valid_body_accessories += B
- return valid_body_accessories
+ return sortTim(valid_body_accessories, /proc/cmp_text_asc)
/mob/living/carbon/human/proc/generate_valid_alt_heads()
var/list/valid_alt_heads = list()
@@ -463,7 +463,7 @@
valid_alt_heads += alternate_head
- return valid_alt_heads
+ return sortTim(valid_alt_heads, /proc/cmp_text_asc)
/mob/living/carbon/human/proc/scramble_appearance()
scramble(1, src, 100)
diff --git a/code/modules/mob/living/carbon/human/emote.dm b/code/modules/mob/living/carbon/human/emote.dm
index 01c2d773d51..51088f66457 100644
--- a/code/modules/mob/living/carbon/human/emote.dm
+++ b/code/modules/mob/living/carbon/human/emote.dm
@@ -585,6 +585,14 @@
message = "[src] makes a weak noise"
m_type = 2
+ if("hsigh", "hsighs")
+ if(!muzzled)
+ message = "[src] sighs contentedly."
+ m_type = 2
+ else
+ message = "[src] makes a [pick("chill", "relaxed")] noise"
+ m_type = 2
+
if("laugh", "laughs")
var/M = handle_emote_param(param)
if(miming)
diff --git a/code/modules/mob/living/carbon/human/human.dm b/code/modules/mob/living/carbon/human/human.dm
index 5da0296ccbf..2c00a4f91bd 100644
--- a/code/modules/mob/living/carbon/human/human.dm
+++ b/code/modules/mob/living/carbon/human/human.dm
@@ -454,12 +454,6 @@
popup.set_content(dat)
popup.open()
-
-/mob/living/carbon/human/Crossed(atom/movable/AM, oldloc)
- var/mob/living/simple_animal/bot/mulebot/MB = AM
- if(istype(MB))
- MB.RunOver(src)
-
// Get rank from ID, ID inside PDA, PDA, ID in wallet, etc.
/mob/living/carbon/human/proc/get_authentification_rank(var/if_no_id = "No id", var/if_no_job = "No job")
var/obj/item/pda/pda = wear_id
diff --git a/code/modules/mob/living/carbon/human/life.dm b/code/modules/mob/living/carbon/human/life.dm
index 2643d1f3102..93e7ff54ec6 100644
--- a/code/modules/mob/living/carbon/human/life.dm
+++ b/code/modules/mob/living/carbon/human/life.dm
@@ -542,7 +542,7 @@
if(COLDRES in mutations)
return 1 //Fully protected from the cold.
- temperature = max(temperature, 2.7) //There is an occasional bug where the temperature is miscalculated in ares with a small amount of gas on them, so this is necessary to ensure that that bug does not affect this calculation. Space's temperature is 2.7K and most suits that are intended to protect against any cold, protect down to 2.0K.
+ temperature = max(temperature, TCMB) //There is an occasional bug where the temperature is miscalculated in areas with a small amount of gas on them, so this is necessary to ensure that that bug does not affect this calculation. Space's temperature is 2.7K and most suits that are intended to protect against any cold, protect down to 2.0K.
var/thermal_protection_flags = get_cold_protection_flags(temperature)
var/thermal_protection = 0.0
diff --git a/code/modules/mob/living/carbon/human/species/plasmaman.dm b/code/modules/mob/living/carbon/human/species/plasmaman.dm
index d925e2ef1d9..c30c8176fdc 100644
--- a/code/modules/mob/living/carbon/human/species/plasmaman.dm
+++ b/code/modules/mob/living/carbon/human/species/plasmaman.dm
@@ -165,7 +165,7 @@
..()
/datum/species/plasmaman/handle_reagents(mob/living/carbon/human/H, datum/reagent/R)
- if(R.id == "plasma")
+ if(R.id == "plasma" || R.id == "plasma_dust")
H.adjustBruteLoss(-0.5*REAGENTS_EFFECT_MULTIPLIER)
H.adjustFireLoss(-0.5*REAGENTS_EFFECT_MULTIPLIER)
H.adjustPlasma(20)
diff --git a/code/modules/mob/living/living.dm b/code/modules/mob/living/living.dm
index 8ab2b44865f..b35556903f2 100644
--- a/code/modules/mob/living/living.dm
+++ b/code/modules/mob/living/living.dm
@@ -404,6 +404,7 @@
if(C.reagents)
C.reagents.clear_reagents()
QDEL_LIST(C.reagents.addiction_list)
+ C.reagents.addiction_threshold_accumulated.Cut()
// rejuvenate: Called by `revive` to get the mob into a revivable state
// the admin "rejuvenate" command calls `revive`, not this proc.
diff --git a/code/modules/mob/living/living_defense.dm b/code/modules/mob/living/living_defense.dm
index 67ea6e7f887..2b148a6a0a2 100644
--- a/code/modules/mob/living/living_defense.dm
+++ b/code/modules/mob/living/living_defense.dm
@@ -296,7 +296,7 @@
return FALSE
if(stat != DEAD)
- add_attack_logs(src, M, "Slime'd")
+ add_attack_logs(M, src, "Slime'd")
M.do_attack_animation(src)
visible_message("\The [M.name] glomps [src]!", "\The [M.name] glomps you!")
return TRUE
diff --git a/code/modules/mob/living/living_defines.dm b/code/modules/mob/living/living_defines.dm
index 74a51a771ac..8f5ed797b6c 100644
--- a/code/modules/mob/living/living_defines.dm
+++ b/code/modules/mob/living/living_defines.dm
@@ -59,6 +59,7 @@
var/tesla_ignore = FALSE
var/list/say_log = list() //a log of what we've said, plain text, no spans or junk, essentially just each individual "message"
+ var/list/emote_log = list() //like say_log but for emotes
var/list/recent_tastes = list()
var/blood_volume = 0 //how much blood the mob has
diff --git a/code/modules/mob/living/silicon/robot/component.dm b/code/modules/mob/living/silicon/robot/component.dm
index 0750e4ea3ed..26b5683d1a3 100644
--- a/code/modules/mob/living/silicon/robot/component.dm
+++ b/code/modules/mob/living/silicon/robot/component.dm
@@ -10,15 +10,11 @@
var/max_damage = 30
var/component_disabled = 0
var/mob/living/silicon/robot/owner
-
-// The actual device object that has to be installed for this.
-/datum/robot_component/var/external_type = null
-
-// The wrapped device(e.g. radio), only set if external_type isn't null
-/datum/robot_component/var/obj/item/wrapped = null
+ var/external_type = null // The actual device object that has to be installed for this.
+ var/obj/item/wrapped = null // The wrapped device(e.g. radio), only set if external_type isn't null
/datum/robot_component/New(mob/living/silicon/robot/R)
- src.owner = R
+ owner = R
/datum/robot_component/proc/install()
go_online()
@@ -109,6 +105,13 @@
name = "power cell"
max_damage = 50
+/datum/robot_component/cell/New(mob/living/silicon/robot/R)
+ . = ..()
+ // sets `external_type` to the borg's currently installed cell type
+ if(owner.cell)
+ var/obj/item/stock_parts/cell/C = owner.cell
+ external_type = C.type
+
/datum/robot_component/cell/is_powered()
return ..() && owner.cell
diff --git a/code/modules/mob/living/silicon/robot/robot.dm b/code/modules/mob/living/silicon/robot/robot.dm
index e148a4fe75a..6c399a7161f 100644
--- a/code/modules/mob/living/silicon/robot/robot.dm
+++ b/code/modules/mob/living/silicon/robot/robot.dm
@@ -142,6 +142,9 @@ var/list/robot_verbs_default = list(
mmi = new /obj/item/mmi/robotic_brain(src) //Give the borg an MMI if he spawns without for some reason. (probably not the correct way to spawn a robotic brain, but it works)
mmi.icon_state = "boris"
+ if(!cell) // Make sure a new cell gets created *before* executing initialize_components(). The cell component needs an existing cell for it to get set up properly
+ cell = new /obj/item/stock_parts/cell/high(src)
+
initialize_components()
//if(!unfinished)
// Create all the robot parts.
@@ -150,9 +153,6 @@ var/list/robot_verbs_default = list(
C.installed = 1
C.wrapped = new C.external_type
- if(!cell)
- cell = new /obj/item/stock_parts/cell/high(src)
-
..()
add_robot_verbs()
@@ -602,7 +602,8 @@ var/list/robot_verbs_default = list(
/mob/living/silicon/robot/attackby(obj/item/W, mob/user, params)
- if(opened) // Are they trying to insert something?
+ // Check if the user is trying to insert another component like a radio, actuator, armor etc.
+ if(istype(W, /obj/item/robot_parts/robot_component) && opened)
for(var/V in components)
var/datum/robot_component/C = components[V]
if(!C.installed && istype(W, C.external_type))
@@ -637,7 +638,7 @@ var/list/robot_verbs_default = list(
user.visible_message("\The [user] fixes some of the burnt wires on \the [src] with \the [coil].")
else if(istype(W, /obj/item/stock_parts/cell) && opened) // trying to put a cell inside
- var/datum/robot_component/C = components["power cell"]
+ var/datum/robot_component/cell/C = components["power cell"]
if(wiresexposed)
to_chat(user, "Close the panel first.")
else if(cell)
@@ -651,6 +652,7 @@ var/list/robot_verbs_default = list(
C.installed = 1
C.wrapped = W
C.install()
+ C.external_type = W.type // Update the cell component's `external_type` to the path of new cell
//This will mean that removing and replacing a power cell will repair the mount, but I don't care at this point. ~Z
C.brute_damage = 0
C.electronics_damage = 0
@@ -1419,6 +1421,8 @@ var/list/robot_verbs_default = list(
burn = borked_part.electronics_damage
borked_part.installed = 1
borked_part.wrapped = new borked_part.external_type
+ if(ispath(borked_part.external_type, /obj/item/stock_parts/cell)) // is the broken part a cell?
+ cell = new borked_part.external_type // borgs that have their cell destroyed have their `cell` var set to null. we need create a new cell for them based on their old cell type.
borked_part.heal_damage(brute,burn)
borked_part.install()
diff --git a/code/modules/mob/living/simple_animal/bot/mulebot.dm b/code/modules/mob/living/simple_animal/bot/mulebot.dm
index 2c8e56f3fbe..83c038cc125 100644
--- a/code/modules/mob/living/simple_animal/bot/mulebot.dm
+++ b/code/modules/mob/living/simple_animal/bot/mulebot.dm
@@ -63,6 +63,7 @@
mulebot_count++
set_suffix(suffix ? suffix : "#[mulebot_count]")
+ RegisterSignal(src, COMSIG_CROSSED_MOVABLE, .proc/human_squish_check)
/mob/living/simple_animal/bot/mulebot/Destroy()
unload(0)
@@ -866,6 +867,11 @@
else
..()
+/mob/living/simple_animal/bot/mulebot/proc/human_squish_check(src, atom/movable/AM)
+ if(!ishuman(AM))
+ return
+ RunOver(AM)
+
#undef SIGH
#undef ANNOYED
#undef DELIGHT
diff --git a/code/modules/paperwork/paper.dm b/code/modules/paperwork/paper.dm
index 3f8924232e7..75d6d9084ca 100644
--- a/code/modules/paperwork/paper.dm
+++ b/code/modules/paperwork/paper.dm
@@ -80,7 +80,7 @@
else
data = "[infolinks ? info_links : info]
[stamps]"
if(view)
- var/datum/browser/popup = new(user, name, , paper_width, paper_height)
+ var/datum/browser/popup = new(user, "Paper[UID()]", , paper_width, paper_height)
popup.stylesheets = list()
popup.set_content(data)
if(!stars)
diff --git a/code/modules/paperwork/paper_bundle.dm b/code/modules/paperwork/paper_bundle.dm
index ecc26ba0cff..06bd0ec25c6 100644
--- a/code/modules/paperwork/paper_bundle.dm
+++ b/code/modules/paperwork/paper_bundle.dm
@@ -63,13 +63,13 @@
qdel(W)
else
if(istype(W, /obj/item/pen) || istype(W, /obj/item/toy/crayon))
- usr << browse("", "window=[name]") //Closes the dialog
+ usr << browse("", "window=PaperBundle[UID()]") //Closes the dialog
P = src[page]
P.attackby(W, user, params)
update_icon()
- if(winget(usr, "[name]", "is-visible") == "true") // NOT MY FAULT IT IS A BUILT IN PROC PLEASE DO NOT HIT ME
+ if(winget(usr, "PaperBundle[UID()]", "is-visible") == "true") // NOT MY FAULT IT IS A BUILT IN PROC PLEASE DO NOT HIT ME
attack_self(usr) //Update the browsed page.
add_fingerprint(usr)
return
@@ -125,7 +125,7 @@
if(istype(src[page], /obj/item/paper))
var/obj/item/paper/P = W
dat += P.show_content(usr, view = 0)
- usr << browse(dat, "window=[name]")
+ usr << browse(dat, "window=PaperBundle[UID()]")
else if(istype(src[page], /obj/item/photo))
var/obj/item/photo/P = W
usr << browse_rsc(P.img, "tmp_photo.png")
@@ -133,7 +133,7 @@
+ "" \
+ " 
Written on the back:
[P.scribble]" : ""]"\
- + "