migrate all /obj/item from /New() to /Initialize() (#31232)

* migrate all /obj/item from /New() to /Initialize()

* move GLOB.chemical_reagents_list creation to /world/New()

* review

* oops

* autodoc a smart var
This commit is contained in:
Toastical
2026-01-28 19:44:32 +00:00
committed by GitHub
parent a0ed4b0066
commit 4c74b78a18
89 changed files with 321 additions and 362 deletions
+10 -12
View File
@@ -24,8 +24,17 @@
new_attack_chain = TRUE
/obj/item/screwdriver/Initialize(mapload)
/obj/item/screwdriver/Initialize(mapload, param_color = null)
. = ..()
if(random_color)
if(!param_color)
param_color = pick("red", "blue", "pink", "brown", "green", "cyan", "yellow")
icon_state = "screwdriver_[param_color]"
belt_icon = "screwdriver_[param_color]"
if(prob(75))
pixel_y = rand(0, 16)
AddComponent(/datum/component/surgery_initiator/robo)
RegisterSignal(src, COMSIG_ATTACK, PROC_REF(on_attack))
RegisterSignal(src, COMSIG_BIT_ATTACH, PROC_REF(add_bit))
@@ -42,17 +51,6 @@
user.visible_message(SPAN_SUICIDE("[user] is stabbing [src] into [user.p_their()] [pick("temple", "heart")]! It looks like [user.p_theyre()] trying to commit suicide!"))
return BRUTELOSS
/obj/item/screwdriver/New(loc, param_color = null)
..()
if(random_color)
if(!param_color)
param_color = pick("red","blue","pink","brown","green","cyan","yellow")
icon_state = "screwdriver_[param_color]"
belt_icon = "screwdriver_[param_color]"
if(prob(75))
src.pixel_y = rand(0, 16)
/obj/item/screwdriver/proc/on_attack(datum/source, mob/living/carbon/target, mob/living/user)
if(!istype(target) || user.a_intent == INTENT_HELP)
return
+3 -6
View File
@@ -24,18 +24,15 @@
new_attack_chain = TRUE
/obj/item/wirecutters/Initialize(mapload)
/obj/item/wirecutters/Initialize(mapload, param_color = null)
. = ..()
RegisterSignal(src, COMSIG_BIT_ATTACH, PROC_REF(add_bit))
RegisterSignal(src, COMSIG_CLICK_ALT, PROC_REF(remove_bit))
/obj/item/wirecutters/New(loc, param_color = null)
..()
if(random_color)
if(!param_color)
param_color = pick("yellow", "red")
belt_icon = "wirecutters_[param_color]"
icon_state = "cutters_[param_color]"
RegisterSignal(src, COMSIG_BIT_ATTACH, PROC_REF(add_bit))
RegisterSignal(src, COMSIG_CLICK_ALT, PROC_REF(remove_bit))
/obj/item/wirecutters/interact_with_atom(atom/target, mob/living/user, list/modifiers)
var/mob/living/carbon/mob = target