mirror of
https://github.com/ParadiseSS13/Paradise.git
synced 2026-08-27 14:07:51 +01:00
Attack chain, initial setup. (pull *immediately* for *any* TM issues) (#26834)
* refactor: Attack chain, initial setup. * migrate curtain to make dreamchecker happy * update thurible * don't call attacked_by separately for legacy attack chain * remove duplicate proc * condense similar code, put allowances for legacy code in new procs * update docs, include diagram source * add comment on how to update diagram * fix admonition * mindflayer updates * remove commented out code * clarify all steps * after_attack should be overridable * whoops * retrofit recent changes * duh, can't restrict this yet because of tool_acts * i hate ore bags with the fire of a thousand suns * return correct value for object attack logic * Various cleanups. We don't want to attempt to pull stuff out of `/obj/item/attackby`, because those pieces are part of the related objects' migrations, not `/obj/item` itself. Attempting to do this causes knockon effects where things expected to call e.g. `/obj/item/storage/attackby` in the call chain were not ferried over to the new item interaction code, because the related objects hadn't actually been migrated over yet. I've used refactoring /obj/vehicle as the example for migrating `attackby` methods instead. * simplify some argument names * fuck it * make it do the thing * Rename CI module call * Prove that CI works * improve test output * aaand fix it again * fix curtain tool interactions * fix compile error * fix compile error * Better docs, introduce migration plan tool.
This commit is contained in:
@@ -54,6 +54,7 @@ jobs:
|
||||
python tools/ci/no_duplicate_definitions.py
|
||||
python -m tools.ci.check_icon_conflicts
|
||||
python -m tools.ci.check_icon_dupenames
|
||||
python -m tools.ci.check_legacy_attack_chain
|
||||
python -m tools.maplint.source --github
|
||||
|
||||
- name: Run DreamChecker
|
||||
@@ -95,7 +96,14 @@ jobs:
|
||||
strategy:
|
||||
fail-fast: false # Let all map tests run to completion
|
||||
matrix:
|
||||
maptype: ['/datum/map/boxstation', '/datum/map/deltastation', '/datum/map/metastation', '/datum/map/cerestation', '/datum/map/emeraldstation']
|
||||
maptype:
|
||||
[
|
||||
'/datum/map/boxstation',
|
||||
'/datum/map/deltastation',
|
||||
'/datum/map/metastation',
|
||||
'/datum/map/cerestation',
|
||||
'/datum/map/emeraldstation',
|
||||
]
|
||||
byondtype: ['STABLE']
|
||||
services:
|
||||
mariadb:
|
||||
|
||||
@@ -15,7 +15,7 @@ jobs:
|
||||
|
||||
- name: Build docs
|
||||
run: |
|
||||
python -m pip install mkdocs==1.6.0 mkdocs-material[imaging]==9.5.31 mkdocs-github-admonitions-plugin==0.0.2
|
||||
python -m pip install mkdocs==1.6.0 mkdocs-material[imaging]==9.5.31 mkdocs-github-admonitions-plugin==0.0.2 mkdocs-glightbox==0.4.0
|
||||
python -m mkdocs build
|
||||
|
||||
- name: Deploy docs
|
||||
|
||||
Reference in New Issue
Block a user