Attack chain, initial setup. (pull *immediately* for *any* TM issues) (#26834)

* refactor: Attack chain, initial setup.

* migrate curtain to make dreamchecker happy

* update thurible

* don't call attacked_by separately for legacy attack chain

* remove duplicate proc

* condense similar code, put allowances for legacy code in new procs

* update docs, include diagram source

* add comment on how to update diagram

* fix admonition

* mindflayer updates

* remove commented out code

* clarify all steps

* after_attack should be overridable

* whoops

* retrofit recent changes

* duh, can't restrict this yet because of tool_acts

* i hate ore bags with the fire of a thousand suns

* return correct value for object attack logic

* Various cleanups.

We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.

I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.

* simplify some argument names

* fuck it

* make it do the thing

* Rename CI module call

* Prove that CI works

* improve test output

* aaand fix it again

* fix curtain tool interactions

* fix compile error

* fix compile error

* Better docs, introduce migration plan tool.
This commit is contained in:
warriorstar-orion
2024-12-02 23:36:36 +00:00
committed by GitHub
parent e9e16645e1
commit 525c68d617
724 changed files with 4266 additions and 1862 deletions
+1 -1
View File
@@ -31,7 +31,7 @@
var/lz_dir = 1
/obj/item/assault_pod/attack_self(mob/living/user)
/obj/item/assault_pod/attack_self__legacy__attackchain(mob/living/user)
var/target_area
target_area = tgui_input_list(user, "Area to land", "Select a Landing Zone", SSmapping.teleportlocs)
if(!target_area)
+1 -1
View File
@@ -13,7 +13,7 @@
var/plural = count > 1
. += "There [plural ? "are" : "is"] [count] use[plural ? "s" : ""] left."
/obj/item/whiteship_port_generator/attack_self(mob/living/user)
/obj/item/whiteship_port_generator/attack_self__legacy__attackchain(mob/living/user)
if(is_station_level(user.z))
log_admin("[key_name(user)] attempted to create a whiteship dock in the station's sector at [COORD(user)].")
to_chat(user, "<span class='notice'>New docking areas cannot be designated within the station's sector!</span>")
+1 -1
View File
@@ -36,7 +36,7 @@
if(hijack_announce)
. += "<span class='warning'>It is probably best to fortify your position as to be uninterrupted during the attempt, given the automatic announcements...</span>"
/obj/machinery/computer/emergency_shuttle/attackby(obj/item/card/id/W, mob/user, params)
/obj/machinery/computer/emergency_shuttle/attackby__legacy__attackchain(obj/item/card/id/W, mob/user, params)
if(stat & (BROKEN|NOPOWER))
return
if(!istype(W, /obj/item/card/id))
@@ -22,7 +22,7 @@
playsound(T, "sparks", 50, TRUE, SHORT_RANGE_SOUND_EXTRARANGE)
return TRUE
/obj/item/lance_docking_generator/attack_self(mob/living/user)
/obj/item/lance_docking_generator/attack_self__legacy__attackchain(mob/living/user)
if(!is_station_level(user.z))
to_chat(user, "<span class='warning'>You'll want this to dock on the station.</span>")
return