From 46fb684c0be834d95b6fd2d1dd315bc17917a4af Mon Sep 17 00:00:00 2001 From: SkyMarshal Date: Mon, 9 Jan 2012 09:58:33 -0700 Subject: [PATCH 1/2] Bugfix for chem grenades and Disposals. --- code/modules/chemical/Chemistry-Tools.dm | 3 ++- code/modules/recycling/disposal.dm | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/code/modules/chemical/Chemistry-Tools.dm b/code/modules/chemical/Chemistry-Tools.dm index 4cca4ed0ff7..05ff3cba25f 100644 --- a/code/modules/chemical/Chemistry-Tools.dm +++ b/code/modules/chemical/Chemistry-Tools.dm @@ -172,7 +172,8 @@ afterattack(atom/target as mob|obj|turf|area, mob/user as mob) - if (istype(target, /obj/item/weapon/storage || istype(target, /obj/item/weapon/gun/grenadelauncher) || istype(target, /obj/structure/table))) return ..() + if (istype(target, /obj/item/weapon/storage) || istype(target, /obj/item/clothing/suit/storage) || istype(target, /obj/item/weapon/gun/grenadelauncher) || istype(target, /obj/structure/table)) + return ..() if (!src.state && stage == 2 && !crit_fail) user << "\red You prime the grenade! 3 seconds!" message_admins("[key_name_admin(user)] used a chemistry grenade ([src.name]).") diff --git a/code/modules/recycling/disposal.dm b/code/modules/recycling/disposal.dm index 666ba1f230f..d239fc17a21 100644 --- a/code/modules/recycling/disposal.dm +++ b/code/modules/recycling/disposal.dm @@ -972,6 +972,8 @@ for(var/i, i <= backType.len, i++) if(sortTag == src.backType[i]) return negdir + else if (!sortTag && mailsort) + return sortdir else if (!sortTag && !mailsort) return posdir @@ -982,7 +984,7 @@ if(sortTag == src.sortType[i]) issort = 1 - if(issort || ((!sortTag || ismail) && mailsort)) //if destination matches filtered type... + if(issort) //if destination matches filtered type... return sortdir // exit through sortdirection else return posdir From e455f46cfd179199a16e04e863dd5ae39700c5fd Mon Sep 17 00:00:00 2001 From: SkyMarshal Date: Mon, 9 Jan 2012 10:08:11 -0700 Subject: [PATCH 2/2] More bugfixing --- code/modules/recycling/disposal.dm | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/code/modules/recycling/disposal.dm b/code/modules/recycling/disposal.dm index d239fc17a21..c651f743b1a 100644 --- a/code/modules/recycling/disposal.dm +++ b/code/modules/recycling/disposal.dm @@ -502,7 +502,6 @@ // now everything inside the disposal gets put into the holder // note AM since can contain mobs or objs - var/tagOverride = 0 for(var/atom/movable/AM in D) AM.loc = src /*if(istype(AM, /mob/living/carbon/human)) @@ -519,10 +518,8 @@ else if (!src.destinationTag) src.destinationTag = null else if (istype(AM, /mob)) //If there is a mob somewhere in there.... - tagOverride = 1 - if(tagOverride) - if(prob(25)) - src.destinationTag = null //Then 50% chance of going to the mail room! + if(prob(10)) + src.destinationTag = "Mail Office" // start the movement process @@ -554,7 +551,7 @@ // if(!(count--)) tomail = 1 //So loops end up in the mail room. - destinationTag = null + destinationTag = "Mail Office" return