From 56f78b93776f62dcffc388e12e68b5f1b1654322 Mon Sep 17 00:00:00 2001 From: Burzah <116982774+Burzah@users.noreply.github.com> Date: Mon, 13 Jan 2025 14:04:46 -0700 Subject: [PATCH] [TM FIRST] 516 Prep/Fixes regarding hrefs (#27960) * To be TM'd * mob dropdown fix * Converts the remaining missing hrefs --- code/datums/datumvars.dm | 30 +++++++++++++++--------------- code/game/atoms.dm | 12 ++++++------ code/game/atoms_movable.dm | 4 ++-- code/game/objects/objs.dm | 8 ++++---- code/modules/mob/mob.dm | 38 +++++++++++++++++++------------------- 5 files changed, 46 insertions(+), 46 deletions(-) diff --git a/code/datums/datumvars.dm b/code/datums/datumvars.dm index eca1b01720f..e0825b725e7 100644 --- a/code/datums/datumvars.dm +++ b/code/datums/datumvars.dm @@ -83,21 +83,21 @@ /datum/proc/vv_get_dropdown() . = list() . += "---" - .["Call Proc"] = "?_src_=vars;proc_call=[UID()]" - .["Mark Object"] = "?_src_=vars;mark_object=[UID()]" - .["Jump to Object"] = "?_src_=vars;jump_to=[UID()]" - .["Delete"] = "?_src_=vars;delete=[UID()]" - .["Modify Traits"] = "?_src_=vars;traitmod=[UID()]" + .["Call Proc"] = "byond://?_src_=vars;proc_call=[UID()]" + .["Mark Object"] = "byond://?_src_=vars;mark_object=[UID()]" + .["Jump to Object"] = "byond://?_src_=vars;jump_to=[UID()]" + .["Delete"] = "byond://?_src_=vars;delete=[UID()]" + .["Modify Traits"] = "byond://?_src_=vars;traitmod=[UID()]" . += "---" /client/vv_get_dropdown() . = list() - .["Manipulate Colour Matrix"] = "?_src_=vars;manipcolours=[UID()]" + .["Manipulate Colour Matrix"] = "byond://?_src_=vars;manipcolours=[UID()]" . += "---" - .["Call Proc"] = "?_src_=vars;proc_call=[UID()]" - .["Mark Object"] = "?_src_=vars;mark_object=[UID()]" - .["Delete"] = "?_src_=vars;delete=[UID()]" - .["Modify Traits"] = "?_src_=vars;traitmod=[UID()]" + .["Call Proc"] = "byond://?_src_=vars;proc_call=[UID()]" + .["Mark Object"] = "byond://?_src_=vars;mark_object=[UID()]" + .["Delete"] = "byond://?_src_=vars;delete=[UID()]" + .["Modify Traits"] = "byond://?_src_=vars;traitmod=[UID()]" . += "---" /client/proc/debug_variables(datum/D in world) @@ -204,11 +204,11 @@ if(islist) dropdownoptions = list( "---", - "Add Item" = "?_src_=vars;listadd=[refid]", - "Remove Nulls" = "?_src_=vars;listnulls=[refid]", - "Remove Dupes" = "?_src_=vars;listdupes=[refid]", - "Set len" = "?_src_=vars;listlen=[refid]", - "Shuffle" = "?_src_=vars;listshuffle=[refid]" + "Add Item" = "byond://?_src_=vars;listadd=[refid]", + "Remove Nulls" = "byond://?_src_=vars;listnulls=[refid]", + "Remove Dupes" = "byond://?_src_=vars;listdupes=[refid]", + "Set len" = "byond://?_src_=vars;listlen=[refid]", + "Shuffle" = "byond://?_src_=vars;listshuffle=[refid]" ) else dropdownoptions = D.vv_get_dropdown() diff --git a/code/game/atoms.dm b/code/game/atoms.dm index 2222ad926dd..b11e4567c29 100644 --- a/code/game/atoms.dm +++ b/code/game/atoms.dm @@ -1195,14 +1195,14 @@ GLOBAL_LIST_EMPTY(blood_splatter_icons) /atom/vv_get_dropdown() . = ..() - .["Manipulate Colour Matrix"] = "?_src_=vars;manipcolours=[UID()]" + .["Manipulate Colour Matrix"] = "byond://?_src_=vars;manipcolours=[UID()]" var/turf/curturf = get_turf(src) if(curturf) - .["Jump to turf"] = "?_src_=holder;adminplayerobservecoodjump=1;X=[curturf.x];Y=[curturf.y];Z=[curturf.z]" - .["Add reagent"] = "?_src_=vars;addreagent=[UID()]" - .["Edit reagents"] = "?_src_=vars;editreagents=[UID()]" - .["Trigger explosion"] = "?_src_=vars;explode=[UID()]" - .["Trigger EM pulse"] = "?_src_=vars;emp=[UID()]" + .["Jump to turf"] = "byond://?_src_=holder;adminplayerobservecoodjump=1;X=[curturf.x];Y=[curturf.y];Z=[curturf.z]" + .["Add reagent"] = "byond://?_src_=vars;addreagent=[UID()]" + .["Edit reagents"] = "byond://?_src_=vars;editreagents=[UID()]" + .["Trigger explosion"] = "byond://?_src_=vars;explode=[UID()]" + .["Trigger EM pulse"] = "byond://?_src_=vars;emp=[UID()]" /atom/proc/AllowDrop() return FALSE diff --git a/code/game/atoms_movable.dm b/code/game/atoms_movable.dm index ef79d69f5cc..13e3133e7d9 100644 --- a/code/game/atoms_movable.dm +++ b/code/game/atoms_movable.dm @@ -878,9 +878,9 @@ /atom/movable/vv_get_dropdown() . = ..() if(!GetComponent(/datum/component/deadchat_control)) - .["Give deadchat control"] = "?_src_=vars;grantdeadchatcontrol=[UID()]" + .["Give deadchat control"] = "byond://?_src_=vars;grantdeadchatcontrol=[UID()]" else - .["Remove deadchat control"] = "?_src_=vars;removedeadchatcontrol=[UID()]" + .["Remove deadchat control"] = "byond://?_src_=vars;removedeadchatcontrol=[UID()]" //Update the screentip to reflect what we're hovering over diff --git a/code/game/objects/objs.dm b/code/game/objects/objs.dm index 80f1ee8c36e..635984ca9c5 100644 --- a/code/game/objects/objs.dm +++ b/code/game/objects/objs.dm @@ -238,12 +238,12 @@ /obj/vv_get_dropdown() . = ..() - .["Delete all of type"] = "?_src_=vars;delall=[UID()]" + .["Delete all of type"] = "byond://?_src_=vars;delall=[UID()]" if(!speed_process) - .["Make speed process"] = "?_src_=vars;makespeedy=[UID()]" + .["Make speed process"] = "byond://?_src_=vars;makespeedy=[UID()]" else - .["Make normal process"] = "?_src_=vars;makenormalspeed=[UID()]" - .["Modify armor values"] = "?_src_=vars;modifyarmor=[UID()]" + .["Make normal process"] = "byond://?_src_=vars;makenormalspeed=[UID()]" + .["Modify armor values"] = "byond://?_src_=vars;modifyarmor=[UID()]" /obj/proc/check_uplink_validity() return TRUE diff --git a/code/modules/mob/mob.dm b/code/modules/mob/mob.dm index a99f601e5be..6cc28544343 100644 --- a/code/modules/mob/mob.dm +++ b/code/modules/mob/mob.dm @@ -1180,31 +1180,31 @@ GLOBAL_LIST_INIT(slot_equipment_priority, list( \ /mob/vv_get_dropdown() . = ..() - .["Show player panel"] = "?_src_=vars;mob_player_panel=[UID()]" + .["Show player panel"] = "byond://?_src_=vars;mob_player_panel=[UID()]" - .["Give Spell"] = "?_src_=vars;give_spell=[UID()]" - .["Give Martial Art"] = "?_src_=vars;givemartialart=[UID()]" - .["Give Disease"] = "?_src_=vars;give_disease=[UID()]" - .["Toggle Godmode"] = "?_src_=vars;godmode=[UID()]" - .["Toggle Build Mode"] = "?_src_=vars;build_mode=[UID()]" + .["Give Spell"] = "byond://?_src_=vars;give_spell=[UID()]" + .["Give Martial Art"] = "byond://?_src_=vars;givemartialart=[UID()]" + .["Give Disease"] = "byond://?_src_=vars;give_disease=[UID()]" + .["Toggle Godmode"] = "byond://?_src_=vars;godmode=[UID()]" + .["Toggle Build Mode"] = "byond://?_src_=vars;build_mode=[UID()]" - .["Make 2spooky"] = "?_src_=vars;make_skeleton=[UID()]" - .["Hallucinate"] = "?_src_=vars;hallucinate=[UID()]" + .["Make 2spooky"] = "byond://?_src_=vars;make_skeleton=[UID()]" + .["Hallucinate"] = "byond://?_src_=vars;hallucinate=[UID()]" - .["Assume Direct Control"] = "?_src_=vars;direct_control=[UID()]" - .["Offer Control to Ghosts"] = "?_src_=vars;offer_control=[UID()]" - .["Drop Everything"] = "?_src_=vars;drop_everything=[UID()]" + .["Assume Direct Control"] = "byond://?_src_=vars;direct_control=[UID()]" + .["Offer Control to Ghosts"] = "byond://?_src_=vars;offer_control=[UID()]" + .["Drop Everything"] = "byond://?_src_=vars;drop_everything=[UID()]" - .["Regenerate Icons"] = "?_src_=vars;regenerateicons=[UID()]" - .["Add Language"] = "?_src_=vars;addlanguage=[UID()]" - .["Remove Language"] = "?_src_=vars;remlanguage=[UID()]" - .["Add Organ"] = "?_src_=vars;addorgan=[UID()]" - .["Remove Organ"] = "?_src_=vars;remorgan=[UID()]" + .["Regenerate Icons"] = "byond://?_src_=vars;regenerateicons=[UID()]" + .["Add Language"] = "byond://?_src_=vars;addlanguage=[UID()]" + .["Remove Language"] = "byond://?_src_=vars;remlanguage=[UID()]" + .["Add Organ"] = "byond://?_src_=vars;addorgan=[UID()]" + .["Remove Organ"] = "byond://?_src_=vars;remorgan=[UID()]" - .["Add Verb"] = "?_src_=vars;addverb=[UID()]" - .["Remove Verb"] = "?_src_=vars;remverb=[UID()]" + .["Add Verb"] = "byond://?_src_=vars;addverb=[UID()]" + .["Remove Verb"] = "byond://?_src_=vars;remverb=[UID()]" - .["Gib"] = "?_src_=vars;gib=[UID()]" + .["Gib"] = "byond://?_src_=vars;gib=[UID()]" ///Can this mob resist (default FALSE) /mob/proc/can_resist()