Secondary goals (#24599)

* Extract requests console message sending code.

* Add secondary goals

* Converted supply shuttle to a signal-based system.

* Lint.

* Review suggestions.

* Secondary goals can now check the supply shuttle for their requirements.

* Remove redundant completion variable, undef what we define.

* Made the request console refuse to issue a secondary goal until you finish the current one.

* Made the shuttle blacklist error more specific, added locked/manifest-attached crates to blacklist.

* Added round end secondary goal report.

* Lint

* Add tags to reagents for secondary goals to use.

* Extracted the reagent logic from the bar goal, used reagent tags.

* Added the Variety of Drinks Bar goal.

* Added variety drinks goal for the Bar.

* CC no longer complains about sending stuff in containers, but the shuttle will refuse lockboxes without goal items.

* Allow unlocked lockboxes on the shuttle.

* Added kitchen goals.

* Lint

* More lint

* Add goals for scichem and medchem, pending reagent labelling.

* Added Kudzu goal for botany.

* I forgot to rename them, oops.

* Lint

* Made mechs sellable, configurable goal rewards.

* Balancing changes.

* Added random Ripley goal.

* Add Clear Task Backlog station goal.

* Lint

* Oops.

* did i even do this right

* Lint

* Excluded drinks available from upgraded booze dispenser.

* Such bugs. Much fix. Wow.

* Goal notice formatting.

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Made storage nesting better, improved consistency between storage types.

* Out, er, space.

* Added a proc for sending a requests console message.

* Added error messages to Virology Goals.

Backported a few small things from Secondary Goals to make this easier.

* Extracted out the three-way reward code into a proc.

* Update code/__DEFINES/dcs/signals.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Removed redundant SIGNAL_HANDLER labels.

* Yes, that should be a proc.

* Enforce important parent calls.

* Thank you, DreamChecker

* Undid accidental merge of #24699

* Removed a testing proc that wasn't intended for this PR.

* Removed parts of #24750 that also crept in.

* Made the variety of [x] goals more explicit that they want 50u of each.

* Reduced Kudzu trait requirement to 1.

* Request consoles now output the list of valid departments if you're at an unsupported one.

* Added personal crates.

* Added a supply pack of personal crates.

* Added special cargo handling for personal crates.

* Added automatic personal crate when requesting a goal.

* Required personal crates for most secondary goals.

* Add goal labels to the hand labeler, require them for mech goals.

* Made secondary goals one-per-person, not one-per-department.

* Added support for multi-line system messages to the request consoles.

* Made the RC message for goals nicer.

* Send goal crates even if no normal crates are ready, name and access-lock them properly.

* Don't double-label.

* Let's not use registered_account, names are fine.

* Add a ton of blackbox data to cargo and secondary goals.

* Fix a few bugs.

* More bugfixing, couple more stats.

* Even more stats.

* Text fix.

* Made cargo fines more consistent with other cargo feedback.

* Fixed a bug that prevented non-top-level items from being checked for CARGO_REQUIRE_PRIORITY.

* Blocked large crates from being sent back unopened.

* Enum values should probably be different from each other.

* Correct a bitflag mishap.

* Removed redundant supply shuttle docking and buy/sell attempts.

* Tweak message about personal crates to inlclude that they need to lock it.

* Add /Crates to the Personal Lockers description.

* Less pretty alignment, less complaining linters.

* Corrected a bad name in stats tracking.

* Reduced SciChem variety goal to 5 types.

* Toned down Task Backlog a bit.

* Fixed a bug that made unsellable items nested in containers be stolen by CC (qdeleted).

* Don't require bluespace 8, that's silly.

* Made secondary goals modifiable in the Modify Station Goals UI.

* Whoops, that was supposed to be 600u.

* i ded pls nerf

---------

Co-authored-by: synthtee <127706731+SynthTwo@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

code/modules/admin/topic.dm

@@ -3317,7 +3317,7 @@
 	else if(href_list["add_station_goal"])
 		if(!check_rights(R_EVENT))
 			return
-		var/list/type_choices = typesof(/datum/station_goal)
+		var/list/type_choices = typesof(/datum/station_goal) - typesof(/datum/station_goal/secondary)
 		var/picked = input("Choose goal type") in type_choices|null
 		if(!picked)
 			return
@@ -3335,6 +3335,46 @@
 		SSticker.mode.station_goals += G
 		modify_goals()
 
+	else if(href_list["add_secondary_goal"])
+		if(!check_rights(R_EVENT))
+			return
+		var/list/type_choices = typesof(/datum/station_goal/secondary)
+		for(var/T in type_choices)
+			if(T == /datum/station_goal/secondary)
+				continue
+			var/datum/station_goal/secondary/SG = T
+			if(initial(SG.abstract))
+				type_choices -= SG
+		var/picked = pick_closest_path(FALSE, make_types_fancy(type_choices), skip_filter = TRUE)
+		if(!picked)
+			return
+		var/datum/station_goal/secondary/G = new picked()
+		if(picked == /datum/station_goal/secondary)
+			var/newname = clean_input("Enter goal name:")
+			if(!newname)
+				return
+			G.name = newname
+			var/description = input("Enter A.L.I.C.E message contents:") as message|null
+			if(!description)
+				return
+			G.report_message = description
+			var/admin_description = input("Enter description for admins:") as message|null
+			if(!admin_description)
+				return
+			G.admin_desc = admin_description
+			var/department_choices = list()
+			for(var/obj/machinery/requests_console/RC in GLOB.allRequestConsoles)
+				department_choices |= RC.department
+			var/department = input("Choose goal department") in department_choices|null
+			if(!department)
+				return
+			G.department = department
+			G.should_send_crate = alert("Send a personal crate?","Send crate","Yes","No") == "Yes"
+		G.Initialize()
+		message_admins("[key_name_admin(usr)] created \"[G.name]\" station goal. Description: [G.admin_desc]")
+		SSticker.mode.secondary_goals += G
+		modify_goals()
+
 	else if(href_list["showdetails"])
 		if(!check_rights(R_ADMIN))
 			return

code/modules/admin/verbs/randomverbs.dm

@@ -1147,11 +1147,18 @@ Traitors and the like can also be revived with the previous role mostly intact.
 		to_chat(usr, "<span class='warning'>This verb can only be used if the round has started.</span>")
 		return
 
-	var/dat = ""
+	var/list/dat = list()
 	for(var/datum/station_goal/S in SSticker.mode.station_goals)
-		dat += "[S.name] - <a href='?src=[S.UID()];announce=1'>Announce</a> | <a href='?src=[S.UID()];remove=1'>Remove</a><br>"
-	dat += "<br><a href='?src=[UID()];add_station_goal=1'>Add New Goal</a>"
-	usr << browse(dat, "window=goals;size=400x400")
+		dat += "[S.name][S.completed ? " (C)" : ""] - <a href='?src=[S.UID()];announce=1'>Announce</a> | <a href='?src=[S.UID()];remove=1'>Remove</a>"
+	dat += ""
+	dat += "<a href='?src=[UID()];add_station_goal=1'>Add New Goal</a>"
+	dat += ""
+	dat += "<b>Secondary goals</b>"
+	for(var/datum/station_goal/secondary/SG in SSticker.mode.secondary_goals)
+		dat += "[SG.admin_desc][SG.completed ? " (C)" : ""] for [SG.requester_name || SG.department] - <a href='?src=[SG.UID()];announce=1'>Announce</a> | <a href='?src=[SG.UID()];remove=1'>Remove</a> | <a href='?src=[SG.UID()];mark_complete=1'>Mark complete</a> | <a href='?src=[SG.UID()];reset_progress=1'>Reset progress</a>"
+	dat += "<a href='?src=[UID()];add_secondary_goal=1'>Add New Secondary Goal</a>"
+
+	usr << browse(dat.Join("<br>"), "window=goals;size=400x400")
 
 /// Allow admin to add or remove traits of datum
 /datum/admins/proc/modify_traits(datum/D)