Refactors status displays (#18811)

* Refactors status displays

* biggest commit

code/modules/mob/living/silicon/ai/ai.dm

@@ -966,20 +966,9 @@ GLOBAL_LIST_INIT(ai_verbs_default, list(
 	if(check_unable())
 		return
 
-	for(var/obj/machinery/M in GLOB.machines) //change status
-		if(istype(M, /obj/machinery/ai_status_display))
-			var/obj/machinery/ai_status_display/AISD = M
-			AISD.emotion = emote
-			AISD.update_icon()
-		//if Friend Computer, change ALL displays
-		else if(istype(M, /obj/machinery/status_display))
-
-			var/obj/machinery/status_display/SD = M
-			if(emote=="Friend Computer")
-				SD.friendc = TRUE
-			else
-				SD.friendc = FALSE
-	return
+	for(var/obj/machinery/ai_status_display/AISD as anything in GLOB.ai_displays) //change status
+		AISD.emotion = emote
+		AISD.update_icon()
 
 //I am the icon meister. Bow fefore me.	//>fefore
 /mob/living/silicon/ai/proc/ai_hologram_change()

code/modules/mob/living/silicon/ai/death.dm

@@ -31,11 +31,11 @@
 		qdel(doomsday_device)
 
 	if(explosive)
-		spawn(10)
+		spawn(10) // REEEEEEEE
 			explosion(src.loc, 3, 6, 12, 15)
 
-	for(var/obj/machinery/ai_status_display/O in GLOB.machines) //change status
-		O.mode = 2
+	for(var/obj/machinery/ai_status_display/O as anything in GLOB.ai_displays) //change status
+		O.mode = AI_DISPLAY_MODE_BSOD
 
 	if(istype(loc, /obj/item/aicard))
 		loc.icon_state = "aicard-404"

code/modules/mob/living/silicon/ai/login.dm

@@ -7,7 +7,8 @@
 	regenerate_icons()
 
 	if(stat != DEAD)
-		for(var/obj/machinery/ai_status_display/O in GLOB.machines) //change status
-			O.mode = 1
+		for(var/obj/machinery/ai_status_display/O as anything in GLOB.ai_displays) //change status
+			O.mode = AI_DISPLAY_MODE_EMOTE
 			O.emotion = "Neutral"
+
 	view_core()

code/modules/mob/living/silicon/ai/logout.dm

@@ -1,6 +1,6 @@
 /mob/living/silicon/ai/Logout()
 	..()
-	for(var/obj/machinery/ai_status_display/O in GLOB.machines) //change status
-		O.mode = 0
-	src.view_core()
-	return
+	for(var/obj/machinery/ai_status_display/O as anything in GLOB.ai_displays) //change status
+		O.mode = AI_DISPLAY_MODE_BLANK
+
+	view_core()

code/modules/mob/living/silicon/decoy/death.dm

@@ -3,8 +3,10 @@
 	. = ..()
 	if(!.)
 		return FALSE
+
 	icon_state = "ai-crash"
-	for(var/obj/machinery/ai_status_display/O in GLOB.machines) //change status
+	for(var/obj/machinery/ai_status_display/O as anything in GLOB.ai_displays) //change status
 		if(atoms_share_level(O, src))
-			O.mode = 2
+			O.mode = AI_DISPLAY_MODE_BSOD
+
 	gib()