Ninja File Structure Rework

Restructures the ninja files into a more spaced-out version, compliments
of /TG/. The energy katana is also their handiwork.

Add an emag act to crates and lockers instead of handling everything in
attackby.

code/game/objects/structures/crates_lockers/closets/secure/personal.dm

@@ -75,9 +75,9 @@
 		else if(src.allowed(user) || !src.registered_name || (istype(I) && (src.registered_name == I.registered_name)))
 			//they can open all lockers, or nobody owns this, or they own this locker
 			src.locked = !( src.locked )
-			if(src.locked)	
+			if(src.locked)
 				src.icon_state = src.icon_locked
-			else	
+			else
 				src.icon_state = src.icon_closed
 				registered_name = null
 				desc = initial(desc)
@@ -87,19 +87,8 @@
 				src.desc = "Owned by [I.registered_name]."
 		else
 			user << "\red Access Denied"
-	else if( (istype(W, /obj/item/weapon/card/emag)||istype(W, /obj/item/weapon/melee/energy/blade)) && !src.broken)
-		broken = 1
-		locked = 0
-		desc = "It appears to be broken."
-		icon_state = src.icon_broken
-		if(istype(W, /obj/item/weapon/melee/energy/blade))
-			var/datum/effect/effect/system/spark_spread/spark_system = new /datum/effect/effect/system/spark_spread()
-			spark_system.set_up(5, 0, src.loc)
-			spark_system.start()
-			playsound(src.loc, 'sound/weapons/blade1.ogg', 50, 1)
-			playsound(src.loc, "sparks", 50, 1)
-			for(var/mob/O in viewers(user, 3))
-				O.show_message("\blue The locker has been sliced open by [user] with an energy blade!", 1, "\red You hear metal being sliced and sparks flying.", 2)
+	else if((istype(W, /obj/item/weapon/card/emag)) && !src.broken)
+		emag_act()
 	else
 		user << "\red Access Denied"
 	return

code/game/objects/structures/crates_lockers/closets/secure/secure_closets.dm

@@ -78,27 +78,20 @@
 		if(W)
 			W.loc = src.loc
 	else if((istype(W, /obj/item/weapon/card/emag)||istype(W, /obj/item/weapon/melee/energy/blade)) && !src.broken)
-		broken = 1
-		locked = 0
-		desc = "It appears to be broken."
-		icon_state = icon_off
-		flick(icon_broken, src)
-		if(istype(W, /obj/item/weapon/melee/energy/blade))
-			var/datum/effect/effect/system/spark_spread/spark_system = new /datum/effect/effect/system/spark_spread()
-			spark_system.set_up(5, 0, src.loc)
-			spark_system.start()
-			playsound(src.loc, 'sound/weapons/blade1.ogg', 50, 1)
-			playsound(src.loc, "sparks", 50, 1)
-			for(var/mob/O in viewers(user, 3))
-				O.show_message("<span class='warning'>The locker has been sliced open by [user] with an energy blade!</span>", 1, "You hear metal being sliced and sparks flying.", 2)
-		else
-			for(var/mob/O in viewers(user, 3))
-				O.show_message("<span class='warning'>The locker has been broken by [user] with an electromagnetic card!</span>", 1, "You hear a faint electrical spark.", 2)
+		emag_act()
 	else if(istype(W,/obj/item/stack/packageWrap) || istype(W,/obj/item/weapon/weldingtool))
 		return ..(W,user)
 	else
 		togglelock(user)
 
+/obj/structure/closet/secure_closet/emag_act()
+	broken = 1
+	locked = 0
+	desc = "It appears to be broken."
+	icon_state = icon_off
+	flick(icon_broken, src)
+	usr<< "<span class='notice'>You unlock \the [src].</span>"
+
 /obj/structure/closet/secure_closet/attack_hand(mob/user as mob)
 	src.add_fingerprint(user)
 	if(src.locked)

code/game/objects/structures/crates_lockers/crates.dm

@@ -295,19 +295,23 @@
 	if(is_type_in_list(W, list(/obj/item/stack/packageWrap, /obj/item/stack/cable_coil, /obj/item/device/radio/electropack, /obj/item/weapon/wirecutters)))
 		return ..()
 	if(locked && (istype(W, /obj/item/weapon/card/emag)||istype(W, /obj/item/weapon/melee/energy/blade)))
-		overlays += sparks
-		spawn(6) overlays -= sparks //Tried lots of stuff but nothing works right. so i have to use this *sadface*
-		playsound(src.loc, "sparks", 60, 1)
-		src.locked = 0
-		src.broken = 1
-		update_icon()
-		user << "<span class='notice'>You unlock \the [src].</span>"
+		emag_act()
 		return
 	if(!opened)
 		src.togglelock(user)
 		return
 	return ..()
 
+/obj/structure/closet/crate/secure/emag_act()
+	overlays += sparks
+	spawn(6) overlays -= sparks //Tried lots of stuff but nothing works right. so i have to use this *sadface*
+	playsound(src.loc, "sparks", 60, 1)
+	src.locked = 0
+	src.broken = 1
+	update_icon()
+	usr << "<span class='notice'>You unlock \the [src].</span>"
+	return
+
 /obj/structure/closet/crate/secure/emp_act(severity)
 	for(var/obj/O in src)
 		O.emp_act(severity)