Mark ui_data procs as SHOULD_NOT_SLEEP(TRUE) (#17847)

* mark ui_data procs as SHOULD_NOT_SLEEP(TRUE)

* Address dm warnings
This commit is contained in:
moxian
2022-05-24 11:47:19 +00:00
committed by GitHub
parent 3d24eeedd8
commit 64c2bccb36
2 changed files with 8 additions and 14 deletions
+6
View File
@@ -29,6 +29,11 @@
* * mob/user - The mob interacting with the UI.
*/
/datum/proc/ui_data(mob/user)
// Two good reasons why it shouldn't:
// 1) this is polled several times a second, so sleeping means more running threads, needlessly tanking performance
// 2) if you try to sleep, you get fun bugs ranging from BSOD to uninteractable white windows, to windows straight up vanishing.
// Just don't.
SHOULD_NOT_SLEEP(TRUE)
return list() // Not implemented.
/**
@@ -43,6 +48,7 @@
* * mob/user - The mob interacting with the UI.
*/
/datum/proc/ui_static_data(mob/user)
SHOULD_NOT_SLEEP(TRUE)
return list()
/**