From 671e75abe6ef82f383d509a8e38e0dbf0c4e7ae6 Mon Sep 17 00:00:00 2001
From: Henri215 <77684085+Henri215@users.noreply.github.com>
Date: Thu, 19 Jan 2023 16:23:21 -0300
Subject: [PATCH] Fixes janicart and mop bucket overlays not updating properly
 (#20232)

* Fixes janicart and mop bucket overlays not updating properly

* Sirryan review

* ops
---
 code/game/objects/structures/janicart.dm   | 7 +++----
 code/game/objects/structures/mop_bucket.dm | 1 +
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/code/game/objects/structures/janicart.dm b/code/game/objects/structures/janicart.dm
index 6362852c033..6e8fa06adf4 100644
--- a/code/game/objects/structures/janicart.dm
+++ b/code/game/objects/structures/janicart.dm
@@ -37,6 +37,7 @@
 	I.forceMove(src)
 	updateUsrDialog()
 	to_chat(user, "<span class='notice'>You put [I] into [src].</span>")
+	update_icon(UPDATE_OVERLAYS)
 	return
 
 /obj/structure/janitorialcart/on_reagent_change()
@@ -64,9 +65,8 @@
 				to_chat(user, fail_msg)
 		else if(istype(I, /obj/item/reagent_containers/spray/cleaner))
 			if(!myspray)
+				myspray = I
 				put_in_cart(I, user)
-				myspray=I
-				update_icon(UPDATE_OVERLAYS)
 			else
 				to_chat(user, fail_msg)
 		else if(istype(I, /obj/item/lightreplacer))
@@ -77,9 +77,8 @@
 				to_chat(user, fail_msg)
 		else if(istype(I, /obj/item/caution))
 			if(signs < max_signs)
-				put_in_cart(I, user)
 				signs++
-				update_icon(UPDATE_OVERLAYS)
+				put_in_cart(I, user)
 			else
 				to_chat(user, "<span class='notice'>[src] can't hold any more signs.</span>")
 		else if(istype(I, /obj/item/crowbar))
diff --git a/code/game/objects/structures/mop_bucket.dm b/code/game/objects/structures/mop_bucket.dm
index 47801e116cf..5317afba5e9 100644
--- a/code/game/objects/structures/mop_bucket.dm
+++ b/code/game/objects/structures/mop_bucket.dm
@@ -39,6 +39,7 @@
 	user.drop_item()
 	I.forceMove(src)
 	to_chat(user, "<span class='notice'>You put [I] into [src].</span>")
+	update_icon(UPDATE_OVERLAYS)
 	return
 
 /obj/item/mop/proc/mopbucket_insert(mob/user, obj/structure/mopbucket/J)