From 686cd5fd79a60dc74ea674d448bcd55859d7971a Mon Sep 17 00:00:00 2001
From: Luc <89928798+lewcc@users.noreply.github.com>
Date: Fri, 16 Sep 2022 12:52:17 -0400
Subject: [PATCH] Fixes emotes being displayed as the wrong type (#19026)

* Fixes some emote types, fixing the voice analyzer by proxy

* Remove unused utility function
---
 code/datums/emote.dm                                | 2 +-
 code/modules/mob/living/carbon/human/human_emote.dm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/code/datums/emote.dm b/code/datums/emote.dm
index 4f536c3f75e..1b2edf9e488 100644
--- a/code/datums/emote.dm
+++ b/code/datums/emote.dm
@@ -208,7 +208,7 @@
 			for(var/mob/dead/observer/ghost in viewers(user))
 				ghost.show_message("<span class=deadsay>[displayed_msg]</span>", EMOTE_VISIBLE)
 
-		else if(emote_type & EMOTE_VISIBLE || user.mind?.miming)
+		else if(emote_type & (EMOTE_AUDIBLE | EMOTE_SOUND) && !user.mind?.miming)
 			user.audible_message(displayed_msg, deaf_message = "<span class='emote'>You see how <b>[user]</b> [msg]</span>")
 		else
 			user.visible_message(displayed_msg, blind_message = "<span class='emote'>You hear how someone [msg]</span>")
diff --git a/code/modules/mob/living/carbon/human/human_emote.dm b/code/modules/mob/living/carbon/human/human_emote.dm
index 731e763371a..ee9d2730220 100644
--- a/code/modules/mob/living/carbon/human/human_emote.dm
+++ b/code/modules/mob/living/carbon/human/human_emote.dm
@@ -382,7 +382,7 @@
 		return TRUE
 
 	if(prob(5))
-		user.visible_message("<span class='danger'><b>[user]</b> snaps [p_their()] fingers right off!</span>")
+		user.visible_message("<span class='danger'><b>[user]</b> snaps [user.p_their()] fingers right off!</span>")
 		playsound(user.loc, 'sound/effects/snap.ogg', 50, 1)
 		return TRUE
 	return ..()