From 69bd5ad19b80fef881eaf78448bc43c8b4b4e123 Mon Sep 17 00:00:00 2001 From: S34N <12197162+S34NW@users.noreply.github.com> Date: Mon, 13 Mar 2023 22:24:22 +0000 Subject: [PATCH] Adds more QoL logs for admins (#20468) * More logs * why is this not ignored * you never know if someone has busted DNA * Update code/controllers/subsystem/jobs.dm Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com> --------- Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com> --- code/controllers/subsystem/jobs.dm | 6 ++---- code/datums/mind.dm | 6 ++++++ code/game/gamemodes/blob/blob_mode.dm | 2 +- code/game/gamemodes/miniantags/abduction/abduction.dm | 2 ++ code/game/gamemodes/nuclear/nuclear.dm | 2 +- code/game/gamemodes/revolution/revolution.dm | 1 + code/game/gamemodes/wizard/raginmages.dm | 2 +- code/game/gamemodes/wizard/wizard.dm | 2 +- code/modules/antagonists/_common/antag_datum.dm | 1 + code/modules/events/sentience.dm | 1 + code/modules/events/traders.dm | 1 + 11 files changed, 18 insertions(+), 8 deletions(-) diff --git a/code/controllers/subsystem/jobs.dm b/code/controllers/subsystem/jobs.dm index dc21f3d740c..a267d8471c0 100644 --- a/code/controllers/subsystem/jobs.dm +++ b/code/controllers/subsystem/jobs.dm @@ -502,12 +502,10 @@ SUBSYSTEM_DEF(jobs) G.prescription = TRUE G.name = "prescription [G.name]" H.update_nearsighted_effects() + + H.create_log(MISC_LOG, "Spawned as \an [H.dna?.species ? H.dna.species : "Undefined species"] named [H]. [joined_late ? "Joined during the round" : "Roundstart joined"] as job: [rank].") return H - - - - /datum/controller/subsystem/jobs/proc/LoadJobs(highpop = FALSE) //ran during round setup, reads info from jobs list if(!GLOB.configuration.jobs.enable_job_amount_overrides) return FALSE diff --git a/code/datums/mind.dm b/code/datums/mind.dm index 35b75629a3b..30b2623c0c7 100644 --- a/code/datums/mind.dm +++ b/code/datums/mind.dm @@ -834,6 +834,7 @@ special_role = SPECIAL_ROLE_REV log_admin("[key_name(usr)] has rev'd [key_name(current)]") message_admins("[key_name_admin(usr)] has rev'd [key_name_admin(current)]") + current.create_log(MISC_LOG, "[current] was made into a revolutionary by [key_name_admin(usr)]") if("headrev") if(src in SSticker.mode.revolutionaries) @@ -860,6 +861,7 @@ special_role = SPECIAL_ROLE_HEAD_REV log_admin("[key_name(usr)] has head-rev'd [key_name(current)]") message_admins("[key_name_admin(usr)] has head-rev'd [key_name_admin(current)]") + current.create_log(MISC_LOG, "[current] was made into a head revolutionary by [key_name_admin(usr)]") if("autoobjectives") SSticker.mode.forge_revolutionary_objectives(src) @@ -954,6 +956,7 @@ current.faction = list("wizard") log_admin("[key_name(usr)] has wizarded [key_name(current)]") message_admins("[key_name_admin(usr)] has wizarded [key_name_admin(current)]") + current.create_log(MISC_LOG, "[current] was made into a wizard by [key_name_admin(usr)]") if("lair") current.forceMove(pick(GLOB.wizardstart)) log_admin("[key_name(usr)] has moved [key_name(current)] to the wizard's lair") @@ -1183,6 +1186,7 @@ SSticker.mode.update_eventmisc_icons_added(src) message_admins("[key_name_admin(usr)] has eventantag'ed [current].") log_admin("[key_name(usr)] has eventantag'ed [current].") + current.create_log(MISC_LOG, "[current] was made into an event antagonist by [key_name_admin(usr)]") else if(href_list["traitor"]) switch(href_list["traitor"]) @@ -1423,6 +1427,7 @@ make_Abductor() log_admin("[key_name(usr)] turned [current] into abductor.") SSticker.mode.update_abductor_icons_added(src) + current.create_log(MISC_LOG, "[current] was made into an abductor by [key_name_admin(usr)]") if("equip") if(!ishuman(current)) to_chat(usr, "This only works on humans!") @@ -1731,6 +1736,7 @@ L = agent_landmarks[team] H.forceMove(L.loc) SEND_SOUND(H, sound('sound/ambience/antag/abductors.ogg')) + H.create_log(MISC_LOG, "[H] was made into an abductor") /datum/mind/proc/AddSpell(obj/effect/proc_holder/spell/S) spell_list += S diff --git a/code/game/gamemodes/blob/blob_mode.dm b/code/game/gamemodes/blob/blob_mode.dm index ae42f542525..0fb4c079632 100644 --- a/code/game/gamemodes/blob/blob_mode.dm +++ b/code/game/gamemodes/blob/blob_mode.dm @@ -108,7 +108,7 @@ GLOBAL_LIST_EMPTY(blob_nodes) to_chat(blob.current, "If you go outside of the station level, or in space, then you will die; make sure your location has lots of ground to cover.") to_chat(blob.current, "For more information, check the wiki page: ([GLOB.configuration.url.wiki_url]/index.php/Blob)") SEND_SOUND(blob.current, sound('sound/magic/mutate.ogg')) - return + blob.current.create_log(MISC_LOG, "[blob.current] was made into a blob") /datum/game_mode/blob/proc/show_message(message) for(var/datum/mind/blob in infected_crew) diff --git a/code/game/gamemodes/miniantags/abduction/abduction.dm b/code/game/gamemodes/miniantags/abduction/abduction.dm index bdf8449fa6b..367c7883773 100644 --- a/code/game/gamemodes/miniantags/abduction/abduction.dm +++ b/code/game/gamemodes/miniantags/abduction/abduction.dm @@ -160,6 +160,7 @@ to_chat(abductor.current, "With the help of your teammate, kidnap and experiment on station crew members!") to_chat(abductor.current, "Use your stealth technology and equipment to incapacitate humans for your scientist to retrieve.") to_chat(abductor.current, "For more information, check the wiki page: ([GLOB.configuration.url.wiki_url]/index.php/Abductor)") + abductor.current.create_log(MISC_LOG, "[abductor.current] was made into an abductor agent") abductor.announce_objectives() @@ -174,6 +175,7 @@ to_chat(abductor.current, "With the help of your teammate, kidnap and experiment on station crew members!") to_chat(abductor.current, "Use your tool and ship consoles to support the agent and retrieve human specimens.") to_chat(abductor.current, "For more information, check the wiki page: ([GLOB.configuration.url.wiki_url]/index.php/Abductor)") + abductor.current.create_log(MISC_LOG, "[abductor.current] was made into an abductor scientist") abductor.announce_objectives() diff --git a/code/game/gamemodes/nuclear/nuclear.dm b/code/game/gamemodes/nuclear/nuclear.dm index bc530e42589..72806e85e96 100644 --- a/code/game/gamemodes/nuclear/nuclear.dm +++ b/code/game/gamemodes/nuclear/nuclear.dm @@ -251,7 +251,7 @@ to_chat(syndicate.current, "Objective #[obj_count]: [objective.explanation_text]") obj_count++ to_chat(syndicate.current, "For more information, check the wiki page: ([GLOB.configuration.url.wiki_url]/index.php/Nuclear_Agent)") - return + syndicate.current.create_log(MISC_LOG, "[syndicate.current] was made into a nuclear operative") /datum/game_mode/proc/random_radio_frequency() diff --git a/code/game/gamemodes/revolution/revolution.dm b/code/game/gamemodes/revolution/revolution.dm index dc4acf82aa7..59357f46691 100644 --- a/code/game/gamemodes/revolution/revolution.dm +++ b/code/game/gamemodes/revolution/revolution.dm @@ -106,6 +106,7 @@ rev_mind.special_role = SPECIAL_ROLE_HEAD_REV obj_count++ to_chat(rev_mind.current, "For more information, check the wiki page: ([GLOB.configuration.url.wiki_url]/index.php/Revolution)") + rev_mind.current.create_log(MISC_LOG, "[rev_mind.current] was made into a head revolutionary") ///////////////////////////////////////////////////////////////////////////////// //This are equips the rev heads with their gear, and makes the clown not clumsy// diff --git a/code/game/gamemodes/wizard/raginmages.dm b/code/game/gamemodes/wizard/raginmages.dm index 307fe8ebad8..0d0a6294024 100644 --- a/code/game/gamemodes/wizard/raginmages.dm +++ b/code/game/gamemodes/wizard/raginmages.dm @@ -26,7 +26,7 @@ for(var/datum/objective/objective in wizard.objectives) to_chat(wizard.current, "Objective #[obj_count]: [objective.explanation_text]") obj_count++ - return + wizard.current.create_log(MISC_LOG, "[wizard.current] was made into a wizard") /datum/game_mode/wizard/raginmages/check_finished() var/wizards_alive = 0 diff --git a/code/game/gamemodes/wizard/wizard.dm b/code/game/gamemodes/wizard/wizard.dm index 6e7c7a6af56..55006b406ca 100644 --- a/code/game/gamemodes/wizard/wizard.dm +++ b/code/game/gamemodes/wizard/wizard.dm @@ -109,7 +109,7 @@ to_chat(wizard.current, "Objective #[obj_count]: [objective.explanation_text]") obj_count++ to_chat(wizard.current, "For more information, check the wiki page: ([GLOB.configuration.url.wiki_url]/index.php/Wizard)") - return + wizard.current.create_log(MISC_LOG, "[wizard.current] was made into a wizard") /datum/game_mode/proc/equip_wizard(mob/living/carbon/human/wizard_mob) if(!istype(wizard_mob)) diff --git a/code/modules/antagonists/_common/antag_datum.dm b/code/modules/antagonists/_common/antag_datum.dm index dd1e8044060..95220b024d3 100644 --- a/code/modules/antagonists/_common/antag_datum.dm +++ b/code/modules/antagonists/_common/antag_datum.dm @@ -285,6 +285,7 @@ GLOBAL_LIST_EMPTY(antagonists) to_chat(owner.current, "For more information, check the wiki page: ([GLOB.configuration.url.wiki_url]/index.php/[wiki_page_name])") if(is_banned(owner.current) && replace_banned) INVOKE_ASYNC(src, PROC_REF(replace_banned_player)) + owner.current.create_log(MISC_LOG, "[owner.current] was made into \an [special_role]") return TRUE /** diff --git a/code/modules/events/sentience.dm b/code/modules/events/sentience.dm index a711b4f6681..d2e4b05191b 100644 --- a/code/modules/events/sentience.dm +++ b/code/modules/events/sentience.dm @@ -47,3 +47,4 @@ to_chat(M, "Due to freak radiation, you have gained \ human level intelligence and the ability to speak and understand \ human language!") + M.create_log(MISC_LOG, "[M] was made into a sentient animal") diff --git a/code/modules/events/traders.dm b/code/modules/events/traders.dm index 8ef480ecdf9..f299f9b10d9 100644 --- a/code/modules/events/traders.dm +++ b/code/modules/events/traders.dm @@ -64,6 +64,7 @@ GLOBAL_LIST_INIT(unused_trade_stations, list("sol")) to_chat(M, "You are currently docked at [get_area(M)].") to_chat(M, "You are about to trade with [station_name()].") addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(show_objectives), M.mind), 25) + M.create_log(MISC_LOG, "[M] was made into a Sol Trader") /datum/event/traders/proc/forge_trader_objectives() var/list/objs = list()