From 6c201f57af2404a88a72082d488b1325ba498d64 Mon Sep 17 00:00:00 2001
From: Kyep <Kyep@users.noreply.github.com>
Date: Sat, 4 Jan 2020 16:22:08 -0800
Subject: [PATCH] Add a spam limiter to the goonchat topic calls

Port of: https://github.com/tgstation/tgstation/pull/48524/files
---
 goon/browserassets/js/browserOutput.js |  3 ++-
 goon/code/datums/browserOutput.dm      | 27 ++++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/goon/browserassets/js/browserOutput.js b/goon/browserassets/js/browserOutput.js
index 317fc02b9cb..40a69245188 100644
--- a/goon/browserassets/js/browserOutput.js
+++ b/goon/browserassets/js/browserOutput.js
@@ -416,7 +416,8 @@ function handleClientData(ckey, ip, compid) {
 			}
 		}
 
-		if (opts.clientData.length >= opts.clientDataLimit) {
+		//Lets make sure we obey our limit (can connect from server with higher limit)
+		while (opts.clientData.length >= opts.clientDataLimit) {
 			opts.clientData.shift();
 		}
 	} else {
diff --git a/goon/code/datums/browserOutput.dm b/goon/code/datums/browserOutput.dm
index cbeb7ae3ab0..2ddcd37bb04 100644
--- a/goon/code/datums/browserOutput.dm
+++ b/goon/code/datums/browserOutput.dm
@@ -16,11 +16,18 @@ var/list/chatResources = list(
 	"goon/browserassets/html/saveInstructions.html"
 )
 
+//Should match the value set in the browser js
+#define MAX_COOKIE_LENGTH 5
+
 /var/savefile/iconCache = new /savefile("data/iconCache.sav")
 /var/chatDebug = file("data/chatDebug.log")
 
 /datum/chatOutput
 	var/client/owner = null
+	// How many times client data has been checked
+	var/total_checks = 0
+	// When to next clear the client data checks counter
+	var/next_time_to_clear = 0
 	var/loaded = 0
 	var/list/messageQueue = list()
 	var/cookieSent = 0
@@ -137,6 +144,16 @@ var/list/chatResources = list(
 	ehjax_send(data = data)
 
 /datum/chatOutput/proc/analyzeClientData(cookie = "")
+	//Spam check
+	if(world.time  >  next_time_to_clear)
+		next_time_to_clear = world.time + (3 SECONDS)
+		total_checks = 0
+	total_checks += 1
+	if(total_checks > SPAM_TRIGGER_AUTOMUTE)
+		message_admins("[key_name(owner)] kicked for goonchat topic spam")
+		qdel(owner)
+		return
+
 	if(!cookie)
 		return
 
@@ -145,13 +162,21 @@ var/list/chatResources = list(
 		if(connData && islist(connData) && connData.len > 0 && connData["connData"])
 			connectionHistory = connData["connData"]
 			var/list/found = new()
+			if(connectionHistory.len > MAX_COOKIE_LENGTH)
+				message_admins("[key_name(src.owner)] was kicked for an invalid ban cookie)")
+				qdel(owner)
+				return
 			for(var/i = connectionHistory.len; i >= 1; i--)
+				if(QDELETED(owner))
+					//he got cleaned up before we were done
+					return
 				var/list/row = connectionHistory[i]
 				if(!row || row.len < 3 || !(row["ckey"] && row["compid"] && row["ip"]))
 					return
 				if(world.IsBanned(row["ckey"], row["ip"], row["compid"], FALSE))
 					found = row
 					break
+				CHECK_TICK
 			//Add autoban using the DB_ban_record function
 			//Uh oh this fucker has a history of playing on a banned account!!
 			if (found.len > 0)
@@ -284,3 +309,5 @@ var/to_chat_src
 		to_chat_immediate(target, message, flag)
 		return
 	SSchat.queue(target, message, flag)
+
+#undef MAX_COOKIE_LENGTH
\ No newline at end of file