From 6e9f01b4f91fcf69b34391cabc25242877dac4ef Mon Sep 17 00:00:00 2001
From: warriorstar-orion <orion@snowfrost.garden>
Date: Wed, 6 Mar 2024 08:30:23 -0500
Subject: [PATCH] ci: update maplint for APC mapping helpers (#24367)

---
 tools/maplint/lints/apc_pixel_shifts.yml |  7 -----
 tools/maplint/lints/directional_apcs.yml | 33 ++++++++++++++++++++++++
 2 files changed, 33 insertions(+), 7 deletions(-)
 delete mode 100644 tools/maplint/lints/apc_pixel_shifts.yml
 create mode 100644 tools/maplint/lints/directional_apcs.yml

diff --git a/tools/maplint/lints/apc_pixel_shifts.yml b/tools/maplint/lints/apc_pixel_shifts.yml
deleted file mode 100644
index 1556f73dc8e..00000000000
--- a/tools/maplint/lints/apc_pixel_shifts.yml
+++ /dev/null
@@ -1,7 +0,0 @@
-help: "Use the directional variants when possible."
-/obj/machinery/power/apc:
-  banned_variables:
-    pixel_x:
-      allow: [24, -24]
-    pixel_y:
-      allow: [24, -24]
diff --git a/tools/maplint/lints/directional_apcs.yml b/tools/maplint/lints/directional_apcs.yml
new file mode 100644
index 00000000000..ff6bdf2e42e
--- /dev/null
+++ b/tools/maplint/lints/directional_apcs.yml
@@ -0,0 +1,33 @@
+help: "Use the specific directional subtypes for this APC."
+/obj/machinery/power/apc:
+  banned_variables:
+  - pixel_x
+  - pixel_y
+=/obj/machinery/power/apc:
+  banned: true
+=/obj/machinery/power/apc/directional:
+  banned: true
+=/obj/machinery/power/apc/important:
+  banned: true
+=/obj/machinery/power/apc/important/directional:
+  banned: true
+=/obj/machinery/power/apc/critical:
+  banned: true
+=/obj/machinery/power/apc/critical/directional:
+  banned: true
+=/obj/machinery/power/apc/off_station:
+  banned: true
+=/obj/machinery/power/apc/off_station/directional:
+  banned: true
+=/obj/machinery/power/apc/syndicate:
+  banned: true
+=/obj/machinery/power/apc/syndicate/directional:
+  banned: true
+=/obj/machinery/power/apc/syndicate/off:
+  banned: true
+=/obj/machinery/power/apc/syndicate/off/directional:
+  banned: true
+=/obj/machinery/power/apc/worn_out:
+  banned: true
+=/obj/machinery/power/apc/worn_out/directional:
+  banned: true