Modsuits. Ready for review, sorry for the ammount of files changed 👉 👈 (#21147)

* biting off more than I can chew, but I feel like hurting myself

* more shit

* progress continues, moral stays sameish

* bite of 2587

* mod_theme down, but probably broken

* 385 errors, 16 warnings, zero tgui interactions

* 292 19

* final strech to buggy mess, break time

* it compiles. It almost fucking certainly doesnt work, but it compiles

* fudhsciffubgsbgpgb actions not working as should for modules

* fuck it we'll just open the pr as we work on it

* icons work now

* tgui stuff

* more progress

* JUDGEMENT

* IT LIVES. TGUI LIVES. Special thanks to Sirryan and my brother.

* jetpacks, gps, and go do what exo-suits yourself

* almost ready

* sorry to whoever has to review this

* should work™️

* should be good now

* pushing changes so I can do reviews next

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* lore™️ Adds illegals level to modsuit parts from syndicate.

* early returns

* and these illegals

* no uplink reference idiot

* mod inhands are a good idea

* this is needed for inhands nerd

* Bomb detector working, modsutis cover ears. skin things

* overslotting removal, cyborg charging, ert loadout for gamma

* duplicated signal

* modsuit themes, removes broken mister / bad base type module, 2 cores in robotics.

* tether module, orb module, holster stuff

* built in no slip, cheaper 87

* removes modules already installed, engineer ert get jetpack, equip into modsuit storage

* comments spaces and duplicate flags

* Some adjustments and thoughts on armor, heads get guns because they are cool like that / looting command members armor

* Apply suggestions from code review

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Compile TGUI, slowdown adjustment, Modsuit to MODsuit

* sonar, do after, more equipment, acid handling

* overlay bugs / ERT / DS suits autodeploy

* middle click action buttons

* traders, sec modsuit energy nerf

* surplus weighting

* Kinesis module.

* Pathfinder module, kinesis balance, blueprint for pathfinder and kinesis

* more power / unused module removed

* name, ds fix, pre equipped to cc suit

* depot / grammer

* ok should be good™️

* overslot, dupe gun, missing suit storage

* stealth nerf, new kit

* gun stuff  / ds theme

* bio armor is gone

* let me push changes please thank you

* makes shocks work right

* copies over some changes TG made to module prices after porting

* Merge remote-tracking branch 'upstream/master' into Because-I-hate-myself-and-someone-has-to-try-it-

* sirryans changes

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/telesci/gps.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/telesci/gps.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Control define, ERT / DS have gloves / boots again.

* Apply suggestions from code review

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* More changes

* god I hate tgui. Why do all the bundles live underground, instead of in my basement?

* she updates my master till I testmerge

* modsuits can recharge again

* fixes a lot of shit

* Ready for TM probably

* sure fuck it whatever that makes sense I guess

* the pinpointer works better™️

* Another storage module bug fix

* hair and medical stuff

* fuck fuck fuck

* fixes sonar

* Bag exploit fixes / plasma runtimes / ear nerf

* dna lock improvement / cryostorage

* whoops

* Ball form second cooldown wasn't helping, no more infinite cores

* she springs my lock till I ***SNAP***

* plasmaman no longer die

* fixes modsuit emp issues

* atmos no longer fucking dies

* Fixes, module printing, and a restriction on newly constructed modsuits

* Inventory code my hated

* WOOO PREFERENCE CODE WOOOOO

* icons my hated

* fix for mods / spaceproof shit

* holy shit whhhyyyyy

* backpack first

* Update mod_theme.dm

* prevent infinite gun arms / infinite modsuit cores / syndicate modules

* fixes tm error

* scream loudly if species sprites break. They shouldn't, but, you know.

* deconflicted with luck

* converts to refit for species

* fix pathfinder

* fixes modsuits being funky power wise

* lockboxes :gatto: , as well as DN-MP shield lock, and slight nerf to atmos modsuit

* nerfs the atmos modsuit

* magboots for ds / CC modsuit

* downside of autosave: typing in wrong window saves bad stuff

* Gamma ERT have internal cameras again.

* spellcheck when

* ah fuck

* yes delete the null that works

* whoops

* fixes error / description

* un vulps your cannon

* fixes tails disapeering on base modsuits

* space to underscore

* tgui fix / tajaran

* springlock buff, cryopod fix

* u helps

* WHO PUTS A GUN IN ITEMS

* tgui moment

* mining modsuit nerf / hidden holster module

* PAIN

* UNATHI TIDE STATION WIDE

* I love special code

* slightly dense

* shark jumpscare

* fixes ghost item, fixes springlock being bad

* YIPPEEEE IT WORKED

* she decons my flict

* pain

* ebbas days are numbered :^)

* hidden

* r-r-r-ebuild

* fixes more bugs

* qwerty, you are dense

* fixes gps

* fix mulebot crate

* level fix

* adds back icon

* moving storage, fix bug, modules activate / deactivate message

* yeah

* yeah

* yeah™️

* steels requests

* windoors no longer make pathfinder module explode

* chat spam

* oil slicks + modsuits

* whoops

* bag check

* ofc

* Update code/modules/mod/mod_control.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/datums/uplink_items/uplink_nuclear.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/mod/mod_control.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/mod/modules/module_pathfinder.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

code/game/objects/effects/effect_system/effects_chem_smoke.dm

@@ -120,6 +120,7 @@
 			continue
 		smoked_atoms += A
 		chemholder.reagents.reaction(A)
+		SEND_SIGNAL(A, COMSIG_ATOM_EXPOSE_REAGENTS, chemholder.reagents, chemholder, chemholder.reagents.total_volume)
 		if(iscarbon(A))
 			var/mob/living/carbon/C = A
 			if(C.can_breathe_gas())

code/game/objects/effects/spawners/lootdrop.dm

@@ -133,6 +133,8 @@
 				/obj/item/storage/wallet = 20,
 				/obj/item/storage/wallet/random = 5,
 				/obj/item/caution = 10,
+				/obj/item/mod/construction/broken_core = 4,
+				/obj/effect/spawner/random_spawners/mod/maint = 10,
 				////////////////CONTRABAND STUFF//////////////////
 				/obj/item/grenade/clown_grenade = 3,
 				/obj/item/grenade/smokebomb = 3,
@@ -161,7 +163,7 @@
 				/obj/item/storage/fancy/cigarettes/cigpack_syndicate = 2,
 				/obj/item/storage/pill_bottle/fakedeath = 2,
 				/obj/item/clothing/suit/jacket/syndicatebomber = 5,
-				"" = 60 // This should be a decently high number for chances where no loot will spawn
+				"" = 61 // This should be a decently high number for chances where no loot will spawn
 				)
 
 /obj/effect/spawner/lootdrop/maintenance/two
@@ -267,6 +269,7 @@
 				/obj/item/mecha_parts/mecha_equipment/weapon/energy/xray = 25, // mecha x-ray laser
 				/obj/item/mecha_parts/mecha_equipment/teleporter/precise = 25, // upgraded mecha teleporter
 				/obj/item/autosurgeon/organ = 50,
+				/obj/item/mod/construction/plating/research = 25,
 
 				// Research / Experimentor
 				/obj/item/paper/researchnotes = 150, // papers that give random R&D levels
@@ -296,7 +299,10 @@
 
 				// Virology
 				/obj/item/reagent_containers/glass/bottle/regeneration = 50,
-				/obj/item/reagent_containers/glass/bottle/sensory_restoration = 50
+				/obj/item/reagent_containers/glass/bottle/sensory_restoration = 50,
+
+				// Medical in general
+				/obj/item/mod/construction/plating/rescue = 25
 				)
 
 /obj/effect/spawner/lootdrop/trade_sol/sec
@@ -310,6 +316,8 @@
 				/obj/item/storage/belt/military/assault = 50,
 				/obj/item/clothing/mask/gas/sechailer/swat = 50,
 				/obj/item/clothing/glasses/thermal = 50, // see heat-source mobs through walls. Less powerful than already-available xray.
+				/obj/item/mod/construction/plating/safeguard = 25,
+				/obj/item/mod/module/power_kick = 50,
 
 				// Ranged weapons
 				/obj/item/storage/box/enforcer_rubber = 50,
@@ -331,7 +339,8 @@
 				/obj/item/storage/backpack/holding = 25,
 				/obj/item/clothing/glasses/meson/night = 25, // NV mesons
 				/obj/item/clothing/glasses/material = 25, // shows objects, but not mobs, through walls
-				/obj/item/grenade/clusterbuster/metalfoam = 25 // cluster metal foam grenade
+				/obj/item/grenade/clusterbuster/metalfoam = 25, // cluster metal foam grenade
+				/obj/item/mod/construction/plating/advanced = 13
 				)
 
 /obj/effect/spawner/lootdrop/trade_sol/largeitem

code/game/objects/effects/spawners/random_spawners.dm

@@ -160,6 +160,18 @@
 		/datum/nothing = 1,
 		/obj/effect/decal/cleanable/fungus = 7)
 
+/obj/effect/spawner/random_spawners/mod
+	name = "MOD module spawner"
+	desc = "Modularize this, please."
+	icon_state = "circuit"
+
+/obj/effect/spawner/random_spawners/mod/maint
+	name = "maint MOD module spawner"
+	result = list(
+		/obj/item/mod/module/springlock = 2,
+		/obj/item/mod/module/balloon = 1,
+		/obj/item/mod/module/stamp = 1
+	)
 
 
 // z6 DEPOT SPAWNERS
@@ -264,7 +276,7 @@
 	// Loot schema: space gear, basic armor, basic ammo (10mm, rcd), drugs, more dangerous/useful gimmick items, lower-value minerals
 	result = list(/datum/nothing = 27,
 		/obj/item/storage/box/syndie_kit/space = 1,
-		/obj/item/storage/box/syndie_kit/hardsuit = 1,
+		/obj/item/storage/box/syndie_kit/modsuit = 1,
 		/obj/item/clothing/shoes/magboots/syndie = 1,
 		/obj/item/clothing/suit/armor/vest/combat = 1,
 		/obj/item/ammo_box/magazine/m10mm = 1,
@@ -288,7 +300,9 @@
 		/obj/item/pen/edagger = 1,
 		/obj/item/stack/sheet/mineral/plasma{amount = 20} = 1,
 		/obj/item/stack/sheet/mineral/silver{amount = 20} = 1,
-		/obj/item/stack/sheet/mineral/gold{amount = 20} = 1)
+		/obj/item/stack/sheet/mineral/gold{amount = 20} = 1,
+		/obj/item/mod/module/noslip = 1,
+		/obj/item/mod/module/visor/night = 1)
 
 /obj/effect/spawner/random_spawners/syndicate/loot/level3
 	name = "officer loot"
@@ -316,7 +330,11 @@
 		/obj/item/ammo_box/magazine/m10mm/hp = 1,
 		/obj/item/storage/box/syndie_kit/emp = 1,
 		/obj/item/toy/plushie/carpplushie/dehy_carp = 1,
-		/obj/item/clothing/glasses/hud/security/chameleon = 1)
+		/obj/item/clothing/glasses/hud/security/chameleon = 1,
+		/obj/item/mod/module/visor/thermal = 1,
+		/obj/item/mod/module/stealth = 1,
+		/obj/item/mod/module/power_kick = 1)
+
 
 /obj/effect/spawner/random_spawners/syndicate/loot/level4
 	name = "armory loot"
@@ -335,7 +353,8 @@
 		/obj/item/clothing/glasses/thermal = 1,
 		/obj/item/chameleon = 1,
 		/obj/item/reagent_containers/hypospray/autoinjector/stimulants = 1,
-		/obj/item/grenade/plastic/c4/x4 = 1)
+		/obj/item/grenade/plastic/c4/x4 = 1,
+		/obj/item/storage/box/syndie_kit/modsuit/elite = 1)// Adding this as it is something an explorer can use to explore space better, that isn't a high powered murder weapon.
 
 
 // Layout-affecting spawns

code/game/objects/explosion.dm

@@ -198,6 +198,9 @@
 			if(istype(array, /obj/item/clothing/head/helmet/space/hardsuit/rd))
 				var/obj/item/clothing/head/helmet/space/hardsuit/rd/Helm_Array = array
 				Helm_Array.sense_explosion(x0,y0,z0,devastation_range,heavy_impact_range,light_impact_range,took,orig_dev_range,orig_heavy_range,orig_light_range)
+			if(istype(array, /obj/item/mod/module/reagent_scanner/advanced))
+				var/obj/item/mod/module/reagent_scanner/advanced/Mod_Array = array
+				Mod_Array.sense_explosion(x0,y0,z0,devastation_range,heavy_impact_range,light_impact_range,took,orig_dev_range,orig_heavy_range,orig_light_range)
 	return 1
 
 

code/game/objects/items.dm

@@ -133,6 +133,7 @@ GLOBAL_DATUM_INIT(welding_sparks, /mutable_appearance, mutable_appearance('icons
 	/// Holder var for the item outline filter, null when no outline filter on the item.
 	var/outline_filter
 
+
 /obj/item/New()
 	..()
 

code/game/objects/items/weapons/dice.dm

@@ -258,7 +258,7 @@
 				/obj/item/clothing/glasses/chameleon/thermal,
 				/obj/item/borg/upgrade/modkit/indoors,
 				/obj/item/storage/box/syndie_kit/chameleon,
-				/obj/item/storage/box/syndie_kit/hardsuit,
+				/obj/item/storage/box/syndie_kit/modsuit,
 				/obj/item/implanter/storage,
 				/obj/item/toy/syndicateballoon)
 			var/selected_item = pick(traitor_items)

code/game/objects/items/weapons/implants/implant_stealth.dm

@@ -24,7 +24,7 @@
 	/// If TRUE, the box can't be deployed
 	var/on_cooldown = FALSE
 
-/datum/action/item_action/agent_box/Trigger(trigger_flags)
+/datum/action/item_action/agent_box/Trigger(trigger_flags, left_click)
 	. = ..()
 	if(!.)
 		return FALSE

code/game/objects/items/weapons/implants/implantfluff.dm

@@ -123,6 +123,12 @@
 	name = "BioTech Solutions Comedy Bio-chip"
 	function = "Plays a sad trombone noise upon death of the implantee, allows clowns to entertain the crew even post-mortem."
 
+/datum/implant_fluff/pathfinder
+	name = "Paizo Productions 5-E Pathfinder Implant"
+	life = "Lasts 2-12 months. Known to fail at the worst possible time, space radation may be a factor."
+	notes = "By use of an internal private GPS signal, allows the pathfinder module to have the MODsuit find the user. Also wirelessly transfers ID information to the suit, to allow doors to open."
+	function = "Allows for the recall of a Modular Outerwear Device by the implant owner at any time."
+
 /datum/implant_fluff/gorilla_rampage
 	name = "Magillitis Serum Bio-chip"
 	life = "Unknown, no collected sample has been active long enough to determine lifespan."

code/game/objects/items/weapons/storage/lockbox.dm

@@ -125,9 +125,13 @@
 /obj/item/storage/lockbox/research/deconstruct(disassembled = TRUE) // Get wrecked, Science nerds
 	qdel(src)
 
-/obj/item/storage/lockbox/research/large
-	name = "Large lockbox"
-	desc = "A large lockbox"
-	max_w_class = WEIGHT_CLASS_BULKY
-	max_combined_w_class = 4 //The sum of the w_classes of all the items in this storage item.
-	storage_slots = 1
+/obj/item/storage/lockbox/research/modsuit
+	name = "Plating lockbox"
+	desc = "A larger lockbox. Looks a bit less secure than other lockboxes."
+
+/obj/item/storage/lockbox/research/modsuit/emp_act(severity) //I want emp to get around it, it's not a gun, I just want people not to always make sec / med modsuits.
+	. = ..()
+	if(prob(50 / severity))
+		locked = FALSE
+		icon_state = icon_broken
+		origin_tech = null //wipe out any origin tech if it's unlocked in any way so you can't double-dip tech levels at R&D.

code/game/objects/items/weapons/storage/uplink_kits.dm

@@ -132,14 +132,29 @@
 		/obj/item/gun/projectile/automatic/pistol, // 4TC
 		/obj/item/ammo_box/magazine/m10mm/fire, // 2TC
 		/obj/item/ammo_box/magazine/m10mm/fire, // 2TC
-		/obj/item/storage/box/syndie_kit/hardsuit, // 6TC
+		/obj/item/storage/box/syndie_kit/modsuit, // 6TC
 		/obj/item/clothing/gloves/combat, // 0TC
 		/obj/item/card/id/syndicate, // 2TC
 		/obj/item/clothing/shoes/chameleon/noslip, // 2TC
 		/obj/item/encryptionkey/syndicate) // 2TC
 
+	var/static/list/metroid = list( // 21 + modules + laser gun
+		/obj/item/storage/box/syndie_kit/modsuit/elite, // 9TC
+		/obj/item/mod/module/visor/thermal, // 3 TC
+		/obj/item/mod/module/stealth, //0 TC but strong
+		/obj/item/mod/module/power_kick, //0 TC but funny
+		/obj/item/mod/module/sphere_transform, //0TC but should not be allowed to normally be installed
+		/obj/item/autosurgeon/organ/syndicate/laser_arm, //0 TC but otherwise not obtainable.
+		/obj/item/pinpointer/advpinpointer, //4 TC
+		/obj/item/storage/box/syndidonkpockets, //2TC, otherwise they will just die in the first combat to disabler.
+		/obj/item/storage/belt/utility/full/multitool, //0 TC
+		/obj/item/clothing/head/collectable/slime,  //Priceless (0 TC)
+		/obj/item/encryptionkey/syndicate) //2 TC
+
+
+
 /obj/item/storage/box/syndie_kit/bundle/populate_contents()
-	var/list/bundle = pick(spy, agent13, thief, bond, infiltrator, payday, implant, hacker, darklord, professional, grenadier)
+	var/list/bundle = pick(spy, agent13, thief, bond, infiltrator, payday, implant, hacker, darklord, professional, grenadier, metroid)
 	for(var/item in bundle)
 		new item(src)
 
@@ -154,13 +169,21 @@
 	new /obj/item/clothing/mask/gas/syndicate(src)
 	new /obj/item/tank/internals/emergency_oxygen/engi/syndi(src)
 
-/obj/item/storage/box/syndie_kit/hardsuit
-	name = "Boxed Blood Red Suit and Helmet"
-	can_hold = list(/obj/item/clothing/suit/space/hardsuit/syndi, /obj/item/tank/internals/emergency_oxygen/engi/syndi, /obj/item/clothing/mask/gas/syndicate)
+/obj/item/storage/box/syndie_kit/modsuit
+	name = "Boxed Blood Red MODsuit"
+	can_hold = list(/obj/item/tank/internals/emergency_oxygen/engi/syndi, /obj/item/clothing/mask/gas/syndicate)
 	max_w_class = WEIGHT_CLASS_NORMAL
 
-/obj/item/storage/box/syndie_kit/hardsuit/populate_contents()
-	new /obj/item/clothing/suit/space/hardsuit/syndi(src)
+/obj/item/storage/box/syndie_kit/modsuit/populate_contents()
+	new /obj/item/mod/control/pre_equipped/traitor(src)
+	new /obj/item/clothing/mask/gas/syndicate(src)
+	new /obj/item/tank/internals/emergency_oxygen/engi/syndi(src)
+
+/obj/item/storage/box/syndie_kit/modsuit/elite //I have been informed this is a good idea.
+	name = "Boxed Elite MODsuit"
+
+/obj/item/storage/box/syndie_kit/modsuit/elite/populate_contents()
+	new /obj/item/mod/control/pre_equipped/traitor_elite(src)
 	new /obj/item/clothing/mask/gas/syndicate(src)
 	new /obj/item/tank/internals/emergency_oxygen/engi/syndi(src)
 

code/game/objects/items/weapons/tanks/jetpack.dm

@@ -133,11 +133,6 @@
 	item_state = "jetpack-captain"
 	volume = 90
 	w_class = WEIGHT_CLASS_NORMAL
-	resistance_flags = INDESTRUCTIBLE | LAVA_PROOF | FIRE_PROOF | ACID_PROOF //steal objective items are hard to destroy.
-
-/obj/item/tank/jetpack/oxygen/captain/Initialize(mapload)
-	. = ..()
-	RegisterSignal(src, COMSIG_PARENT_QDELETING, PROC_REF(alert_admins_on_destroy))
 
 /obj/item/tank/jetpack/oxygen/security
 	name = "security jetpack (oxygen)"

code/game/objects/structures/crates_lockers/closets/secure/engineering_lockers.dm

@@ -13,7 +13,7 @@
 	new /obj/item/areaeditor/blueprints/ce(src)
 	new /obj/item/storage/box/permits(src)
 	new /obj/item/storage/bag/garment/chief_engineer(src)
-	new /obj/item/tank/jetpack/suit(src)
+	new /obj/item/mod/module/jetpack/advanced(src)
 	new /obj/item/cartridge/ce(src)
 	new /obj/item/radio/headset/heads/ce(src)
 	new /obj/item/storage/toolbox/mechanical(src)

code/game/objects/structures/crates_lockers/closets/secure/medical_lockers.dm

@@ -197,15 +197,14 @@
 
 /obj/structure/closet/secure_closet/paramedic
 	name = "paramedic EVA gear"
-	desc = "A locker with a Paramedic EVA suit."
+	desc = "A locker with a Rescue MODsuit."
 	icon_state = "med"
 	open_door_sprite = "med_door"
 	icon_opened = "med_open"
 	req_access = list(ACCESS_PARAMEDIC)
 
 /obj/structure/closet/secure_closet/paramedic/populate_contents()
-	new /obj/item/clothing/suit/space/eva/paramedic(src)
-	new /obj/item/clothing/head/helmet/space/eva/paramedic(src)
+	new /obj/item/mod/control/pre_equipped/rescue(src)
 	new /obj/item/sensor_device(src)
 	new /obj/item/key/ambulance(src)
 	new /obj/item/pinpointer/crew(src)

code/game/objects/structures/crates_lockers/closets/secure/scientist.dm

@@ -25,6 +25,7 @@
 	open_door_sprite = "white_secure_door"
 
 /obj/structure/closet/secure_closet/roboticist/populate_contents()
+	new /obj/item/mod/core/standard(src)
 	new /obj/item/storage/backpack(src)
 	new /obj/item/storage/backpack(src)
 	new /obj/item/storage/backpack/satchel_norm(src)