diff --git a/_maps/map_files/Delta/delta.dmm b/_maps/map_files/Delta/delta.dmm index df66834ad48..42b31246fd2 100644 --- a/_maps/map_files/Delta/delta.dmm +++ b/_maps/map_files/Delta/delta.dmm @@ -64996,6 +64996,16 @@ /obj/item/crowbar/red, /turf/simulated/floor/plasteel/dark, /area/station/maintenance/apmaint) +"dSB" = ( +/obj/machinery/atmospherics/unary/portables_connector{ + dir = 8 + }, +/obj/machinery/atmospherics/portable/canister/air, +/obj/effect/turf_decal/stripes/line{ + dir = 10 + }, +/turf/simulated/floor/plasteel, +/area/station/hallway/secondary/exit) "dSD" = ( /obj/machinery/atmospherics/pipe/simple/hidden/scrubbers{ dir = 4 @@ -72194,16 +72204,6 @@ }, /turf/simulated/floor/plating, /area/station/command/office/rd) -"hli" = ( -/obj/machinery/atmospherics/unary/portables_connector{ - dir = 8 - }, -/obj/machinery/atmospherics/portable/canister/air, -/obj/effect/turf_decal/stripes/line{ - dir = 10 - }, -/turf/simulated/floor/plasteel, -/area/station/hallway/secondary/exit) "hly" = ( /obj/structure/table/wood, /turf/simulated/floor/plasteel/dark, @@ -74958,10 +74958,6 @@ icon_state = "bar" }, /area/station/service/kitchen) -"iVe" = ( -/obj/effect/spawner/airlock, -/turf/simulated/wall, -/area/station/service/chapel/office) "iVg" = ( /obj/machinery/economy/atm{ pixel_x = -32 @@ -76809,6 +76805,15 @@ icon_state = "whiteblue" }, /area/station/medical/storage) +"kdg" = ( +/obj/structure/sign/vacuum{ + pixel_x = -32 + }, +/obj/effect/turf_decal/stripes/line{ + dir = 8 + }, +/turf/simulated/floor/plasteel, +/area/station/hallway/secondary/exit) "kdm" = ( /obj/machinery/power/apc{ cell_type = 25000; @@ -76914,15 +76919,6 @@ }, /turf/simulated/floor/plasteel/dark, /area/station/medical/morgue) -"kfC" = ( -/obj/structure/sign/vacuum{ - pixel_x = -32 - }, -/obj/effect/turf_decal/stripes/line{ - dir = 8 - }, -/turf/simulated/floor/plasteel, -/area/station/hallway/secondary/exit) "kfT" = ( /obj/structure/cable{ d2 = 4; @@ -92665,21 +92661,6 @@ }, /turf/simulated/floor/plasteel, /area/station/science/research) -"tjT" = ( -/obj/item/radio/intercom{ - name = "west bump"; - pixel_x = -28 - }, -/obj/machinery/newscaster{ - dir = 1; - name = "south bump"; - pixel_y = -28 - }, -/obj/effect/turf_decal/stripes/line{ - dir = 10 - }, -/turf/simulated/floor/plasteel, -/area/station/hallway/secondary/exit) "tkb" = ( /obj/machinery/atmospherics/pipe/simple/hidden/supply{ dir = 6 @@ -93733,6 +93714,21 @@ /obj/effect/spawner/window/reinforced/grilled, /turf/simulated/floor/plating, /area/station/security/prison/cell_block) +"tSp" = ( +/obj/item/radio/intercom{ + name = "west bump"; + pixel_x = -28 + }, +/obj/machinery/newscaster{ + dir = 1; + name = "south bump"; + pixel_y = -28 + }, +/obj/effect/turf_decal/stripes/line{ + dir = 10 + }, +/turf/simulated/floor/plasteel, +/area/station/hallway/secondary/exit) "tSt" = ( /obj/structure/table, /obj/item/reagent_containers/drinks/drinkingglass{ @@ -94379,6 +94375,10 @@ icon_state = "darkred" }, /area/station/security/processing) +"uil" = ( +/obj/effect/spawner/airlock, +/turf/simulated/wall, +/area/station/service/chapel/office) "uit" = ( /obj/machinery/atmospherics/unary/vent_pump{ dir = 4; @@ -96463,7 +96463,6 @@ /area/station/command/office/hos) "vzU" = ( /obj/structure/closet/walllocker/emerglocker/north{ - pixel_y = 0; pixel_x = -32 }, /turf/simulated/floor/plating, @@ -138093,7 +138092,7 @@ dIx dIx dIx dIx -iVe +uil abj aaa aaa @@ -138604,7 +138603,7 @@ dPM dkq dSs dSP -hli +dSB dIH dIH dIH @@ -138862,8 +138861,8 @@ dKo dXJ dKo dUj -kfC -tjT +kdg +tSp dIH abj aaa diff --git a/_maps/map_files/MetaStation/MetaStation.dmm b/_maps/map_files/MetaStation/MetaStation.dmm index 3043021a08e..a15898601a5 100644 --- a/_maps/map_files/MetaStation/MetaStation.dmm +++ b/_maps/map_files/MetaStation/MetaStation.dmm @@ -23337,6 +23337,14 @@ icon_state = "darkbluecorners" }, /area/station/turret_protected/aisat/interior) +"bAB" = ( +/obj/structure/table/wood, +/obj/machinery/bottler, +/obj/structure/sign/poster/random{ + pixel_y = -32 + }, +/turf/simulated/floor/wood, +/area/station/service/bar) "bAC" = ( /turf/simulated/floor/plating/airless, /area/station/engineering/solar/auxport) @@ -31798,14 +31806,6 @@ }, /turf/simulated/floor/plasteel, /area/station/science/robotics) -"cdj" = ( -/obj/structure/table/wood, -/obj/machinery/bottler, -/obj/structure/sign/poster/random{ - pixel_y = -32 - }, -/turf/simulated/floor/wood, -/area/station/service/bar) "cdk" = ( /obj/machinery/atmospherics/pipe/simple/hidden/scrubbers{ dir = 4 @@ -32599,9 +32599,7 @@ /area/station/maintenance/starboard) "cfV" = ( /obj/structure/sink/puddle, -/obj/structure/flora/junglebush/large{ - pixel_y = 0 - }, +/obj/structure/flora/junglebush/large, /turf/simulated/floor/grass/no_creep, /area/station/medical/virology) "cfW" = ( @@ -37158,9 +37156,7 @@ dir = 8 }, /obj/structure/window/reinforced, -/obj/structure/flora/junglebush/large{ - pixel_y = 0 - }, +/obj/structure/flora/junglebush/large, /turf/simulated/floor/grass/no_creep, /area/station/medical/exam_room) "cxz" = ( @@ -47496,18 +47492,6 @@ icon_state = "red" }, /area/station/security/permabrig) -"dQI" = ( -/obj/structure/disposalpipe/segment{ - dir = 2; - icon_state = "pipe-c" - }, -/obj/structure/cable/yellow{ - d1 = 1; - d2 = 2; - icon_state = "1-2" - }, -/turf/simulated/floor/plasteel, -/area/station/science/research) "dRt" = ( /obj/effect/spawner/window/reinforced/grilled, /turf/simulated/floor/plating, @@ -61587,9 +61571,7 @@ dir = 4 }, /obj/structure/window/reinforced, -/obj/structure/flora/junglebush/large{ - pixel_y = 0 - }, +/obj/structure/flora/junglebush/large, /turf/simulated/floor/grass/no_creep, /area/station/medical/exam_room) "jNd" = ( @@ -68687,30 +68669,6 @@ }, /turf/simulated/floor/plating, /area/station/command/office/rd) -"mEd" = ( -/obj/structure/disposalpipe/sortjunction{ - dir = 4; - name = "Kitchen Junction"; - sort_type_txt = "20" - }, -/obj/machinery/atmospherics/pipe/manifold/hidden/scrubbers{ - dir = 1 - }, -/obj/machinery/atmospherics/pipe/manifold/hidden/supply{ - dir = 1 - }, -/obj/structure/cable/yellow{ - d1 = 4; - d2 = 8; - icon_state = "4-8" - }, -/obj/structure/cable/yellow{ - d1 = 2; - d2 = 8; - icon_state = "2-8" - }, -/turf/simulated/floor/wood, -/area/station/service/bar) "mEe" = ( /obj/structure/chair/office/dark{ dir = 8 @@ -81622,6 +81580,18 @@ /obj/effect/spawner/random_spawners/fungus_maybe, /turf/simulated/wall/r_wall, /area/station/public/mrchangs) +"sdj" = ( +/obj/structure/disposalpipe/segment{ + dir = 2; + icon_state = "pipe-c" + }, +/obj/structure/cable/yellow{ + d1 = 1; + d2 = 2; + icon_state = "1-2" + }, +/turf/simulated/floor/plasteel, +/area/station/science/research) "sdJ" = ( /obj/machinery/door/airlock/freezer, /obj/effect/mapping_helpers/airlock/access/all/service/kitchen, @@ -94247,6 +94217,30 @@ icon_state = "neutralcorner" }, /area/station/hallway/primary/central/north) +"xLw" = ( +/obj/structure/disposalpipe/sortjunction{ + dir = 4; + name = "Kitchen Junction"; + sort_type_txt = "20" + }, +/obj/machinery/atmospherics/pipe/manifold/hidden/scrubbers{ + dir = 1 + }, +/obj/machinery/atmospherics/pipe/manifold/hidden/supply{ + dir = 1 + }, +/obj/structure/cable/yellow{ + d1 = 4; + d2 = 8; + icon_state = "4-8" + }, +/obj/structure/cable/yellow{ + d1 = 2; + d2 = 8; + icon_state = "2-8" + }, +/turf/simulated/floor/wood, +/area/station/service/bar) "xLA" = ( /obj/machinery/hydroponics/constructable, /obj/machinery/atmospherics/pipe/manifold/hidden/scrubbers, @@ -130009,7 +130003,7 @@ byM bEA bvz bEv -mEd +xLw uhV lBQ fjy @@ -132616,7 +132610,7 @@ cQg rOD cDa mra -dQI +sdj vCB lHQ eIa @@ -132832,7 +132826,7 @@ bsp buI bwO pjb -cdj +bAB aoG aoG aoG diff --git a/_maps/map_files/cyberiad/cyberiad.dmm b/_maps/map_files/cyberiad/cyberiad.dmm index f10b3e5dc21..e6b1bba3c93 100644 --- a/_maps/map_files/cyberiad/cyberiad.dmm +++ b/_maps/map_files/cyberiad/cyberiad.dmm @@ -47265,9 +47265,7 @@ }, /area/station/command/office/ce) "cWE" = ( -/obj/structure/flora/tree/palm{ - pixel_x = 0 - }, +/obj/structure/flora/tree/palm, /obj/effect/overlay/coconut{ pixel_y = -6 }, diff --git a/tools/ci/check_grep.sh b/tools/ci/check_grep.sh deleted file mode 100755 index 7a6283f891c..00000000000 --- a/tools/ci/check_grep.sh +++ /dev/null @@ -1,59 +0,0 @@ -#!/bin/bash -set -euo pipefail - -#nb: must be bash to support shopt globstar -shopt -s globstar - -st=0 - -if grep -El '^\".+\" = \(.+\)' _maps/**/*.dmm; then - echo "ERROR: Non-TGM formatted map detected. Please convert it using Map Merger!" - st=1 -fi; -if grep -P '^\ttag = \"icon' _maps/**/*.dmm; then - echo "ERROR: tag vars from icon state generation detected in maps, please remove them." - st=1 -fi; -if grep -P 'pixel_[^xy]' _maps/**/*.dmm; then - echo "ERROR: Incorrect pixel offset variables detected in maps, please remove them." - st=1 -fi; -if grep -P 'step_[xy]' _maps/**/*.dmm; then - echo "ERROR: step_x/step_y variables detected in maps, please remove them." - st=1 -fi; - -if grep -P '^/[\w/]\S+\(.*(var/|, ?var/.*).*\)' code/**/*.dm; then - echo "ERROR: Changed files contains proc arguments with implicit 'var/', please remove them." - st=1 -fi; -if grep -P '^/*var/' code/**/*.dm; then - echo "ERROR: Unmanaged global var use detected in code, please use the helpers." - st=1 -fi; -# Check for merge conflict markers and their associated description text. -if grep -P 'Merge Conflict Marker' _maps/**/*.dmm; then - echo "ERROR: Merge conflict markers detected in map, please resolve all merge failures!" - st=1 -fi; -if grep -P '/obj/merge_conflict_marker' _maps/**/*.dmm; then - echo "ERROR: Merge conflict markers detected in map, please resolve all merge failures!" - st=1 -fi; -# Check for non-515 compatable .proc/ syntax -if grep -P --exclude='__byond_version_compat.dm' '(\.proc\/)|(CALLBACK\(.*proc\/)|(INVOKE_ASYNC\(.*proc\/)' code/**/*.dm; then - echo "ERROR: Outdated proc reference use detected in code, please use proc reference helpers." - st=1 -fi; -nl=' -' -nl=$'\n' -while read f; do - t=$(tail -c2 "$f"; printf x); r1="${nl}$"; r2="${nl}${r1}" - if [[ ! ${t%x} =~ $r1 ]]; then - echo "file $f is missing a trailing newline" - st=1 - fi; -done < <(find . -type f -name '*.dm') - -exit $st diff --git a/tools/maplint/lints/pixel_varedits.yml b/tools/maplint/lints/step_varedits.yml similarity index 100% rename from tools/maplint/lints/pixel_varedits.yml rename to tools/maplint/lints/step_varedits.yml