Adds CI for missing icon_states (#27063)

* Adds CI for missing icon_states * yeah * more fixes * more fixes * seems good * moar * fix * yea * hrtyhrt * yeah * WOE
2026-08-24 20:47:10 +01:00 · 2024-11-14 17:58:06 +00:00
parent da630e1b63
commit 8352613d03
74 changed files with 157 additions and 327 deletions
@@ -264,7 +264,7 @@
 	density = FALSE
 	layer = TURF_LAYER
 	icon = 'icons/effects/blood.dmi'
-	icon_state = "gibbl5"
+	icon_state = "mgibbl5"
 	random_icon_states = list("gib1", "gib2", "gib3", "gib4", "gib5", "gib6")
 	no_clear = TRUE
 	mergeable_decal = FALSE
@@ -28,7 +28,7 @@ GLOBAL_LIST_EMPTY(fluidtrack_cache)
 //BLOODY FOOTPRINTS
 /obj/effect/decal/cleanable/blood/footprints
 	icon = 'icons/effects/fluidtracks.dmi'
-	icon_state = "nothingwhatsoever"
+	icon_state = null
 	desc = "You REALLY shouldn't follow these.."
 	gender = PLURAL
 	random_icon_states = null
@@ -2,10 +2,6 @@
 	name = "sandy floor"
 	icon_state = "sandyfloor"

-/obj/effect/turf_decal/weather/snow
-	name = "snowy floor"
-	icon_state = "snowyfloor"
-
 /obj/effect/turf_decal/weather/snow/corner
 	name = "snow corner piece"
 	icon = 'icons/turf/snow.dmi'
@@ -60,7 +60,7 @@
 	max_integrity = 80

 /obj/effect/forcefield/mime/advanced
-	icon_state = "empty"
+	icon_state = null
 	name = "invisible blockade"
 	desc = "You might be here a while."
 	lifetime = 60 SECONDS
@@ -7,7 +7,8 @@
 	opacity = FALSE
 	density = FALSE
 	icon = 'icons/obj/lighting.dmi'
-	icon_state = "glowshroom" //replaced in New
+	icon_state = "glowshroomf"
+	base_icon_state = "glowshroom" //replaced in New
 	layer = ABOVE_NORMAL_TURF_LAYER
 	max_integrity = 30
 	var/floor = 0
@@ -20,13 +21,15 @@
 /obj/structure/glowshroom/glowcap
 	name = "glowcap"
 	desc = "Mycena Ruthenia, a species of mushroom that, while it does glow in the dark, is not actually bioluminescent."
-	icon_state = "glowcap"
+	icon_state = "glowcapf"
+	base_icon_state = "glowcap"
 	myseed = /obj/item/seeds/glowshroom/glowcap

 /obj/structure/glowshroom/shadowshroom
 	name = "shadowshroom"
 	desc = "Mycena Umbra, a species of mushroom that emits shadow instead of light."
-	icon_state = "shadowshroom"
+	icon_state = "shadowshroomf"
+	base_icon_state = "shadowshroom"
 	myseed = /obj/item/seeds/glowshroom/shadowshroom

 /obj/structure/glowshroom/shadowshroom/extinguish_light(force = FALSE)
@@ -54,7 +57,6 @@
 		var/datum/plant_gene/trait/glow/G = myseed.get_gene(/datum/plant_gene/trait/glow)
 		set_light(G.glow_range(myseed), G.glow_power(myseed), G.glow_color)
 	setDir(CalcDir())
-	var/base_icon_state = initial(icon_state)
 	if(!floor)
 		switch(dir) //offset to make it be on the wall rather than on the floor
 			if(NORTH)
@@ -13,8 +13,6 @@ GLOBAL_LIST_INIT(meteors_catastrophic, list(/obj/effect/meteor/medium = 3, /obj/

 GLOBAL_LIST_INIT(meteors_gore, list(/obj/effect/meteor/meaty = 5, /obj/effect/meteor/meaty/xeno = 1)) //for meaty ore event

-GLOBAL_LIST_INIT(meteors_ops, list(/obj/effect/meteor/goreops)) //Meaty Ops
-

 ///////////////////////////////
 //Meteor spawning global procs
@@ -334,30 +332,6 @@ GLOBAL_LIST_INIT(meteors_ops, list(/obj/effect/meteor/goreops)) //Meaty Ops
 	if(!isspaceturf(T))
 		new /obj/effect/decal/cleanable/blood/xeno(T)

-//Meteor Ops
-/obj/effect/meteor/goreops
-	name = "MeteorOps"
-	icon = 'icons/mob/animal.dmi'
-	icon_state = "syndicaterangedpsace"
-	hits = 10
-	hitpwr = EXPLODE_DEVASTATE
-	meteorsound = 'sound/effects/blobattack.ogg'
-	meteordrop = list(/obj/item/food/meat)
-	var/meteorgibs = /obj/effect/gibspawner/generic
-
-/obj/effect/meteor/goreops/make_debris()
-	..()
-	new meteorgibs(get_turf(src))
-
-
-/obj/effect/meteor/goreops/ram_turf(turf/T)
-	if(!isspaceturf(T))
-		new /obj/effect/decal/cleanable/blood(T)
-
-/obj/effect/meteor/goreops/Bump(atom/A)
-	A.ex_act(hitpwr)
-	get_hit()
-
 //////////////////////////
 //Spookoween meteors
 /////////////////////////
@@ -45,11 +45,6 @@
 	var/damage = 0.0
 	var/range = 10.0

-/obj/effect/begin
-	name = "begin"
-	icon = 'icons/obj/stationobjs.dmi'
-	icon_state = "begin"
-
 /obj/effect/projection
 	name = "Projection"
 	desc = "This looks like a projection of something."
@@ -99,7 +94,7 @@
 //Makes a tile fully lit no matter what
 /obj/effect/fullbright
 	icon = 'icons/effects/alphacolors.dmi'
-	icon_state = "white"
+	icon_state = null // null iconstate is white by default
 	plane = LIGHTING_PLANE
 	layer = LIGHTING_LAYER
 	blend_mode = BLEND_ADD
@@ -65,7 +65,7 @@
 /obj/effect/snow
 	desc = "Perfect for making snow angels, or throwing at other people!"
 	icon = 'icons/effects/effects.dmi'
-	icon_state = "snow"
+	icon_state = "snow1"
 	layer = ABOVE_ICYOVERLAY_LAYER

 /obj/effect/snow/New()
@@ -1,6 +1,7 @@
 //temporary visual effects(/obj/effect/temp_visual) used by cult stuff
 /obj/effect/temp_visual/cult
 	icon = 'icons/effects/cult_effects.dmi'
+	icon_state = null
 	randomdir = FALSE
 	duration = 10

@@ -1,5 +1,6 @@
 /obj/effect/temp_visual/dir_setting/bloodsplatter
 	icon = 'icons/effects/blood.dmi'
+	icon_state = null
 	duration = 5
 	randomdir = FALSE
 	layer = MOB_LAYER - 0.1
@@ -304,7 +305,7 @@
 	duration = 5

 /obj/effect/temp_visual/dir_setting/firing_effect
-	icon = 'icons/effects/effects.dmi'
+	icon = 'icons/effects/projectile.dmi'
 	icon_state = "firing_effect"
 	duration = 2

@@ -326,10 +327,6 @@
 	icon_state = "firing_effect_energy"
 	duration = 3

-/obj/effect/temp_visual/dir_setting/firing_effect/magic
-	icon_state = "shieldsparkles"
-	duration = 3
-
 /obj/effect/temp_visual/impact_effect
 	icon_state = "impact_bullet"
 	duration = 5
@@ -525,7 +522,7 @@
 	name = "\improper Bluespace energy wave"
 	desc = "A massive, rippling wave of bluepace energy, all rapidly exhausting itself the moment it leaves the concentrated beam of light."
 	icon = 'icons/effects/beam_splash.dmi'
-	icon_state = "beam_splash_l"
+	icon_state = "beam_splash_w"
 	layer = ABOVE_ALL_MOB_LAYER
 	pixel_y = -16
 	duration = 50
@@ -3,7 +3,7 @@
 /obj/effect/projectile
 	name = "pew"
 	icon = 'icons/obj/projectiles.dmi'
-	icon_state = "nothing"
+	icon_state = null
 	layer = HITSCAN_LAYER
 	mouse_opacity = MOUSE_OPACITY_TRANSPARENT
 	appearance_flags = LONG_GLIDE