From 8954b5aa2bdf8c8d409336268e3413d0e5ae466c Mon Sep 17 00:00:00 2001 From: Erthilo Date: Sat, 5 May 2012 22:05:50 +0100 Subject: [PATCH] TG: Doohl: Readme please: This 'fixes' a runtime that occurs when intercomms are tuned to frequencies they probably shouldn't be able to. I'm guessing there's no connection datum defined for those frequencies. Although, I'm clueless at telecomms stuff and I don't want to break anything. runtime error: Cannot read null.frequency proc name: Broadcast Message (/proc/Broadcast_Message) usr: null src: null call stack: Broadcast Message(null, S.I.G.M.A. (/mob/living/silicon/ai), 0, null, General Listening Channel (/obj/item/device/radio/intercom), "J.R. Bob Dobbs has signed up a...", "S.I.G.M.A.", "AI", "S.I.G.M.A.", "synthesized voice", 1, 0) General Listening Channel (/obj/item/device/radio/intercom): talk into(S.I.G.M.A. (/mob/living/silicon/ai), "J.R. Bob Dobbs has signed up a...", null) General Listening Channel (/obj/item/device/radio/intercom): hear talk(S.I.G.M.A. (/mob/living/silicon/ai), "J.R. Bob Dobbs has signed up a...") General Listening Channel (/obj/item/device/radio/intercom): hear talk(S.I.G.M.A. (/mob/living/silicon/ai), "J.R. Bob Dobbs has signed up a...") S.I.G.M.A. (/mob/living/silicon/ai): say("J.R. Bob Dobbs has signed up a...") I reproduced the problem on the centre private-intercomm in the AI upload by tuning it down to about 121.7 or something. Revision: r3474 Author: elly1...@rocketmail.com P.S. Sorry for the nag but Agouri would down-vote all the things if I hadn't tagged your name up there. :3 Also, removed some misplaced areas from the centcomm z-level (Quartermaster's storage and a teleport one) --- code/game/objects/radio/radio.dm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/code/game/objects/radio/radio.dm b/code/game/objects/radio/radio.dm index 0498b7aafee..e68dc18c11a 100644 --- a/code/game/objects/radio/radio.dm +++ b/code/game/objects/radio/radio.dm @@ -441,6 +441,9 @@ var/GLOBAL_RADIO_TYPE = 1 // radio type to use // Oh my god; the comms are down or something because the signal hasn't been broadcasted yet. // Send a mundane broadcast with limited targets: + //THIS IS TEMPORARY. + if(!connection) return //~Carn + Broadcast_Message(connection, M, voicemask, M.voice_message, src, message, displayname, jobname, real_name, M.voice_name, filter_type, signal.data["compression"])