From d9f4895f78c9ed26d2262226b441d1d4659b3f4b Mon Sep 17 00:00:00 2001 From: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com> Date: Wed, 3 Feb 2021 19:00:26 +0000 Subject: [PATCH 1/2] Initialized /obj/docking_port --- code/modules/shuttle/emergency.dm | 4 ++-- code/modules/shuttle/shuttle.dm | 16 ++++++---------- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/code/modules/shuttle/emergency.dm b/code/modules/shuttle/emergency.dm index 4b5a7a12f6e..10393b4921b 100644 --- a/code/modules/shuttle/emergency.dm +++ b/code/modules/shuttle/emergency.dm @@ -309,8 +309,8 @@ width = 3 height = 4 -/obj/docking_port/mobile/pod/New() - ..() +/obj/docking_port/mobile/pod/Initialize() + . = ..() if(id == "pod") WARNING("[type] id has not been changed from the default. Use the id convention \"pod1\" \"pod2\" etc.") diff --git a/code/modules/shuttle/shuttle.dm b/code/modules/shuttle/shuttle.dm index 0040befd063..4c3c7a90065 100644 --- a/code/modules/shuttle/shuttle.dm +++ b/code/modules/shuttle/shuttle.dm @@ -168,8 +168,8 @@ /obj/docking_port/stationary/register() if(!SSshuttle) - throw EXCEPTION("docking port [src] could not initialize.") - return 0 + stack_trace("Docking port [src] could not initialize. SSshuttle doesnt exist!") + return FALSE SSshuttle.stationary += src if(!id) @@ -229,9 +229,8 @@ var/obj/docking_port/stationary/destination var/obj/docking_port/stationary/previous -/obj/docking_port/mobile/New() - ..() - +/obj/docking_port/mobile/Initialize() + . = ..() var/area/A = get_area(src) if(istype(A, /area/shuttle)) areaInstance = A @@ -245,7 +244,6 @@ highlight("#0f0") #endif -/obj/docking_port/mobile/Initialize() if(!timid) register() shuttle_areas = list() @@ -255,12 +253,10 @@ var/area/cur_area = curT.loc if(istype(cur_area, areaInstance)) shuttle_areas[cur_area] = TRUE - ..() /obj/docking_port/mobile/register() if(!SSshuttle) - throw EXCEPTION("docking port [src] could not initialize.") - return 0 + CRASH("Docking port [src] could not initialize. SSshuttle doesnt exist!") SSshuttle.mobile += src @@ -322,7 +318,7 @@ else var/msg = "check_dock(): shuttle [src] cannot dock at [S], error: [status]" message_admins(msg) - throw EXCEPTION(msg) + stack_trace(msg) return FALSE From 6b47d10f00d2023a942e66fd06f784a6825d4e38 Mon Sep 17 00:00:00 2001 From: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com> Date: Wed, 3 Feb 2021 20:44:37 +0000 Subject: [PATCH 2/2] Mapload arg --- code/modules/shuttle/emergency.dm | 2 +- code/modules/shuttle/shuttle.dm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/code/modules/shuttle/emergency.dm b/code/modules/shuttle/emergency.dm index 10393b4921b..1686be9b083 100644 --- a/code/modules/shuttle/emergency.dm +++ b/code/modules/shuttle/emergency.dm @@ -309,7 +309,7 @@ width = 3 height = 4 -/obj/docking_port/mobile/pod/Initialize() +/obj/docking_port/mobile/pod/Initialize(mapload) . = ..() if(id == "pod") WARNING("[type] id has not been changed from the default. Use the id convention \"pod1\" \"pod2\" etc.") diff --git a/code/modules/shuttle/shuttle.dm b/code/modules/shuttle/shuttle.dm index 4c3c7a90065..3985c449be5 100644 --- a/code/modules/shuttle/shuttle.dm +++ b/code/modules/shuttle/shuttle.dm @@ -229,7 +229,7 @@ var/obj/docking_port/stationary/destination var/obj/docking_port/stationary/previous -/obj/docking_port/mobile/Initialize() +/obj/docking_port/mobile/Initialize(mapload) . = ..() var/area/A = get_area(src) if(istype(A, /area/shuttle))