Adds Play Internet Sound (#28183)

* death to the OGG * lint * adresses issues * nukes shells * sounds should still stop even if you muted someone * Update code/modules/admin/verbs/playsound.dm Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com> Signed-off-by: Bm0n <92271472+Bm0n@users.noreply.github.com> * deconflict * as mentioned * minortypomoment * i prefer this wording * updates catches and moves admin logging.fixes span * fixes another weird edge case with muting admins * 516 support * linters? * further idiot proofing * typescript player update * more typescript player updates --------- Signed-off-by: Bm0n <92271472+Bm0n@users.noreply.github.com> Co-authored-by: Bmon <no@email.com> Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2026-07-20 19:44:09 +01:00 · 2025-02-27 16:57:30 -05:00
parent 8e6c2f3d8c
commit 8bec408c29
11 changed files with 346 additions and 242 deletions
@@ -81,7 +81,8 @@ GLOBAL_LIST_INIT(admin_verbs_sounds, list(
 	/client/proc/play_server_sound,
 	/client/proc/play_intercomm_sound,
 	/client/proc/stop_global_admin_sounds,
-	/client/proc/stop_sounds_global
+	/client/proc/stop_sounds_global,
+	/client/proc/play_web_sound
 	))
 GLOBAL_LIST_INIT(admin_verbs_event, list(
 	/client/proc/object_talk,
@@ -12,6 +12,8 @@ GLOBAL_LIST_EMPTY(sounds_cache)
 	message_admins("[key_name_admin(src)] stopped admin sounds.", 1)
 	for(var/mob/M in GLOB.player_list)
 		M << awful_sound
+		var/client/C = M.client
+		C?.tgui_panel?.stop_music()

 /client/proc/play_sound(S as sound)
 	set category = "Event"
@@ -127,3 +129,108 @@ GLOBAL_LIST_EMPTY(sounds_cache)
 		SEND_SOUND(M, sound(null))
 		var/client/C = M.client
 		C?.tgui_panel?.stop_music()
+
+/client/proc/play_web_sound()
+	set category = "Event"
+	set name = "Play Internet Sound"
+	if(!check_rights(R_SOUNDS))
+		return
+
+	if(!GLOB.configuration.system.ytdlp_url)
+		to_chat(src, "<span class='boldwarning'>yt-dlp was not configured, action unavailable</span>") //Check config
+		return
+
+
+	var/web_sound_input = tgui_input_text(src, "Enter content URL (supported sites only, leave blank to stop playing)", "Play Internet Sound", null)
+	if(istext(web_sound_input))
+		var/web_sound_url = ""
+		var/stop_web_sounds = FALSE
+		var/list/music_extra_data = list()
+		if(length(web_sound_input))
+			web_sound_input = trim(web_sound_input)
+			if(findtext(web_sound_input, ":") && !findtext(web_sound_input, GLOB.is_http_protocol))
+				to_chat(src, "<span class='boldwarning'>Non-http(s) URIs are not allowed.</span>")
+				to_chat(src, "<span class='warning'>For yt-dlp shortcuts like ytsearch: please use the appropriate full url from the website.</span>")
+				return
+
+			// Prepare the body
+			var/list/request_body = list("url" = web_sound_input)
+			// Send the request off
+			var/datum/http_request/media_poll_request = new()
+			// The fact we are using GET with a body offends me
+			media_poll_request.prepare(RUSTG_HTTP_METHOD_GET, GLOB.configuration.system.ytdlp_url, json_encode(request_body))
+			// Start it off and wait
+			media_poll_request.begin_async()
+			UNTIL(media_poll_request.is_complete())
+			var/datum/http_response/media_poll_response = media_poll_request.into_response()
+
+			if(media_poll_response.status_code == 200)
+				var/list/data
+				try
+					data = json_decode(media_poll_response.body)
+				catch(var/exception/e)
+					to_chat(src, "<span class='boldwarning'>yt-dlp JSON parsing FAILED:</span>")
+					to_chat(src, "<span class='warning'>[e]: [media_poll_response.body]</span>")
+					return
+
+				if(data["sound_url"])
+					web_sound_url = data["sound_url"]
+					var/title = "[data["title"]]"
+					var/webpage_url = title
+					if(data["webpage_url"])
+						webpage_url = "<a href=\"[data["webpage_url"]]\">[title]</a>"
+					music_extra_data["start"] = data["start"]
+					music_extra_data["end"] = data["end"]
+					music_extra_data["link"] = data["webpage_url"]
+					music_extra_data["title"] = data["title"]
+
+					var/res = tgui_alert(src, "Show the title of and link to this song to the players?\n[title]", "Show Info?", list("Yes", "No", "Cancel"))
+					switch(res)
+						if("Yes")
+							log_admin("[key_name(src)] played web sound: [web_sound_input]")
+							message_admins("[key_name(src)] played web sound: [web_sound_input]")
+							to_chat(world, "<span class='boldannounceooc'>[src.ckey] played: [webpage_url]</span>")
+						if("No")
+							music_extra_data["link"] = "Song Link Hidden"
+							music_extra_data["title"] = "Song Title Hidden"
+							music_extra_data["artist"] = "Song Artist Hidden"
+							log_admin("[key_name(src)] played web sound: [web_sound_input]")
+							message_admins("[key_name(src)] played web sound: [web_sound_input]")
+							to_chat(world, "<span class='boldannounceooc'>[src.ckey] played an internet sound</span>")
+						if("Cancel")
+							return
+
+					SSblackbox.record_feedback("tally", "admin_verb", 1, "Play Internet Sound")
+
+			else
+				to_chat(src, "<span class='boldwarning'>yt-dlp URL retrieval FAILED:</span>")
+				to_chat(src, "<span class='warning'>[media_poll_response.body]</span>")
+
+		else //pressed ok with blank
+			log_admin("[key_name(src)] stopped web sound")
+			message_admins("[key_name(src)] stopped web sound")
+			web_sound_url = null
+			stop_web_sounds = TRUE
+
+		if(web_sound_url && !findtext(web_sound_url, GLOB.is_http_protocol))
+			to_chat(src, "<span class='boldwarning'>BLOCKED: Content URL not using http(s) protocol</span>", confidential = TRUE)
+			to_chat(src, "<span class='warning'>The media provider returned a content URL that isn't using the HTTP or HTTPS protocol</span>", confidential = TRUE)
+			return
+
+		if(web_sound_url || stop_web_sounds)
+			for(var/mob/M in GLOB.player_list)
+				var/client/C = M.client
+				var/this_uid = M.client.UID()
+				if(stop_web_sounds)
+					C.tgui_panel?.stop_music()
+					continue
+				if(C.prefs.sound & SOUND_MIDI)
+					if(ckey in M.client.prefs.admin_sound_ckey_ignore)
+						to_chat(C, "<span class='warning'>But [src.ckey] is muted locally in preferences!</span>")
+						continue
+					else
+						C.tgui_panel?.play_music(web_sound_url, music_extra_data)
+						to_chat(C, "<span class='warning'>(<a href='byond://?src=[this_uid];action=silenceSound'>SILENCE</a>) (<a href='byond://?src=[this_uid];action=muteAdmin&a=[ckey]'>ALWAYS SILENCE THIS ADMIN</a>)</span>")
+				else
+					to_chat(C, "<span class='warning'>But Admin MIDIs are disabled in preferences!</span>")
+	return