From 8c0ea90d194a5e9dfb1f60686633733b5cb67852 Mon Sep 17 00:00:00 2001 From: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com> Date: Sun, 27 Mar 2022 06:27:00 -0400 Subject: [PATCH] BRPED provides user feedback for out-of-range exchanges and prevents false-positive logs (#17527) * feedback change * better fix * even better fix * Update code/game/objects/items/weapons/stock_parts.dm Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com> Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com> --- code/game/objects/items/weapons/stock_parts.dm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/code/game/objects/items/weapons/stock_parts.dm b/code/game/objects/items/weapons/stock_parts.dm index 95d4cd92448..f98ee3630c1 100644 --- a/code/game/objects/items/weapons/stock_parts.dm +++ b/code/game/objects/items/weapons/stock_parts.dm @@ -24,12 +24,14 @@ /obj/item/storage/part_replacer/afterattack(obj/machinery/M, mob/user, flag, params) if(!flag && works_from_distance && istype(M)) // Make sure its in range - if(M in view(user)) + if(get_dist(src, M) <= (user.client.view + 2)) if(M.component_parts) M.exchange_parts(user, src) user.Beam(M,icon_state="rped_upgrade", icon='icons/effects/effects.dmi', time=5) else message_admins("\[EXPLOIT] [key_name_admin(user)] attempted to upgrade machinery with a BRPED via a camera console. (Attempted range exploit)") + playsound(src, 'sound/machines/synth_no.ogg', 15, TRUE) + to_chat(user, "ERROR: [M] is out of [src]'s range!") /obj/item/storage/part_replacer/bluespace name = "bluespace rapid part exchange device"