From c6b221d268678eb1cd4266fb583d7612efd44f21 Mon Sep 17 00:00:00 2001 From: Kugamo Date: Wed, 2 Sep 2020 09:51:27 -0500 Subject: [PATCH 1/3] Fixes Wingdings --- code/game/dna/genes/disabilities.dm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/code/game/dna/genes/disabilities.dm b/code/game/dna/genes/disabilities.dm index 8b8a86009b9..eccbb557031 100644 --- a/code/game/dna/genes/disabilities.dm +++ b/code/game/dna/genes/disabilities.dm @@ -249,14 +249,14 @@ block = GLOB.wingdingsblock /datum/dna/gene/disability/wingdings/OnSay(mob/M, message) - var/list/chars = string2charlist(message) var/garbled_message = "" - for(var/C in chars) - if(C in GLOB.alphabet_uppercase) + var/messagelength = length(message) + for(var/i=1;i<=messagelength;i++) + if(message[i] in GLOB.alphabet_uppercase) garbled_message += pick(GLOB.alphabet_uppercase) - else if(C in GLOB.alphabet) + else if(message[i] in GLOB.alphabet) garbled_message += pick(GLOB.alphabet) else - garbled_message += C + garbled_message += message[i] message = garbled_message return message From 13d02fabb1a5bfef99c95d56958c2e44633a78a6 Mon Sep 17 00:00:00 2001 From: Kugamo Date: Wed, 2 Sep 2020 10:10:32 -0500 Subject: [PATCH 2/3] removes string2charlist(), fixes spacing --- code/__HELPERS/text.dm | 2 -- code/game/dna/genes/disabilities.dm | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/code/__HELPERS/text.dm b/code/__HELPERS/text.dm index 47650177283..034e8851c18 100644 --- a/code/__HELPERS/text.dm +++ b/code/__HELPERS/text.dm @@ -615,5 +615,3 @@ proc/checkhtml(var/t) text = replacetext(text, "", "\[cell\]") text = replacetext(text, "", "\[logo\]") return text - -#define string2charlist(string) (splittext(string, regex("(\\x0A|.)")) - splittext(string, "")) diff --git a/code/game/dna/genes/disabilities.dm b/code/game/dna/genes/disabilities.dm index eccbb557031..41cc32c9ce9 100644 --- a/code/game/dna/genes/disabilities.dm +++ b/code/game/dna/genes/disabilities.dm @@ -251,7 +251,7 @@ /datum/dna/gene/disability/wingdings/OnSay(mob/M, message) var/garbled_message = "" var/messagelength = length(message) - for(var/i=1;i<=messagelength;i++) + for(var/i = 1; i <= messagelength; i++) if(message[i] in GLOB.alphabet_uppercase) garbled_message += pick(GLOB.alphabet_uppercase) else if(message[i] in GLOB.alphabet) From b2239bb8fa295d2d4cd2f7a6576f6275571d1563 Mon Sep 17 00:00:00 2001 From: Kugamo Date: Wed, 2 Sep 2020 10:22:45 -0500 Subject: [PATCH 3/3] implaments faster for loop logic --- code/game/dna/genes/disabilities.dm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/code/game/dna/genes/disabilities.dm b/code/game/dna/genes/disabilities.dm index 41cc32c9ce9..a887959db48 100644 --- a/code/game/dna/genes/disabilities.dm +++ b/code/game/dna/genes/disabilities.dm @@ -250,8 +250,7 @@ /datum/dna/gene/disability/wingdings/OnSay(mob/M, message) var/garbled_message = "" - var/messagelength = length(message) - for(var/i = 1; i <= messagelength; i++) + for(var/i in 1 to length(message)) if(message[i] in GLOB.alphabet_uppercase) garbled_message += pick(GLOB.alphabet_uppercase) else if(message[i] in GLOB.alphabet)