Annihilates the blackbox (#15132)

* Lets get this show on the road

* Now were talking

* These matter

* Oh the joys of CI testing

* And this

* Wrong version

* Tweaks

* More tweaks

* Lets document this

* This too

* Upgrades this

* Fixed some sanity issues

* This too

* Screw it, this too

* More sanity

* And these

* This too

* Documentation

* This too

* Fixes **awful** scoreboard logic

* Why do we care about only half-absorbing someone

* Revert "Why do we care about only half-absorbing someone"

This reverts commit 8de1cfdf05.

* Refactors these

* Hashing

* Moxian tweaks

code/game/objects/items/robot/robot_parts.dm

@@ -136,7 +136,7 @@
 	if(l_arm && r_arm)
 		if(l_leg && r_leg)
 			if(chest && head)
-				feedback_inc("cyborg_frames_built",1)
+				SSblackbox.record_feedback("amount", "cyborg_frames_built", 1)
 				return 1
 	return 0
 
@@ -307,7 +307,7 @@
 			O.mmi = W
 			O.Namepick()
 
-			feedback_inc("cyborg_birth",1)
+			SSblackbox.record_feedback("amount", "cyborg_birth", 1)
 
 			forceMove(O)
 			O.robot_suit = src

code/game/objects/items/weapons/handcuffs.dm

@@ -54,10 +54,7 @@
 		if(do_mob(user, C, 30))
 			apply_cuffs(C, user, remove_src)
 			to_chat(user, "<span class='notice'>You handcuff [C].</span>")
-			if(istype(src, /obj/item/restraints/handcuffs/cable))
-				feedback_add_details("handcuffs", "C")
-			else
-				feedback_add_details("handcuffs", "H")
+			SSblackbox.record_feedback("tally", "handcuffs", 1, type)
 
 			add_attack_logs(user, C, "Handcuffed ([src])")
 		else

code/game/objects/items/weapons/holy_weapons.dm

@@ -79,7 +79,7 @@
 	var/picked_type = variant_names[choice]
 	var/obj/item/nullrod/new_rod = new picked_type(get_turf(user))
 
-	feedback_set_details("chaplain_weapon", "[picked_type]")
+	SSblackbox.record_feedback("text", "chaplain_weapon", 1, "[picked_type]", 1)
 
 	if(new_rod)
 		new_rod.reskinned = TRUE

code/game/objects/items/weapons/legcuffs.dm

@@ -117,7 +117,7 @@
 					H.legcuffed = src
 					forceMove(H)
 					H.update_inv_legcuffed()
-					feedback_add_details("handcuffs","B") //Yes, I know they're legcuffs. Don't change this, no need for an extra variable. The "B" is used to tell them apart.
+					SSblackbox.record_feedback("tally", "handcuffs", 1, type)
 
 			else
 				L.apply_damage(trap_damage, BRUTE)
@@ -169,7 +169,7 @@
 		C.legcuffed = src
 		forceMove(C)
 		C.update_inv_legcuffed()
-		feedback_add_details("handcuffs","B")
+		SSblackbox.record_feedback("tally", "handcuffs", 1, type)
 		to_chat(C, "<span class='userdanger'>[src] ensnares you!</span>")
 		C.Weaken(weaken)
 		playsound(loc, hitsound, 50, TRUE)

code/game/objects/items/weapons/storage/bible.dm

@@ -169,7 +169,7 @@
 				if(T.icon_state == "carpetsymbol")
 					T.dir = carpet_dir*/
 
-	feedback_set_details("religion_book", "[choice]")
+	SSblackbox.record_feedback("text", "religion_book", 1, "[choice]", 1)
 
 	if(SSticker)
 		SSticker.Bible_name = name