Remove (almost) unused var/item_color from /obj/item (#30453)

* it's black and white

* Update soft_caps.dm

* bruh

* bruh

* tweaks

* comment

* Update abduction_gear.dm

* Update paradise.dme

* Update paradise.dme

* Update paradise.dme

---------

Co-authored-by: Mason <116982774+Burzah@users.noreply.github.com>
This commit is contained in:
kyunkyunkyun
2025-10-06 17:59:46 +00:00
committed by GitHub
co-authored by Mason
parent 3ebacb5459
commit 9b095a559d
83 changed files with 228 additions and 841 deletions
@@ -586,7 +586,7 @@ GLOBAL_LIST_EMPTY(damage_icon_parts)
if(!wear_suit || !(wear_suit.flags_inv & HIDEJUMPSUIT))
var/worn_icon = listgetindex(w_uniform.sprite_sheets, dna.species.sprite_sheet_name) || w_uniform.worn_icon || 'icons/mob/clothing/under/misc.dmi'
var/worn_icon_state = w_uniform.item_color || w_uniform.worn_icon_state || w_uniform.icon_state
var/worn_icon_state = w_uniform.worn_icon_state || w_uniform.icon_state
var/mutable_appearance/standing = mutable_appearance(worn_icon, "[worn_icon_state]_s", layer = -UNIFORM_LAYER, alpha = w_uniform.alpha, color = w_uniform.color)
if(w_uniform.blood_DNA)
@@ -597,7 +597,7 @@ GLOBAL_LIST_EMPTY(damage_icon_parts)
if(length(w_uniform.accessories)) //WE CHECKED THE TYPE ABOVE. THIS REALLY SHOULD BE FINE. // oh my god kys whoever made this if statement jfc :gun:
for(var/obj/item/clothing/accessory/A in w_uniform.accessories)
var/tie_icon = A.worn_icon || listgetindex(A.sprite_sheets, dna.species.sprite_sheet_name) || 'icons/mob/accessories.dmi'
var/tie_color = A.item_color || A.icon_state
var/tie_color = A.worn_icon_state || A.icon_state
standing.overlays += image(tie_icon, tie_color)
overlays_standing[UNIFORM_LAYER] = standing
@@ -3,7 +3,6 @@
desc = "It looks like it was tailored for a monkey."
icon_state = "punpun"
worn_icon = 'icons/mob/clothing/under/misc.dmi'
item_color = "punpun"
species_restricted = list("Monkey")
species_exception = list(/datum/species/monkey)
@@ -263,7 +263,6 @@
desc = "A cloak which lts you travel through a perfect reflection of the world."
icon = 'icons/obj/lavaland/elite_trophies.dmi'
icon_state = "herald_cloak"
item_color = "herald_cloak"
actions_types = list(/datum/action/item_action/herald)
/obj/item/clothing/neck/cloak/herald_cloak/item_action_slot_check(slot)
@@ -207,7 +207,6 @@
desc = "Found at the bottom of Pandora. After all the evil was released, this was the only thing left inside."
icon = 'icons/obj/lavaland/elite_trophies.dmi'
icon_state = "hope"
item_color = "hope"
allow_duplicates = FALSE
resistance_flags = FIRE_PROOF