Adds CI checks forbidding certain kinds of world loops (#24454)

* Updates checkgrep to report unnecessary loops

* improved message

* global lists are better too

* much better

* Apply suggestions from code review

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* update to modern check_grep format

---------

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
This commit is contained in:
Luc
2024-03-20 20:17:45 +00:00
committed by GitHub
co-authored by GDN S34N
parent d1c77ea8fb
commit 9efffccd71
7 changed files with 27 additions and 4 deletions
@@ -118,7 +118,7 @@
var/atom/movable/screen/text/blurb/location_blurb = new()
if(antag_check.antag_datums)
for(var/datum/antagonist/role)
for(var/datum/antagonist/role in antag_check.antag_datums)
if(role.custom_blurb())
location_blurb.blurb_text = uppertext(role.custom_blurb())
location_blurb.text_color = role.blurb_text_color