Adds CI checks forbidding certain kinds of world loops (#24454)

* Updates checkgrep to report unnecessary loops

* improved message

* global lists are better too

* much better

* Apply suggestions from code review

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* update to modern check_grep format

---------

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
This commit is contained in:
Luc
2024-03-20 20:17:45 +00:00
committed by GitHub
co-authored by GDN S34N
parent d1c77ea8fb
commit 9efffccd71
7 changed files with 27 additions and 4 deletions
+1 -1
View File
@@ -22,7 +22,7 @@
/datum/station_goal/bluespace_cannon/check_completion()
if(..())
return TRUE
for(var/obj/machinery/bsa/full/B)
for(var/obj/machinery/bsa/full/B in GLOB.machines)
if(B && !B.stat && is_station_contact(B.z))
return TRUE
return FALSE