Fixes ticker roundstart being slow (#15129)

This commit is contained in:
AffectedArc07
2020-12-17 18:31:49 +00:00
committed by GitHub
parent 04e6806a4b
commit a4283d707a
6 changed files with 13 additions and 10 deletions
+1 -1
View File
@@ -572,7 +572,7 @@
// Log player connections to DB
var/datum/db_query/query_accesslog = SSdbcore.NewQuery("INSERT INTO `[format_table_name("connection_log")]`(`datetime`,`ckey`,`ip`,`computerid`) VALUES(Now(), :ckey, :ip, :cid)", list(
"ckey" = ckey,
"ip" = address,
"ip" = "[address ? address : ""]", // This is important. NULL is not the same as "", and if you directly open the `.dmb` file, you get a NULL IP.
"cid" = computer_id
))
// We do nothing with output here, or anything else after, so we dont need to if() wrap it
@@ -129,7 +129,7 @@
"slot" = slot,
"ckey" = C.ckey
))
if(!firstquery.warn_execute())
if(!firstquery.warn_execute(async = FALSE)) // Dont make this async. It makes roundstart slow.
qdel(firstquery)
return
qdel(firstquery)
@@ -192,7 +192,7 @@
"ckey" = C.ckey,
"slot" = slot
))
if(!query.warn_execute())
if(!query.warn_execute(async = FALSE)) // Dont make this async. It makes roundstart slow.
qdel(query)
return
@@ -481,7 +481,7 @@
qdel(firstquery)
qdel(query)
return 1
qdel(firstquery)
var/datum/db_query/query = SSdbcore.NewQuery({"
@@ -612,7 +612,7 @@
))
var/list/saves = list()
if(!query.warn_execute())
if(!query.warn_execute(async = FALSE)) // Dont async this. Youll make roundstart slow.
qdel(query)
return
@@ -633,7 +633,7 @@
"ckey" = C.ckey,
"slot" = default_slot
))
if(!query.warn_execute())
qdel(query)
return
+1 -1
View File
@@ -9,7 +9,7 @@
"ckey" = M.ckey,
"realname" = M.real_name
))
if(!query.warn_execute())
if(!query.warn_execute(async = FALSE)) // Dont make this async. Youll make roundstart slow. Trust me.
qdel(query)
return
+1 -1
View File
@@ -42,7 +42,7 @@
qdel(query)
// If our query failed, just assume yes
tos_consent = TRUE
return TRUE
return TRUE
while(query.NextRow())
qdel(query)