Convert most spans to defines (#31080)

* spanish?

* aaaagain

* keep maptext

* Update robot_items.dm

* Update span_defines.dm

* compiles

* Update silicon_mob.dm

* compile

code/modules/shuttle/dock_generator.dm

@@ -14,8 +14,8 @@
 	. = ..()
 	var/count = max_docks - length(placed_docks)
 	var/plural = count > 1
-	. += "<span class='notice'>There [plural ? "are" : "is"] [count] use[plural ? "s" : ""] left.</span>"
-	. += "<span class='notice'><b>Alt-Click</b> to call the ship to an existing docking area.</span>"
+	. += SPAN_NOTICE("There [plural ? "are" : "is"] [count] use[plural ? "s" : ""] left.")
+	. += SPAN_NOTICE("<b>Alt-Click</b> to call the ship to an existing docking area.")
 
 /obj/item/whiteship_port_generator/activate_self(mob/user)
 	. = FINISH_ATTACK
@@ -25,17 +25,17 @@
 
 	if(is_station_level(user.z))
 		log_admin("[key_name(user)] attempted to create a whiteship dock in the station's sector at [COORD(user)].")
-		to_chat(user, "<span class='notice'>New docking areas cannot be designated within the station's sector!</span>")
+		to_chat(user, SPAN_NOTICE("New docking areas cannot be designated within the station's sector!"))
 		return
 
 	if(is_admin_level(user.z))
 		log_admin("[key_name(user)] attempted to create a whiteship dock on Centcomm level at [COORD(user)].")
-		to_chat(user, "<span class='notice'>New docking areas cannot be designated in this sector!</span>")
+		to_chat(user, SPAN_NOTICE("New docking areas cannot be designated in this sector!"))
 		return
 
 	if(is_mining_level(user.z))
 		log_admin("[key_name(user)] attempted to create a whiteship dock on Lavaland at [COORD(user)].")
-		to_chat(user, "<span class='notice'>New docking areas cannot be designated planet side!</span>")
+		to_chat(user, SPAN_NOTICE("New docking areas cannot be designated planet side!"))
 		return
 
 	var/list/docks_per_z = list()
@@ -45,13 +45,13 @@
 		docks_per_z["[placed_dock.z]"]++
 
 	if(docks_per_z["[user.z]"] >= 3)
-		to_chat(user, "<span class='notice'>This sector cannot support any more docking areas!</span>")
+		to_chat(user, SPAN_NOTICE("This sector cannot support any more docking areas!"))
 		return
 
 	var/list/dir_choices = list("North" = NORTH, "East" = EAST, "South" = SOUTH, "West" = WEST)
 	var/dir_choice = tgui_input_list(user, "Select the new docking area orientation.", "Dock Orientation", dir_choices)
 	if(!dir_choice)
-		to_chat(user, "<span class='notice'>Docking placement cancelled.</span>")
+		to_chat(user, SPAN_NOTICE("Docking placement cancelled."))
 		return
 
 	var/dest_dir = dir_choices[dir_choice]
@@ -71,23 +71,23 @@
 		max_x = max_x < 0 ? T.x : max(max_x, T.x)
 		max_y = max_y < 0 ? T.y : max(max_y, T.y)
 		if(!isspaceturf(T))
-			to_chat(user, "<span class='notice'>Obstruction found in docking space area, aborting!</span>")
+			to_chat(user, SPAN_NOTICE("Obstruction found in docking space area, aborting!"))
 			qdel(port, force = TRUE)
 			return
 		for(var/obj/O in T.contents)
 			if(O == port)
 				continue
 			else
-				to_chat(user, "<span class='notice'>Objects found in docking space area, aborting!</span>")
+				to_chat(user, SPAN_NOTICE("Objects found in docking space area, aborting!"))
 				qdel(port, force = TRUE)
 				return
 
 	if(min_x <= TRANSITION_BORDER_WEST + 1 || max_x >= TRANSITION_BORDER_EAST - 1)
-		to_chat(user, "<span class='notice'>Docking space area too close to edge of sector, aborting!</span>")
+		to_chat(user, SPAN_NOTICE("Docking space area too close to edge of sector, aborting!"))
 		qdel(port, force = TRUE)
 		return
 	if(min_y <= TRANSITION_BORDER_SOUTH + 1 || max_y >= TRANSITION_BORDER_NORTH - 1)
-		to_chat(user, "<span class='notice'>Docking space area too close to edge of sector, aborting!</span>")
+		to_chat(user, SPAN_NOTICE("Docking space area too close to edge of sector, aborting!"))
 		qdel(port, force = TRUE)
 		return
 
@@ -99,7 +99,7 @@
 		max_length = 20
 	)
 	if(!name)
-		to_chat(user, "<span class='notice'>Docking placement cancelled.</span>")
+		to_chat(user, SPAN_NOTICE("Docking placement cancelled."))
 		qdel(port, force = TRUE)
 		return
 
@@ -116,7 +116,7 @@
 		possible_destinations = S.possible_destinations
 
 	log_admin("[key_name(user)] created a whiteship dock named '[name]' at [COORD(port)].")
-	to_chat(user, "<span class='notice'>Landing zone set.</span>")
+	to_chat(user, SPAN_NOTICE("Landing zone set."))
 
 /obj/item/whiteship_port_generator/AltClick(mob/user, modifiers)
 	for(var/obj/machinery/computer/shuttle/white_ship/S in SSmachines.get_by_type(/obj/machinery/computer/shuttle/white_ship))
@@ -162,13 +162,13 @@
 	if(..())	//we can't actually interact, so no action
 		return TRUE
 	if(!allowed(usr))
-		to_chat(usr, "<span class='danger'>Access denied.</span>")
+		to_chat(usr, SPAN_DANGER("Access denied."))
 		return TRUE
 	var/list/options = params2list(possible_destinations)
 	if(action == "move")
 		var/destination = params["move"]
 		if(!options.Find(destination))//figure out if this translation works
-			message_admins("<span class='boldannounceooc'>EXPLOIT:</span> [ADMIN_LOOKUPFLW(usr)] attempted to move [src] to an invalid location! [ADMIN_COORDJMP(src)]")
+			message_admins("[SPAN_BOLDANNOUNCEOOC("EXPLOIT:")] [ADMIN_LOOKUPFLW(usr)] attempted to move [src] to an invalid location! [ADMIN_COORDJMP(src)]")
 			return
 		switch(SSshuttle.moveShuttle(shuttleId, destination, TRUE, usr))
 			if(0)
@@ -177,9 +177,9 @@
 				add_fingerprint(usr)
 				return TRUE
 			if(1)
-				to_chat(usr, "<span class='warning'>Invalid shuttle requested.</span>")
+				to_chat(usr, SPAN_WARNING("Invalid shuttle requested."))
 			if(2)
-				to_chat(usr, "<span class='notice'>Unable to comply.</span>")
+				to_chat(usr, SPAN_NOTICE("Unable to comply."))
 			if(3)
 				atom_say("Shuttle is regenerating fuel. Please wait...")
 			if(4)

code/modules/shuttle/emergency.dm

@@ -31,10 +31,10 @@
 	if(hijack_announce)
 		. += "Security systems present on console. Any unauthorized tampering will result in an emergency announcement, and a fee of 20000 credits."
 	if(user?.mind?.get_hijack_speed())
-		. += "<span class='danger'>Alt click on this to attempt to hijack the shuttle. This will take multiple tries (current: stage [SSshuttle.emergency.hijack_status]/[HIJACKED]).</span>"
-		. += "<span class='danger'>It will take you [user.mind.get_hijack_speed() / 10] seconds to reprogram a stage of the shuttle's navigational firmware, and the console will undergo automated timed lockout for [hijack_stage_cooldown / 10] seconds after each stage.</span>"
+		. += SPAN_DANGER("Alt click on this to attempt to hijack the shuttle. This will take multiple tries (current: stage [SSshuttle.emergency.hijack_status]/[HIJACKED]).")
+		. += SPAN_DANGER("It will take you [user.mind.get_hijack_speed() / 10] seconds to reprogram a stage of the shuttle's navigational firmware, and the console will undergo automated timed lockout for [hijack_stage_cooldown / 10] seconds after each stage.")
 		if(hijack_announce)
-			. += "<span class='warning'>It is probably best to fortify your position as to be uninterrupted during the attempt, given the automatic announcements...</span>"
+			. += SPAN_WARNING("It is probably best to fortify your position as to be uninterrupted during the attempt, given the automatic announcements...")
 
 /obj/machinery/computer/emergency_shuttle/item_interaction(mob/living/user, obj/item/used, list/modifiers)
 	if(stat & (BROKEN|NOPOWER))
@@ -161,7 +161,7 @@
 	update_icon()
 	AI.cancel_camera()
 	AI.can_shunt = FALSE //ONE AI ENTERS. NO AI LEAVES.
-	to_chat(AI, "<span class='userdanger'>You are now loaded into the shuttle computer. Make sure command does not wipe you from it, there is no going back...</span>")
+	to_chat(AI, SPAN_USERDANGER("You are now loaded into the shuttle computer. Make sure command does not wipe you from it, there is no going back..."))
 	SSshuttle.emergency.aihacked = TRUE
 	authorized.Cut() //In case command was already swiping to early launch or something
 
@@ -198,11 +198,11 @@
 	if(!ishuman(user) && !is_ai) //No, xenomorphs, constructs and traitors in cyborgs can not hack it.
 		return
 	if(HAS_TRAIT(user, TRAIT_HANDS_BLOCKED))
-		to_chat(user, "<span class='warning'>You need your hands free before you can manipulate [src].</span>")
+		to_chat(user, SPAN_WARNING("You need your hands free before you can manipulate [src]."))
 		return
 	var/speed = user.mind?.get_hijack_speed()
 	if(!speed)
-		to_chat(user, "<span class='warning'>You manage to open a user-mode shell on [src], and hundreds of lines of debugging output fly through your vision. It is probably best to leave this alone.</span>")
+		to_chat(user, SPAN_WARNING("You manage to open a user-mode shell on [src], and hundreds of lines of debugging output fly through your vision. It is probably best to leave this alone."))
 		return
 	if(is_ai && isnull(windows_33_exe))
 		var/mob/living/silicon/ai/AI = user
@@ -215,13 +215,13 @@
 	if(hijack_hacking)
 		return
 	if(SSshuttle.emergency.hijack_status >= HIJACKED)
-		to_chat(user, "<span class='warning'>The emergency shuttle is already loaded with a corrupt navigational payload. What more do you want from it?</span>")
+		to_chat(user, SPAN_WARNING("The emergency shuttle is already loaded with a corrupt navigational payload. What more do you want from it?"))
 		return
 	if(hijack_last_stage_increase >= world.time - hijack_stage_cooldown)
 		atom_say("ACCESS DENIED: Console is temporarily on security lockdown. Please try again.")
 		return
 	hijack_hacking = TRUE
-	to_chat(user, "<span class='userdanger'>You [SSshuttle.emergency.hijack_status == NOT_BEGUN ? "begin" : "continue"] to override [src]'s navigational protocols.</span>")
+	to_chat(user, SPAN_USERDANGER("You [SSshuttle.emergency.hijack_status == NOT_BEGUN ? "begin" : "continue"] to override [src]'s navigational protocols."))
 	atom_say("Software override initiated.")
 	playsound(src, 'sound/machines/terminal_on.ogg', 100, FALSE)
 	var/turf/console_hijack_turf = get_turf(src)
@@ -233,8 +233,8 @@
 		message_admins("[ADMIN_LOOKUPFLW(user)] has hijacked [src] in [ADMIN_VERBOSEJMP(console_hijack_turf)]. Hijack stage increased to stage [SSshuttle.emergency.hijack_status] out of [HIJACKED].")
 		log_game("[key_name(usr)] has hijacked [src]. Hijack stage increased to stage [SSshuttle.emergency.hijack_status] out of [HIJACKED].")
 		. = TRUE
-		to_chat(user, "<span class='notice'>You fiddle with [src]'s programming and manage to get a foothold, looks like it'll take [hijack_stage_cooldown / 10] seconds before you can try again!</span>")
-		visible_message("<span class='danger'>[user.name] appears to be tampering with [src].</span>")
+		to_chat(user, SPAN_NOTICE("You fiddle with [src]'s programming and manage to get a foothold, looks like it'll take [hijack_stage_cooldown / 10] seconds before you can try again!"))
+		visible_message(SPAN_DANGER("[user.name] appears to be tampering with [src]."))
 	hijack_hacking = FALSE
 
 /obj/machinery/computer/emergency_shuttle/proc/announce_hijack_stage()
@@ -264,7 +264,7 @@
 
 
 /obj/machinery/computer/emergency_shuttle/proc/announce_here(a_header = "Emergency Shuttle", a_text = "")
-	var/msg_text = "<b><font size=4 color='red'>[a_header]</font><br> <font size=3><span class='robot'>[a_text]</font></font></b></span>"
+	var/msg_text = "<b><font size=4 color='red'>[a_header]</font><br> <font size=3>[SPAN_ROBOT("[a_text]</font></font></b>")]"
 	for(var/mob/R in range(35, src)) //Normal escape shutttle is 30 tiles from console to bottom. Extra range for if we ever get a bigger shuttle. Would do in shuttle area, doesn't account for mechs and such,
 		to_chat(R, msg_text)
 		SEND_SOUND(R, sound('sound/misc/notice1.ogg'))

code/modules/shuttle/lance_docking_targeter.dm

@@ -16,7 +16,7 @@
 /obj/item/lance_docking_generator/emag_act(mob/user)
 	if(!emagged)
 		emagged = TRUE
-		to_chat(user, "<span class='notice'>You emag [src], removing its docking safeties.</span>")
+		to_chat(user, SPAN_NOTICE("You emag [src], removing its docking safeties."))
 		var/turf/T = get_turf(src)
 		do_sparks(5, FALSE, T)
 		playsound(T, "sparks", 50, TRUE, SHORT_RANGE_SOUND_EXTRARANGE)
@@ -24,7 +24,7 @@
 
 /obj/item/lance_docking_generator/attack_self__legacy__attackchain(mob/living/user)
 	if(!is_station_level(user.z))
-		to_chat(user, "<span class='warning'>You'll want this to dock on the station.</span>")
+		to_chat(user, SPAN_WARNING("You'll want this to dock on the station."))
 		return
 	var/list/dir_choices = list("North" = NORTH, "East" = EAST, "South" = SOUTH, "West" = WEST)
 	var/dir_choice = tgui_input_list(user, "Which direction should the shuttle approach from?", "Dock Orientation", dir_choices)
@@ -49,16 +49,16 @@
 		max_y = max_y < 0 ? T.y : max(max_y, T.y)
 		for(var/obj/O in T.contents)
 			if((istype(O, /obj/machinery/atmospherics/supermatter_crystal) || istype(O, /obj/singularity)) && !emagged)
-				to_chat(user, "<span class='warning'>Dangerous landing conditions, aborting!</span>")
+				to_chat(user, SPAN_WARNING("Dangerous landing conditions, aborting!"))
 				qdel(port, force = TRUE)
 				return
 
 	if(min_x <= TRANSITION_BORDER_WEST + 1 || max_x >= TRANSITION_BORDER_EAST - 1)
-		to_chat(user, "<span class='warning'>Docking space area too close to edge of sector, aborting!</span>")
+		to_chat(user, SPAN_WARNING("Docking space area too close to edge of sector, aborting!"))
 		qdel(port, force = TRUE)
 		return
 	if(min_y <= TRANSITION_BORDER_SOUTH + 1 || max_y >= TRANSITION_BORDER_NORTH - 1)
-		to_chat(user, "<span class='warning'>Docking space area too close to edge of sector, aborting!</span>")
+		to_chat(user, SPAN_WARNING("Docking space area too close to edge of sector, aborting!"))
 		qdel(port, force = TRUE)
 		return
 	var/list/L2 = list()
@@ -74,13 +74,13 @@
 	for(var/turf/BT in L2)
 		for(var/obj/Ohno in BT.contents)
 			if((istype(Ohno, /obj/machinery/atmospherics/supermatter_crystal) || istype(Ohno, /obj/singularity)) && !emagged)
-				to_chat(user, "<span class='warning'>Dangerous landing conditions, aborting!</span>")
+				to_chat(user, SPAN_WARNING("Dangerous landing conditions, aborting!"))
 				qdel(port, force = TRUE)
 				return
 	port.register()
 
 	log_admin("[key_name(user)] created the lance docking location at [COORD(port)].")
-	to_chat(user, "<span class='notice'>Landing zone set. The signaller vanishes!</span>")
+	to_chat(user, SPAN_NOTICE("Landing zone set. The signaller vanishes!"))
 	new /obj/structure/lance_beacon(get_turf(src))
 	qdel(src)
 

code/modules/shuttle/navigation_computer.dm

@@ -37,7 +37,7 @@
 
 /obj/machinery/computer/camera_advanced/shuttle_docker/attack_hand(mob/user)
 	if(!shuttle_port && !SSshuttle.getShuttle(shuttleId))
-		to_chat(user,"<span class='warning'>Warning: Shuttle connection severed!</span>")
+		to_chat(user,SPAN_WARNING("Warning: Shuttle connection severed!"))
 		return
 	return ..()
 
@@ -108,23 +108,23 @@
 	var/mob/camera/eye/shuttle_docker/the_eye = eyeobj
 	var/landing_clear = check_landing_spot()
 	if(designate_time && (landing_clear != SHUTTLE_DOCKER_BLOCKED))
-		to_chat(current_user, "<span class='warning'>Targeting transit location, please wait [DisplayTimeText(designate_time)]...</span>")
+		to_chat(current_user, SPAN_WARNING("Targeting transit location, please wait [DisplayTimeText(designate_time)]..."))
 		designating_target_loc = the_eye.loc
 		var/wait_completed = do_after(current_user, designate_time, FALSE, designating_target_loc, TRUE, CALLBACK(src, PROC_REF(canDesignateTarget)))
 		designating_target_loc = null
 		if(!current_user)
 			return
 		if(!wait_completed)
-			to_chat(current_user, "<span class='warning'>Operation aborted.</span>")
+			to_chat(current_user, SPAN_WARNING("Operation aborted."))
 			return
 		landing_clear = check_landing_spot()
 
 	if(landing_clear != SHUTTLE_DOCKER_LANDING_CLEAR)
 		switch(landing_clear)
 			if(SHUTTLE_DOCKER_BLOCKED)
-				to_chat(current_user, "<span class='warning'>Invalid transit location</span>")
+				to_chat(current_user, SPAN_WARNING("Invalid transit location"))
 			if(SHUTTLE_DOCKER_BLOCKED_BY_HIDDEN_PORT)
-				to_chat(current_user, "<span class='warning'>Unknown object detected in landing zone. Please designate another location.</span>")
+				to_chat(current_user, SPAN_WARNING("Unknown object detected in landing zone. Please designate another location."))
 		return
 
 	if(!my_port)
@@ -155,7 +155,7 @@
 
 	if(current_user.client)
 		current_user.client.images += the_eye.placed_images
-		to_chat(current_user, "<span class='notice'>Transit location designated</span>")
+		to_chat(current_user, SPAN_NOTICE("Transit location designated"))
 	return
 
 /obj/machinery/computer/camera_advanced/shuttle_docker/proc/canDesignateTarget()
@@ -311,6 +311,6 @@
 		if(T)
 			playsound(console, 'sound/machines/terminal_prompt_confirm.ogg', 25, 0)
 			remote_eye.set_loc(T)
-			to_chat(target, "<span class='notice'>Jumped to [selected]</span>")
+			to_chat(target, SPAN_NOTICE("Jumped to [selected]"))
 	else
 		playsound(console, 'sound/machines/terminal_prompt_deny.ogg', 25, 0)

code/modules/shuttle/shuttle.dm

@@ -1056,7 +1056,7 @@
 	if(..())	//we can't actually interact, so no action
 		return TRUE
 	if(!allowed(usr))
-		to_chat(usr, "<span class='danger'>Access denied.</span>")
+		to_chat(usr, SPAN_DANGER("Access denied."))
 		return	TRUE
 	if(!can_call_shuttle(usr, action))
 		return TRUE
@@ -1064,7 +1064,7 @@
 	if(action == "move")
 		var/destination = params["move"]
 		if(!options.Find(destination))//figure out if this translation works
-			message_admins("<span class='boldannounceooc'>EXPLOIT:</span> [ADMIN_LOOKUPFLW(usr)] attempted to move [src] to an invalid location! [ADMIN_COORDJMP(src)]")
+			message_admins("[SPAN_BOLDANNOUNCEOOC("EXPLOIT:")] [ADMIN_LOOKUPFLW(usr)] attempted to move [src] to an invalid location! [ADMIN_COORDJMP(src)]")
 			return
 		switch(SSshuttle.moveShuttle(shuttleId, destination, TRUE, usr))
 			if(0)
@@ -1075,9 +1075,9 @@
 				add_fingerprint(usr)
 				return TRUE
 			if(1)
-				to_chat(usr, "<span class='warning'>Invalid shuttle requested.</span>")
+				to_chat(usr, SPAN_WARNING("Invalid shuttle requested."))
 			if(2)
-				to_chat(usr, "<span class='notice'>Unable to comply.</span>")
+				to_chat(usr, SPAN_NOTICE("Unable to comply."))
 			if(3)
 				atom_say("Shuttle is refuelling at dock. Please wait...")
 			if(4)
@@ -1089,7 +1089,7 @@
 	if(!emagged)
 		src.req_access = list()
 		emagged = TRUE
-		to_chat(user, "<span class='notice'>You fried the consoles ID checking system.</span>")
+		to_chat(user, SPAN_NOTICE("You fried the consoles ID checking system."))
 		return TRUE
 
 //for restricting when the computer can be used, needed for some console subtypes.
@@ -1118,7 +1118,7 @@
 		if(world.time < next_request)
 			return
 		next_request = world.time + 60 SECONDS	//1 minute cooldown
-		to_chat(usr, "<span class='notice'>Your request has been received by Centcom.</span>")
+		to_chat(usr, SPAN_NOTICE("Your request has been received by Centcom."))
 		log_admin("[key_name(usr)] requested to move the transport ferry to Centcom.")
 		message_admins("<b>FERRY: <font color='#EB4E00'>[key_name_admin(usr)] (<A href='byond://?_src_=holder;secretsfun=moveferry'>Move Ferry</a>)</b> is requesting to move the transport ferry to Centcom.</font>")
 		return TRUE

code/modules/shuttle/shuttle_manipulator.dm

@@ -141,7 +141,7 @@
 	if(..())
 		return
 	if(shuttle_and_preview_cooldown > world.time)
-		to_chat(usr, "<span class='warning'>Please wait until the desired shuttle has finished being loaded.</span>")
+		to_chat(usr, SPAN_WARNING("Please wait until the desired shuttle has finished being loaded."))
 		return
 	. = TRUE
 

code/modules/shuttle/supply.dm

@@ -321,11 +321,11 @@
 		credit_changes[item.account] += item.credits
 
 		if(item.credits > 0)
-			msg += "<span class='good'>[item.account.account_name] +[item.credits]</span>: [item.reason]<br>"
+			msg += "[SPAN_GOOD("[item.account.account_name] +[item.credits]")]: [item.reason]<br>"
 		else if(item.credits == 0)
 			msg += "<span class='[item.zero_is_good ? "good" : "bad"]'>[item.account.account_name] Notice</span>: [item.reason]<br>"
 		else
-			msg += "<span class='bad'>[item.account.account_name] [item.credits]</span>: [item.reason]<br>"
+			msg += "[SPAN_BAD("[item.account.account_name] [item.credits]")]: [item.reason]<br>"
 
 		if(item.requests_console_department)
 			if(!department_messages[item.requests_console_department])

code/modules/shuttle/syndicate_shuttles.dm

@@ -23,7 +23,7 @@
 	var/time_to_go = max(SYNDICATE_CHALLENGE_TIMER, (challenge_time + 10 MINUTES))
 	if(action == "move")
 		if(challenge && world.time < time_to_go)
-			to_chat(user, "<span class='warning'>You've issued a combat challenge to the station! You've got to give them at least [round(((time_to_go - world.time) / 10) / 60)] more minutes to allow them to prepare.</span>")
+			to_chat(user, SPAN_WARNING("You've issued a combat challenge to the station! You've got to give them at least [round(((time_to_go - world.time) / 10) / 60)] more minutes to allow them to prepare."))
 			return FALSE
 	return TRUE
 
@@ -39,7 +39,7 @@
 /obj/machinery/computer/shuttle/syndicate/drop_pod/can_call_shuttle(user, action)
 	if(action == "move")
 		if(z != level_name_to_num(CENTCOMM))
-			to_chat(user, "<span class='warning'>Pods are one way!</span>")
+			to_chat(user, SPAN_WARNING("Pods are one way!"))
 			return FALSE
 	return ..()