From 9d3b7f50b4c1a21da9b860e8b8c36e6d14e18093 Mon Sep 17 00:00:00 2001 From: FreeStylaLT Date: Thu, 25 Jan 2018 16:11:13 +0200 Subject: [PATCH 1/2] Prevents mentors from seeing stealthed admins --- code/game/verbs/ooc.dm | 4 ++-- code/modules/admin/verbs/adminsay.dm | 8 +++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/code/game/verbs/ooc.dm b/code/game/verbs/ooc.dm index e3bb99d52fe..6d67c43da01 100644 --- a/code/game/verbs/ooc.dm +++ b/code/game/verbs/ooc.dm @@ -60,7 +60,7 @@ var/global/admin_ooc_colour = "#b82e00" for(var/client/C in clients) if(C.prefs.toggles & CHAT_OOC) - var/display_name = src.key + var/display_name = key if(prefs.unlock_content) if(prefs.toggles & MEMBER_PUBLIC) @@ -74,7 +74,7 @@ var/global/admin_ooc_colour = "#b82e00" if(holder) if(holder.fakekey) - if(C.holder) + if(C.holder && C.holder.rights & R_ADMIN) display_name = "[holder.fakekey]/([src.key])" else display_name = holder.fakekey diff --git a/code/modules/admin/verbs/adminsay.dm b/code/modules/admin/verbs/adminsay.dm index 7c7569e5907..cbcacc43006 100644 --- a/code/modules/admin/verbs/adminsay.dm +++ b/code/modules/admin/verbs/adminsay.dm @@ -32,7 +32,13 @@ for(var/client/C in admins) if(check_rights(R_ADMIN|R_MOD|R_MENTOR, 0, C.mob)) - to_chat(C, "MENTOR: [key_name(usr, 1)] ([admin_jump_link(mob)]): [msg]") + var/display_name = key + if(holder.fakekey) + if(C.holder && C.holder.rights & R_ADMIN) + display_name = "[holder.fakekey]/([key])" + else + display_name = holder.fakekey + to_chat(C, "MENTOR: [display_name] ([admin_jump_link(mob)]): [msg]") feedback_add_details("admin_verb","MS") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc! From c5e216e02f75578bace6983c82da1c1fa734d1d6 Mon Sep 17 00:00:00 2001 From: FreeStylaLT Date: Thu, 25 Jan 2018 16:14:30 +0200 Subject: [PATCH 2/2] loose src --- code/game/verbs/ooc.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/game/verbs/ooc.dm b/code/game/verbs/ooc.dm index 6d67c43da01..cd68b0ec3b0 100644 --- a/code/game/verbs/ooc.dm +++ b/code/game/verbs/ooc.dm @@ -75,7 +75,7 @@ var/global/admin_ooc_colour = "#b82e00" if(holder) if(holder.fakekey) if(C.holder && C.holder.rights & R_ADMIN) - display_name = "[holder.fakekey]/([src.key])" + display_name = "[holder.fakekey]/([key])" else display_name = holder.fakekey