From b4dd74689ea1a4d290ffd0cbefa35e246eca1dd7 Mon Sep 17 00:00:00 2001
From: Arthri <41360489+Arthri@users.noreply.github.com>
Date: Sat, 17 Feb 2024 21:34:34 +0800
Subject: [PATCH] Fix misleading CI error when linting fails (#24200)

* Fix misleading CI error

* Intentionally make /tg/ui build fail

* Revert "Intentionally make /tg/ui build fail"

This reverts commit cb7bbe3e6d712b4d4601fbec066ecd222de950cc.

* Intentionally trigger dreamchecker

* Ignore exit code

* Fix error disappearing

* Revert "Intentionally trigger dreamchecker"

This reverts commit a2187b7ce947d122926985e0aec24ddf26fe8b6b.

* Undo autoformat

---------

Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
---
 .github/workflows/ci.yml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 39dee619625..a294c4b493c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -38,10 +38,13 @@ jobs:
           python tools/ci/illegal_dme_files.py ${GITHUB_WORKSPACE}
           python -m tools.ci.check_icon_conflicts
           python -m tools.maplint.source --github
-          ~/dreamchecker > ${GITHUB_WORKSPACE}/output-annotations.txt 2>&1
+          DREAMCHECKER_EXIT_CODE=0
+          ~/dreamchecker > ${GITHUB_WORKSPACE}/output-annotations.txt 2>&1 || DREAMCHECKER_EXIT_CODE=$?
+          echo 'DREAMCHECKER_ANNOTATED=1' >> "$GITHUB_ENV"
+          exit $DREAMCHECKER_EXIT_CODE
       - name: Annotate Lints
         uses: yogstation13/DreamAnnotate@v2
-        if: always()
+        if: ${{ always() && env.DREAMCHECKER_ANNOTATED == '1' }}
         with:
           outputFile: output-annotations.txt