cyberpresidentvanellope/Paradise
1
0
Fork 0
mirror of https://github.com/ParadiseSS13/Paradise.git synced 2025-12-21 07:42:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes & Improvements

Browse Source 
- Makes new players be listed first in the Check Playtime list, so they
are easy to find.
- Fixes a bug with mentor playtime list not actually working for
mentors.
- Fixes the Check Player Age panel not having working "FLW" links, and
potentially showing antag status to mentors.
This commit is contained in:
Kyep
2017-02-13 23:12:57 -08:00
parent 836d62864f
commit b7855481f6
4 changed files with 35 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
code/defines/procs/admin.dm
View File

@@ -48,6 +48,12 @@
var/message = "[key_name(whom, 1, include_name)](<A HREF='?_src_=holder;adminmoreinfo=\ref[whom]'>?</A>)[isAntag(whom) ? "<font color='red'>(A)</font>" : ""][isLivingSSD(whom) ? "<span class='danger'>(SSD!)</span>" : ""] ([admin_jump_link(whom)])" var/message = "[key_name(whom, 1, include_name)](<A HREF='?_src_=holder;adminmoreinfo=\ref[whom]'>?</A>)[isAntag(whom) ? "<font color='red'>(A)</font>" : ""][isLivingSSD(whom) ? "<span class='danger'>(SSD!)</span>" : ""] ([admin_jump_link(whom)])"
return message return message
/proc/key_name_mentor(var/whom, var/include_name = 1)
// Same as key_name_admin, but does not include (?) or (A) for antags.
var/message = "[key_name(whom, 1, include_name)] [isLivingSSD(whom) ? "<span class='danger'>(SSD!)</span>" : ""] ([admin_jump_link(whom)])"
return message
/proc/log_and_message_admins(var/message as text) /proc/log_and_message_admins(var/message as text)
log_admin("[key_name(usr)] " + message) log_admin("[key_name(usr)] " + message)
message_admins("[key_name_admin(usr)] " + message) message_admins("[key_name_admin(usr)] " + message)

30
code/game/jobs/job_exp.dm
View File

@@ -3,20 +3,38 @@
/client/proc/cmd_mentor_check_player_exp() //Allows admins to determine who the newer players are. /client/proc/cmd_mentor_check_player_exp() //Allows admins to determine who the newer players are.
set category = "Admin" set category = "Admin"
set name = "Check Player Playtime" set name = "Check Player Playtime"
if(!check_rights(R_ADMIN)) if(!check_rights(R_ADMIN|R_MOD|R_MENTOR))
return return
var/msg = "<html><head><title>Playtime Report</title></head><body>Playtime:<BR><UL>" var/msg = "<html><head><title>Playtime Report</title></head><body>"
var/list/players_new = list()
var/list/players_old = list()
var/pline
for(var/client/C in clients) for(var/client/C in clients)
msg += "<LI> [key_name_admin(C.mob)]: <A href='?_src_=holder;getplaytimewindow=[C.mob.UID()]'>" + C.get_exp_living() + "</a></LI>" if(check_rights(R_ADMIN))
msg += "</UL></BODY></HTML>" pline = "<LI> [key_name_admin(C.mob)]: <A href='?_src_=holder;getplaytimewindow=[C.mob.UID()]'>" + C.get_exp_living() + "</a></LI>"
else
pline = "<LI> [key_name_mentor(C.mob)]: <A href='?_src_=holder;getplaytimewindow=[C.mob.UID()]'>" + C.get_exp_living() + "</a></LI>"
if(C.get_exp_living_num() > 1200)
players_old += pline
else
players_new += pline
if(players_new.len)
msg += "<BR>Players under 20h:<BR><UL>"
msg += players_new.Join()
msg += "</UL>"
if(players_old.len)
msg += "<BR>Players over 20h:<BR><UL>"
msg += players_old.Join()
msg += "</UL>"
msg += "</BODY></HTML>"
src << browse(msg, "window=Player_playtime_check") src << browse(msg, "window=Player_playtime_check")
/datum/admins/proc/cmd_show_exp_panel(var/client/C) /datum/admins/proc/cmd_mentor_show_exp_panel(var/client/C)
if(!C) if(!C)
to_chat(usr, "ERROR: Client not found.") to_chat(usr, "ERROR: Client not found.")
return return
if(!check_rights(R_ADMIN)) if(!check_rights(R_ADMIN|R_MOD|R_MENTOR))
return return
var/body = "<html><head><title>Playtime for [C.key]</title></head><BODY><BR>Playtime:" var/body = "<html><head><title>Playtime for [C.key]</title></head><BODY><BR>Playtime:"
body += C.get_exp_report() body += C.get_exp_report()

2
code/modules/admin/topic.dm
View File

@@ -2031,7 +2031,7 @@
if(!M) if(!M)
to_chat(usr, "ERROR: Mob not found.") to_chat(usr, "ERROR: Mob not found.")
return return
cmd_show_exp_panel(M.client) cmd_mentor_show_exp_panel(M.client)
else if(href_list["jumpto"]) else if(href_list["jumpto"])
if(!check_rights(R_ADMIN)) return if(!check_rights(R_ADMIN)) return

5
code/modules/admin/verbs/randomverbs.dm
View File

@@ -88,7 +88,10 @@
missing_ages = 1 missing_ages = 1
continue continue
if(C.player_age < age) if(C.player_age < age)
msg += "[key_name_admin(C)]: account is [C.player_age] days old<br>" if(check_rights(R_ADMIN))
msg += "[key_name_admin(C.mob)]: [C.player_age] days old<br>"
else
msg += "[key_name_mentor(C.mob)]: [C.player_age] days old<br>"
if(missing_ages) if(missing_ages)
to_chat(src, "Some accounts did not have proper ages set in their clients. This function requires database to be present") to_chat(src, "Some accounts did not have proper ages set in their clients. This function requires database to be present")