From bebd890081f74d3fb42e6451634cb6c70f0a6d5b Mon Sep 17 00:00:00 2001
From: Qwertytoforty <52090703+Qwertytoforty@users.noreply.github.com>
Date: Sat, 9 Oct 2021 12:52:46 -0400
Subject: [PATCH] Apply suggestions from code review
Co-authored-by: SabreML <57483089+SabreML@users.noreply.github.com>
---
code/game/gamemodes/malfunction/Malf_Modules.dm | 4 ++--
code/modules/mob/living/silicon/robot/robot_modules.dm | 9 ++++-----
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/code/game/gamemodes/malfunction/Malf_Modules.dm b/code/game/gamemodes/malfunction/Malf_Modules.dm
index 5c4c8e14367..ca42fb7087d 100644
--- a/code/game/gamemodes/malfunction/Malf_Modules.dm
+++ b/code/game/gamemodes/malfunction/Malf_Modules.dm
@@ -790,11 +790,11 @@
/datum/AI_Module/large/engi_upgrade
module_name = "Engineering Cyborg Emitter Upgrade"
mod_pick_name = "emitter"
- description = "Downloads firmwear that activates the built in emitter in all enginering cyborgs linked to you. Cyborgs built after this upgrade will have it."
+ description = "Downloads firmwear that activates the built in emitter in all enginering cyborgs linked to you. Cyborgs built after this upgrade will have it pre-installed."
cost = 50 // IDK look into this
one_purchase = TRUE
upgrade = TRUE
- unlock_text = "Firmwear downloaded. Bugs removed. Built in emitters operating at 73% efficency."
+ unlock_text = "Firmwear downloaded. Bugs removed. Built in emitters operating at 73% efficiency."
unlock_sound = 'sound/items/rped.ogg'
/datum/AI_Module/large/engi_upgrade/upgrade(mob/living/silicon/ai/AI)
diff --git a/code/modules/mob/living/silicon/robot/robot_modules.dm b/code/modules/mob/living/silicon/robot/robot_modules.dm
index e35e67113f0..38d9c45dbd1 100644
--- a/code/modules/mob/living/silicon/robot/robot_modules.dm
+++ b/code/modules/mob/living/silicon/robot/robot_modules.dm
@@ -174,11 +174,10 @@
R.uneq_all()
modules = list()
- if(!malfhacked)
- if(R.connected_ai)
- for(var/I in R.connected_ai.purchased_modules)
- if(istype(src, I))
- malfhacked = TRUE
+ if(!malfhacked && R.connected_ai)
+ for(var/I in R.connected_ai.purchased_modules)
+ if(istype(src, I))
+ malfhacked = TRUE
// By this point these lists should only contain items. It's safe to use typeless loops here.
for(var/item in basic_modules)